Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Tejun Heo <htejun@gmail.com>
Date:   Mon, 27 Jun 2022 18:15:57 +0900
From:   Tejun Heo <tj@kernel.org>
To:     Josh Don <joshdon@google.com>
Cc:     Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        Valentin Schneider <vschneid@redhat.com>,
        linux-kernel@vger.kernel.org,
        Cruz Zhao <CruzZhao@linux.alibaba.com>
Subject: Re: [PATCH v3] sched/core: add forced idle accounting for cgroups
Message-ID: <Yrl1Tdds6g7h60F3@mtj.duckdns.org>
References: <20220621234443.3506529-1-joshdon@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220621234443.3506529-1-joshdon@google.com>
Precedence: bulk

Hello,

On Tue, Jun 21, 2022 at 04:44:43PM -0700, Josh Don wrote:
> 4feee7d1260 previously added per-task forced idle accounting. This patch
> extends this to also include cgroups.
> 
> rstat is used for cgroup accounting, except for the root, which uses
> kcpustat in order to bypass the need for doing an rstat flush when
> reading root stats.
> 
> Only cgroup v2 is supported. Similar to the task accounting, the cgroup
> accounting requires that schedstats is enabled.

Generally looks fine from cgroup side. One nitpick follow.

> +	seq_printf(seq, "forceidle_usec %llu\n", forceidle_time);

Would it make sense to namespace the name to reflect the fact that
this is tied to core scheduling? e.g. something like
core.force_idle_usec (and yeah, underscore between words, please). I
kinda hate that the feature is named "core". The word is so
overloaded.

Thanks.

-- 
tejun