Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <624cd43b-af83-402d-86bb-68e7242da0f7@os.amperecomputing.com>
Date:   Mon, 27 Jun 2022 16:44:43 +0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.10.0
Subject: Re: [PATCH] ARM: dts: aspeed: Add device tree for Ampere's Mt.
 Mitchell BMC
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        openbmc@lists.ozlabs.org, Arnd Bergmann <arnd@arndb.de>,
        Olof Johansson <olof@lixom.net>, soc@kernel.org,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Joel Stanley <joel@jms.id.au>,
        Andrew Jeffery <andrew@aj.id.au>,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
        Open Source Submission <patches@amperecomputing.com>
Cc:     Phong Vo <phong@os.amperecomputing.com>,
        "Thang Q . Nguyen" <thang@os.amperecomputing.com>
References: <20220621092120.2427152-1-quan@os.amperecomputing.com>
 <97934f38-4da5-ab9e-7089-d6e48edd5e6a@linaro.org>
 <9120c167-38c2-f8c4-e039-4202d5844639@os.amperecomputing.com>
 <aafd58d6-8705-96ee-7813-9b3bae7bb3d1@linaro.org>
From:   Quan Nguyen <quan@os.amperecomputing.com>
In-Reply-To: <aafd58d6-8705-96ee-7813-9b3bae7bb3d1@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZmxOU3Nwby9zQ0pxUUl0emQzeEZKRVl4YjNIRkVRU2xPcU44YWVuUnBCMk5C?=
 =?utf-8?B?TWczbFJzMmN6T3lRcHExSGVFdVRxbHQvYzhmTllDMXRGWVN5cTJ5Slh1YWo3?=
 =?utf-8?B?c2RudkJ0b0taeXBORERjN0NsbmZING5kVlVJeDRQNERXa09VUzA1eVBGMDJ5?=
 =?utf-8?B?MkZaZHhvOWEydUIzaytVb1gyeDdrWXVRR0FxTHZyYS9CL3BGeSttVHFITEJu?=
 =?utf-8?B?SlFkcTN4U2ZRaG9vTWdqcS93bHFHSXFUaVBWRHJPQ0NhS3hUbU1zb0ZmanNY?=
 =?utf-8?B?Rlp2TUh2enE3bTAwUG11Y0t6c0dLdG4xaUw4NWYzK2pNRTlmNlAxdjV5Qi82?=
 =?utf-8?B?QWpMK2g3TE1kbGRqd2hlM3RrdWNpdmdFMjVZaUswaEN6ODcxeXgrR1dUV3Ev?=
 =?utf-8?B?VmxXMkhKNmFmT2NYanpIcWlPVWVlMzlTYlQ0aTdMZWp3ZWpVbE53TlAzdnBx?=
 =?utf-8?B?QitaVklyZ0dzR05sSWFTZzVxdVNlTjlCOFdzcEZBNHdUR1ZLUmtBZXdrVTh4?=
 =?utf-8?B?ZS9oejR2K2h0ZFg1RWgzRmp3akRwNDU5T3JDQWlmd1A2eE9STHhsQXZCc3N4?=
 =?utf-8?B?eEJ5czIwc1lNYmVmbDdJeEZBRjVuL3VENzA1NkxqdnRTZ25acmNVdDFGZ0Zo?=
 =?utf-8?B?Q2lsbGFTYnVUalJKOHdRcDdwME5BMUlqbXk2akt1S053UVd3azBVWjRrNkJK?=
 =?utf-8?B?NkFVc3JGdnlRRmlQYkdiNklvRWVrZXowU251OUxVSHVMTmpoOWF1S0FwMTgx?=
 =?utf-8?B?cTlwNlZINmdybWg2UHRRODNHQ0dUeFVmQmFISUF4VWc1bWhjRDFWZ1A3cTRB?=
 =?utf-8?B?TWdhcGh4S1hGQmVFaStJYXpzTjVBSjAraEU4SGk2ZXVlc3dxc201ZHpDdU1S?=
 =?utf-8?B?NlppT2oweVJ2NnJ3enJodnNHeXVGSE45aTdPanJJdEVHTjlEcytyN0I4UnpM?=
 =?utf-8?B?ZnNYbmszNVVDUGhtQzNqbUsxMnhKeTdtQXgwMlE5dmp2K3F6dzE0NXd5VytJ?=
 =?utf-8?B?ZlVtRTBMbzRlRWo0cGpGNzZKYTE3R3pvbnV3N3RuLy9yRkI1dklqdzN5eW0w?=
 =?utf-8?B?eFFkTk5CRnZyUnVTRGRacW9mcFBpcHJzSHNENmlKeGNaL2xZQmVsUUY3cDF6?=
 =?utf-8?B?Mi83TVZjQ1Rja1ByV3hIQUlkWkludmp6ZmdPS3k5eGw5b0hTb2U1UWxMdFpo?=
 =?utf-8?B?a2FpY3F3OTAreCtjcU8wSHkxTDFiUjVkUlVaUkF1WlVuOXN3YWMvVnJSa2ta?=
 =?utf-8?B?bVgxK0FueWhNUENhOVVBUEhQc1l1STdER2lwbXU1RkJZV3h5TkZCTVNBVmRT?=
 =?utf-8?B?NDd2VHlrY2VIb2pubU1XdVQxczBrK0RwU05CMDg1ckpQbVhHWkJEa3dVaVE0?=
 =?utf-8?B?cldGb3RKV3VHZHAvT0VKUUZlVU9YOHVPNUpRYTY2dVBRaHpINExOdU50OXZQ?=
 =?utf-8?B?VmRNeHhVSktWMExPbWVYMzFrOFN6V1RwSlgzQzFtS1Yza3htVTM4WmVoSWJo?=
 =?utf-8?B?ZFlJOUVLRzRjZ1RWZGh4YnRMZWdvNlBsL25vK3cxc1E1UC9rZS9rbm8rd2ls?=
 =?utf-8?B?VExLNGN5c1dFb0NUcHhra3lMYzhiL2RuK0llcldVd2RPcnBkWnV3NkN6bEZH?=
 =?utf-8?B?cHZ6blJGZUQwcTdmbjVjRWR4K1VkY29Pb0ZBY2V5MUNTNFRHUWxKUGF4YUpM?=
 =?utf-8?B?T0o0cFNYcnYxVXdEeUNGL3NEOHBhaDAzY3ovUlJpczk0MXdoSnBEK01tS0ZH?=
 =?utf-8?B?V0o3VzlsRjNIT2ZERVpMQUoxNVdXeHhtUEtPSlJBT0xBMURYeFh1bnBoWkdL?=
 =?utf-8?B?b3l6UDY4U2s2MEZOQlFlUHV1aXBHd011TTdlcDhTcnJGLzJlem1Tc005SEtM?=
 =?utf-8?B?c0hsQXVuRHQ5blRMU052dVg1U25URHhRZkJWdm1MVHgvRHBWQU8vL1BzUUtP?=
 =?utf-8?B?L296dXMyV2VwdGZIV2xUazNjekJaYURrbGFKdGhPYWRLelpGa09QbHBGMDY0?=
 =?utf-8?B?dk1BZi9FR0hCckFNM0JSSktzakNqK0JKNTVCcHEzM1FnK0tOTUM5VzNWTFZq?=
 =?utf-8?B?VE1lUmMwWnI4R05lQ3FhTjMwRStGc2ZUU0ZyNFZZeG5oMG9MZUdnWEViUDRr?=
 =?utf-8?B?NlFqUG0rTnpIbWU5a0NoODZyK3hUbjJrWmdNYXdNdXprd2Fjc2k4NHVPaUtW?=
 =?utf-8?Q?ZwMqSSOkkiD10VHi5D81qRs=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5cd06342-ea43-454e-a5bf-08da5821b17a
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR01MB7282.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jun 2022 09:44:56.4566
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: scddqReLQ/Id1q9V52OAC3Zvs/1afIc+1JtpvGrcE51G86i4kQABdHtPxxRgE8U7FE+TZdAmd1OZ1cKfmxDDJ83nGcjqoYGL9c37Iq9Qo2k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR01MB5435
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 27/06/2022 16:35, Krzysztof Kozlowski wrote:
> On 27/06/2022 11:32, Quan Nguyen wrote:
>>>> +
>>>> +	ltc2497_reg: ltc2497_regulator {
>>>
>>> No underscores in node name, no specific names (Devicetree spec requires
>>> generic), so ltc2497 has to go. You could add some more specific
>>> prefix/suffix to describe the function.
>>>
>> This is to monitor peripheral voltage so it would be updated to:
> 
> But it is a regulator, not a voltage monitor, so the node name could be:
> regulator-0
> regulator-voltage-mon
> voltage-mon-regulator
> 
Yes, I think I would pick the voltage-mon-regulator:

            voltage_mon_reg: voltage-mon-monitor {

>>
>>            voltage_monitor: voltage-monitor {
>>
>>>> +		compatible = "regulator-fixed";
>>>> +		regulator-name = "ltc2497_reg";
>>>> +		regulator-min-microvolt = <3300000>;
>>>> +		regulator-max-microvolt = <3300000>;
>>>> +		regulator-always-on;
>>>> +	};
>>>> +
> 
> 
Thanks a lot for the quick suggestion.
- Quan