Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Vincenzo Frascino <vincenzo.frascino@arm.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Michael Walle <michael@walle.cc>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Maxim Kochetkov <fido_max@inbox.ru>,
        Colin Foster <colin.foster@in-advantage.com>,
        Richie Pearn <richard.pearn@nxp.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andy Lutomirski <luto@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH net-next 1/4] time64.h: define PSEC_PER_NSEC and use it in
 tc-taprio
Thread-Topic: [PATCH net-next 1/4] time64.h: define PSEC_PER_NSEC and use it
 in tc-taprio
Thread-Index: AQHYiVUJbQ995zeiIUiu+k9xTzwoea1i4yOAgAAQQICAAAmxAIAAC1MA
Date:   Mon, 27 Jun 2022 10:06:15 +0000
Message-ID: <20220627100614.s2arerirkmcnd37z@skbuf>
References: <20220626120505.2369600-1-vladimir.oltean@nxp.com>
 <20220626120505.2369600-2-vladimir.oltean@nxp.com>
 <5db4e640-8165-d7bf-c6b6-192ea7edfafd@arm.com>
 <20220627085101.jw55y3fakqcw7zgi@skbuf>
 <4e4b9e1a-778e-9ca1-5c15-65e45a532790@arm.com>
In-Reply-To: <4e4b9e1a-778e-9ca1-5c15-65e45a532790@arm.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?QcQuAYo3tDxIn0OwgohnL26zPjmYWIXIPyorRmQxlkun7sPvcbAgBwVo9gJp?=
 =?us-ascii?Q?HTykeTYB0GD2piNlzGxJ7c0N0kUxmMrnEO7AhV+LKXxEeVYvMFGdWRUQo+Y5?=
 =?us-ascii?Q?nmlYQRg/m6ROieGH6lUMBSV/QgTatP7m8dVFgjohcNaNItsUqvmjuwjSqJ8y?=
 =?us-ascii?Q?Fd7J0FtT2J2kSdcMVNxDHA9TcOQ0I98F/A9ISa+7ACV4X0Yf2RffOxkA1oUJ?=
 =?us-ascii?Q?yBisBnCU80VZRLd3TD6HyDkktjRhzPQJIPDTqt5etakisGrB7caQw3d7Ef0K?=
 =?us-ascii?Q?kEfaW5v/Qkm1laXQzyLymAn9M8X54bH3bItIAYYWvdbRkOdSO8BWW5p2tN0U?=
 =?us-ascii?Q?puqE/G3icQtv1ZgyWTke389YwE0ttyj8ADnOdCu/VNSbjIh6ok96cdePoELd?=
 =?us-ascii?Q?05ejTvy4xoUwybqAeDF+xDFmm0EnDfEJjYAHG4s4YK1uWte7c+w0twUJohjw?=
 =?us-ascii?Q?Lpoo3xpVzShUO5w3LufPDiHQ2FX2nwHz3wSRkrUlkNWfC0feVYOcBiEN/lnA?=
 =?us-ascii?Q?Ilyj/zzffPjnuTb8w6Bu5ijKZKEBEGPvpsQxTy6SMBcX4WOgQ3h8yhCt+aek?=
 =?us-ascii?Q?KHRCLpIcxDRl0CcE4yYZ9egMrA2zd15mnG+1HpocCZgCJ6ho71vgJeAhY5tz?=
 =?us-ascii?Q?Sz7dkeMALy7z7FFfPvQvN0N2Zch7w0ytZ4YZdeEKC9RAHMxOIBIPFCGGlQua?=
 =?us-ascii?Q?2mtZGytRqllsGp9iwutxNJPoLtTlsNo9BlVZM+4WEovNptTbquOyWNgnqPYH?=
 =?us-ascii?Q?LvzY7Y87zZ9TSmCPZsAKDVwjhixwV/JDkmNnMLKCP8IEzDtndBg7jN+y09eE?=
 =?us-ascii?Q?jD62YjMlea+KKGSao8Lqnucl4bZ6vXAoiJO8Mt7LSSOYRAIEW+iC5zpcL6fr?=
 =?us-ascii?Q?5NRhxY1v1/gF4rtKYZvPgscRKsw6wuzuMYfDCCInRKRFfEIcEUaB2z3PYYtJ?=
 =?us-ascii?Q?Nt+sAX0nNajL5iNnpBEvqZmoHCBYFvq/b/1TNo0RYjkH+sPMjXkBRDXwfNsw?=
 =?us-ascii?Q?uQPbYM6ozq7RQL/Cw02uDcXtl0ogJxHggt8vLNFYWyWyft3DwRXHrUoMYNbq?=
 =?us-ascii?Q?lQf8Al7DS5H7PVzoGZaQgleYlgDSY25FJQbzhOTZjk1KN4VLd+TtqW4Ck4Oo?=
 =?us-ascii?Q?95BbXjbD5vsQ0lAjoYxXkHZtQHtJ7ACH8mft/aghTGzLIvOPIRiODSdwDjR9?=
 =?us-ascii?Q?whhBgjKaG9KbwWmYwHZSOWJ2jLP4FmR39Pb4+sZLuYA4NitM3KsC2p7mbPZs?=
 =?us-ascii?Q?96/8GJh+83YLO2WR3+z8TxFRdwqeNQsOxhZEs4tN7Np4/eScHV8rsFPuIcTq?=
 =?us-ascii?Q?XIi7SycFSqbf2Eft1fCIz2LaBuDcaeBtxpobgYEzAlt4sn+n7Ey7A5hKBxvb?=
 =?us-ascii?Q?Qhak//gu/UT+WgQKMYB2OD9XGhWCyYiimX06bxknW/bH3t4QTdSmMehLvFV5?=
 =?us-ascii?Q?6VyQ8i4NC6H9UOaYhenKajlUhG33jg36CnvwdfFY/8JzCXjd5m7D9B2O2WCt?=
 =?us-ascii?Q?yRt+IyV5La7p8szEI4JHl8xajb+Hk9dKTlJZBuSwRYFiYRJiyKRnhgLPdGGg?=
 =?us-ascii?Q?OUcRzKkUZb4y24c70mR7UEDwiF61O79baU3gLWtIoQC3JBwJvmDT5BQrqhXF?=
 =?us-ascii?Q?jQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <D0FD293E939B8E4C83FE657B2ECF2407@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: db5c84b2-d3a1-4807-cbb6-08da5824abdb
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jun 2022 10:06:15.1409
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: VfplS7vJJSmK2iusCIwGoMuyKqSawqus6sRLl7iMHkW//tputhks8zTfhzJuAo4kEArn7vUQUhqltc498QuESg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8293
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jun 27, 2022 at 10:25:42AM +0100, Vincenzo Frascino wrote:
> Hi Vladimir,
>=20
> On 6/27/22 09:51, Vladimir Oltean wrote:
> > Hi Vincenzo,
> >=20
> > On Mon, Jun 27, 2022 at 08:52:51AM +0100, Vincenzo Frascino wrote:
> >> Hi Vladimir,
> >>
> >> On 6/26/22 13:05, Vladimir Oltean wrote:
> >>> Time-sensitive networking code needs to work with PTP times expressed=
 in
> >>> nanoseconds, and with packet transmission times expressed in
> >>> picoseconds, since those would be fractional at higher than gigabit
> >>> speed when expressed in nanoseconds.
> >>>
> >>> Convert the existing uses in tc-taprio to a PSEC_PER_NSEC macro.
> >>>
> >>> Cc: Andy Lutomirski <luto@kernel.org>
> >>> Cc: Thomas Gleixner <tglx@linutronix.de>
> >>> Cc: Vincenzo Frascino <vincenzo.frascino@arm.com>
> >>> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> >>> ---
> >>>  include/vdso/time64.h  | 1 +
> >>>  net/sched/sch_taprio.c | 4 ++--
> >>>  2 files changed, 3 insertions(+), 2 deletions(-)
> >>>
> >>> diff --git a/include/vdso/time64.h b/include/vdso/time64.h
> >>> index b40cfa2aa33c..f1c2d02474ae 100644
> >>> --- a/include/vdso/time64.h
> >>> +++ b/include/vdso/time64.h
> >>> @@ -6,6 +6,7 @@
> >>>  #define MSEC_PER_SEC	1000L
> >>>  #define USEC_PER_MSEC	1000L
> >>>  #define NSEC_PER_USEC	1000L
> >>> +#define PSEC_PER_NSEC	1000L
> >>
> >> Are you planning to use this definition in the vdso library code? If n=
ot, you
> >> should define PSEC_PER_NSEC in "include/linux/time64.h". The vdso name=
space
> >> should contain only the definitions shared by the implementations of t=
he kernel
> >> and of the vdso library.
> >=20
> > I am not. I thought it would be ok to preserve the locality of
> > definitions by placing this near the others of its kind, since a macro
> > doesn't affect the compiled vDSO code in any way. But if you prefer, I
> > can create a new mini-section in linux/time64.h. Any preference on wher=
e
> > exactly to place that definition within the file?
>=20
> I do not have a strong opinion on where to put it. But I think that if yo=
u put a
> section above TIME64_MAX should work.

@networking people: do you mind if in v2 I move this patch to the end,
hardcode 1000 in the current DSA patch 4/4, and then replace it afterwards
with PSEC_PER_NSEC, together with tc-taprio? I'd like to leave the code
in a clean state, but remember this is also a patch that fixes a
functional issue, even if on net-next, so one dependency less can't
hurt, for those who'll want to backport.=