Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        Jason Gunthorpe <jgg@nvidia.com>,
        Christoph Hellwig <hch@infradead.org>,
        "Raj, Ashok" <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
        "Robin Murphy" <robin.murphy@arm.com>,
        Jean-Philippe Brucker <jean-philippe@linaro.com>,
        "Jiang, Dave" <dave.jiang@intel.com>, Vinod Koul <vkoul@kernel.org>
CC:     Eric Auger <eric.auger@redhat.com>,
        "Liu, Yi L" <yi.l.liu@intel.com>,
        "Pan, Jacob jun" <jacob.jun.pan@intel.com>,
        "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v9 07/11] iommu/sva: Refactoring
 iommu_sva_bind/unbind_device()
Thread-Topic: [PATCH v9 07/11] iommu/sva: Refactoring
 iommu_sva_bind/unbind_device()
Thread-Index: AQHYhX4BFOtH7b1yFE6Yv4ZQbmv7RK1jDeug
Date:   Mon, 27 Jun 2022 10:14:27 +0000
Message-ID: <BN9PR11MB5276297FAEB8C9774AABAD208CB99@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20220621144353.17547-1-baolu.lu@linux.intel.com>
 <20220621144353.17547-8-baolu.lu@linux.intel.com>
In-Reply-To: <20220621144353.17547-8-baolu.lu@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.6.500.17
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1lBrLXCZeFxAgxYSaVw/ObjMJCK2K74E7WKvqvgiOsyGEFk/lxBevqiSJofb?=
 =?us-ascii?Q?8ipKZxDMR2RHIJELKKBZwvi1CtaYZeDf8hR00aGuCm1NtIjyH3qCbJLBYF2V?=
 =?us-ascii?Q?V1pX8knnh9GIp6F+i5d4qFLLh6bng5XrzXJgYn/0U/3n0L0oVmZEB3br+Lzh?=
 =?us-ascii?Q?jQaoK091hcVoh7g8u6Mpn02HpsisKgFKclpZwtb0MS0obnZO23xNMhXafM12?=
 =?us-ascii?Q?LWXKcKAUWZ69E7M8WNfCFAtTmEYDFWfbIbh1wUZvKLlhwG9/YvPEvGP1hBRy?=
 =?us-ascii?Q?Lapy/NaC6w0b306FW6O1XqADUT5vnIDv6gvXSMeHPG5tHSgDrrCAGVuDwZtE?=
 =?us-ascii?Q?NP0DOeZQoeUhAnaTec8HnSoI+ybjSIcik4xmMpm/x/CGz6CZHBXehx1Fgnd6?=
 =?us-ascii?Q?Cq5+/UbZF8kKDxQQelYRh0Z69m5G/6bSQBkEGiuCpI13GQQFUZm/ltP+uw9u?=
 =?us-ascii?Q?9Q+pPCrqr/jbzvxWjTZtHhmu2EvIFpXWWSBVdF8RzFqZuMigEgXIX2bluu6o?=
 =?us-ascii?Q?5ID7lYmE6DuHe+oMcWfEB/Juu06icYngftjxB1GiQL4TGHbl5nSL7nTLpj5R?=
 =?us-ascii?Q?WFxCqi2HH5hh39w36gthFskIy94OEIhIJ6du26oa7hDYl6nB9tjTxjjDSU48?=
 =?us-ascii?Q?TvJtb9ILP/j07jS+KcgKt6sGO4ojT58qpFmI/IY/0pT7GAuUUuwAc/DjYEa/?=
 =?us-ascii?Q?28eIRItpwjQDpLqp9GILVggWy8Xp/gCTxlBwd58vMbUVZpfL0iTlRy92CfLR?=
 =?us-ascii?Q?IzvCdOdxJ+SxoEI9VorNHU2AXjsfNaqvqGl2bJdPyTVMGccTNrIpZnbcz7F1?=
 =?us-ascii?Q?IzN0u2KoGaMLqMK5RKnegY2SauvW8FE89Z4Rp8tN6aXcDlGYdTRYUlPTTN0u?=
 =?us-ascii?Q?tIN2K9oRaTrNuqUOOYHuomT8ti8k+fAd3FgE9PTVV8cPBRlp0I6ADaOmR0eR?=
 =?us-ascii?Q?C5NEMMsFXiq3k87nm2Wk+qAKJRgrDA+FUus3hwTsMGDr2acUH+89/5fwrGVh?=
 =?us-ascii?Q?+1pDNFZch9HungrF2LfltrjVzYvunYwiv0/wG3Jgz5t6avlnmcBGL+/thLcD?=
 =?us-ascii?Q?ozRWcav34831Ts80e+qVYetKnuSUZXkQcS//3G1BsBv//vJYUiDKEZKwreMP?=
 =?us-ascii?Q?ClKP6YCiu6mo22OPFdQsWz4fEfg49+pINmb4LnUIfBfOlmMlGprMbU4Xn/ZG?=
 =?us-ascii?Q?4HE8udRLcsy22hHEx/heeo8PMZIafk//sD7vuIQ7Vax+288+PKZNVi4LzlN2?=
 =?us-ascii?Q?kdx3c4q0cUqFflWFJOG9dtYLABfRVbBs/JmmiLR47/DVpN/H+cQWKZ+VoAJb?=
 =?us-ascii?Q?DiiE6O4gF5fr/OwuXUMa1/B+4wUJ/ccWeBbUohCDdOB4L3zOlB6VHKYvIauT?=
 =?us-ascii?Q?FUMZXFGU9cROkuWGh0VIHXwJfzfacAuNbqB/sX2XytCNgWzTEt4w51r8Ibal?=
 =?us-ascii?Q?WbPqk5Z9tfC99rOxXgS6zorm4gRMzS8fj6buAZSJ3KgKLIAD3QUGXXjigF0f?=
 =?us-ascii?Q?F6ufcpHTYvMlWp3+TLfWTL3E0N0RV+UiSozosqR7H9VKznLhzotmy+a3vtA3?=
 =?us-ascii?Q?JthAYqNcY7Ayx7SRa85tZcLWaeMNsN1c89ow25af?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 00fb832a-6b4f-4eaf-0ef4-08da5825d145
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jun 2022 10:14:27.4032
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: y54qXgbFG1N0CizHx8TDU859Nwp32jjaQ28eCN0s8gWvuyQf4sbre04Tu4zAiJQefoJf7JZgb+YRrSus1XnmcQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4611
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Lu Baolu <baolu.lu@linux.intel.com>
> Sent: Tuesday, June 21, 2022 10:44 PM
> +struct iommu_sva *iommu_sva_bind_device(struct device *dev, struct
> mm_struct *mm)
> +{
> +	struct iommu_domain *domain;
> +	ioasid_t max_pasids;
> +	int ret =3D -EINVAL;
> +
> +	/* Allocate mm->pasid if necessary. */

this comment is for iommu_sva_alloc_pasid()

> +	max_pasids =3D dev->iommu->max_pasids;
> +	if (!max_pasids)
> +		return ERR_PTR(-EOPNOTSUPP);
> +
> +	ret =3D iommu_sva_alloc_pasid(mm, 1, max_pasids - 1);
> +	if (ret)
> +		return ERR_PTR(ret);
> +


...
> +void iommu_sva_unbind_device(struct iommu_sva *handle)
> +{
> +	struct device *dev =3D handle->dev;
> +	struct iommu_domain *domain =3D
> +			container_of(handle, struct iommu_domain, bond);
> +	ioasid_t pasid =3D iommu_sva_get_pasid(handle);
> +
> +	mutex_lock(&iommu_sva_lock);
> +	if (refcount_dec_and_test(&domain->bond.users)) {
> +		iommu_detach_device_pasid(domain, dev, pasid);
> +		iommu_domain_free(domain);
> +	}
> +	mutex_unlock(&iommu_sva_lock);
> +}
> +EXPORT_SYMBOL_GPL(iommu_sva_unbind_device);
> +
> +u32 iommu_sva_get_pasid(struct iommu_sva *handle)
> +{
> +	struct iommu_domain *domain =3D
> +			container_of(handle, struct iommu_domain, bond);
> +
> +	return domain->mm->pasid;
> +}
> +EXPORT_SYMBOL_GPL(iommu_sva_get_pasid);

Looks this is only used by unbind_device. Just open code it.