Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 27 Jun 2022 14:49:49 +0300
From:   Viorel Suman <viorel.suman@nxp.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Dong Aisheng <aisheng.dong@nxp.com>,
        Fabio Estevam <festevam@gmail.com>,
        Shawn Guo <shawnguo@kernel.org>,
        Stefan Agner <stefan@agner.ch>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Linus Walleij <linus.walleij@linaro.org>,
        Alessandro Zummo <a.zummo@towertech.it>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Amit Kucheria <amitk@kernel.org>,
        Zhang Rui <rui.zhang@intel.com>,
        Wim Van Sebroeck <wim@linux-watchdog.org>,
        Guenter Roeck <linux@roeck-us.net>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        NXP Linux Team <linux-imx@nxp.com>,
        Abel Vesa <abelvesa@kernel.org>,
        Oliver Graute <oliver.graute@kococonnector.com>,
        Mirela Rabulea <mirela.rabulea@nxp.com>,
        Peng Fan <peng.fan@nxp.com>, Liu Ying <victor.liu@nxp.com>,
        Ming Qian <ming.qian@nxp.com>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
        linux-input@vger.kernel.org, linux-gpio@vger.kernel.org,
        linux-rtc@vger.kernel.org, linux-pm@vger.kernel.org,
        linux-watchdog@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, Abel Vesa <abel.vesa@nxp.com>
Subject: Re: [PATCH v5 10/14] dt-bindings: firmware: Add fsl,scu yaml file
Message-ID: <20220627114949.pg7az36fz4jrwebp@fsr-ub1664-116>
References: <20220616164303.790379-1-viorel.suman@nxp.com>
 <20220616164303.790379-11-viorel.suman@nxp.com>
 <b653d7af-f846-abb2-d260-3ce615b070a4@linaro.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b653d7af-f846-abb2-d260-3ce615b070a4@linaro.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?k4GOIOj9KR0SmLgkAxygpLWtFlhX9zo5cS18dcl24GYoItxuKvWDtvDBt7jd?=
 =?us-ascii?Q?D6aAghnkXqJ3mwg+l9iTLdrZ2tOUJISeYQ3pLrL2BF9/6IDMI8yoSiTA/+SO?=
 =?us-ascii?Q?w8zxRCEEICGNW0r3XQdv8K8mYklhCLL5ijNPuq+pc7n7IXyf7G1/AF64vQYK?=
 =?us-ascii?Q?6+no8iz2yGFQHE79mDiBmyNsVa+eS5MQYWg0Ijp+RcxqGl27Uaq9RH7aOTS2?=
 =?us-ascii?Q?0G84nWG+0C/LJFbl6k21UTKNIu9uT8T+E+dGfZkoHLYjrsZDV7CXYBLT4hWO?=
 =?us-ascii?Q?gnVPjCJvWa0vDJg6aH2+UrPCGEeEvQeUeSVTDMsEO6a/losnMaZJXjOZuFyg?=
 =?us-ascii?Q?LzbsP+E/Wikp54frMrk0tTm4ngtm6YNhKtvccdSaz1dYyjeXgo0ignLEqVjv?=
 =?us-ascii?Q?IBmlCMh1We55iWWQL8L3Qt6y8/k+l7NR+Z7qN6GTWDvtZnBZVmSAwcY48a2p?=
 =?us-ascii?Q?Xt+upYS2Ble9kbTZ0fN39REFDoF45olZ4oUasyL+bcmS3MXdF6Zm2q+0VE+X?=
 =?us-ascii?Q?NDfutwV4PkkKxN5UpxlL/NnR7PO273lY7+scjT+w53mreQSU+oxKPSQzsTpd?=
 =?us-ascii?Q?A1Nixh0OB3tJYCZANx9mjgbMrQo5PJP1sczFaRvlH8xv2ULZsYJP2ZwasCCs?=
 =?us-ascii?Q?wN3/RjE2Y31TUtsIzdyMAB5PnzdhjCAS280DmAL4+PR5YdEnFGEHRbv1SSwj?=
 =?us-ascii?Q?7UHzOV6El67dfI0Q9MbY6hSnXV5ECTX6bf3LbvHNyGI7XXkMVWI5Vpz+1B0R?=
 =?us-ascii?Q?8jJOhKEJr2LyFTCa4uMKcWeGeCropp+0QpXZ8UUawopJ/C3+Yv6OBQ/LCsoV?=
 =?us-ascii?Q?WueDcRf7uN3t4cuHITSFpcaLCWXHcwKPNzmLGKwiSTl1QSgpUmNXjhpbHT1Y?=
 =?us-ascii?Q?fBUXhQ09WA/PsfGpy6VYJU0nYy1wkpjkneFCpbALNizcjPV1Mx1GGQRMPJ9B?=
 =?us-ascii?Q?P2HiRfFQuf8DtU96UFFozPtXZ/9MuSMIc9WiZT0KTZKrBZisfGLud2zr+3pb?=
 =?us-ascii?Q?4A7Q7hmd2Nx91pu4lAT1Qb9BlWlUFNCEvuhjeQeOAEFwaYDMM24UVx2mTlup?=
 =?us-ascii?Q?V+OJBhg+IRfsOlZ2Q7bx3LoSPG1VxtRmJ/hCvX9NMIbOwIZK1oz0Hwk9D+8v?=
 =?us-ascii?Q?GkO6MmTD0rbD0fGgpKIAkYbI/gVvq9AA4VfYDXsVgt56JigQSVDP/rrDWjqo?=
 =?us-ascii?Q?8KdbKXiC2XypZUbuO6kIYuYKxQdefXxBvuFl4LG4VjZj8VImk3ARAlDxWeGs?=
 =?us-ascii?Q?ZdlyiOl5AGlmoWIabgUf7o76q+aUXcItvfXkrO6iWUS0BXsUSnyGrvCijGjT?=
 =?us-ascii?Q?lPudeSRQnWv1XJSGwLO2mAndyjZZrhWk6PxFIgG8OFWTEcz6lGxUL/EUiJQX?=
 =?us-ascii?Q?9Uuq0bkB2oTkTUPC521GB/xZWrvsBBDV4VxCCgZcpXFnniod+u7sD1IDOZoK?=
 =?us-ascii?Q?aYyfp8K7ECQVUQq8h8NzEKojDbaumqwUBf7dFAZ7/+8/9161Cz8kHdpK65bM?=
 =?us-ascii?Q?N2ZqmX+e3s+LzN6OJRqHkbK8ixoKcsqOHWWWslR+zdOSfscs+6HOOtW+HDrW?=
 =?us-ascii?Q?KQh3rQs9WUOpBL9N3BB6EiBOk9yzGK/FHOpf5s0A?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0448d220-e139-44e5-1291-08da58332d0a
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5005.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jun 2022 11:50:05.1994
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uxe8mnobozH6XABoZZHiGNnxa/aMVBz+N7ZWJxXfGM1kmvWTrzfxtASuPoS11u+MFyyvB1TV6GUOLzwFunZ4/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5484
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 22-06-24 12:25:44, Krzysztof Kozlowski wrote:
> On 16/06/2022 18:42, Viorel Suman wrote:
> > From: Abel Vesa <abel.vesa@nxp.com>
> > 
> > In order to replace the fsl,scu txt file from bindings/arm/freescale,
> > we need to split it between the right subsystems. This patch adds the
> > fsl,scu.yaml in the firmware bindings folder. This one is only for
> > the main SCU node. The old txt file will be removed only after all
> > the child nodes have been properly switch to yaml.
> > 
> > Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> > Signed-off-by: Viorel Suman <viorel.suman@nxp.com>
> > ---
> >  .../devicetree/bindings/firmware/fsl,scu.yaml | 170 ++++++++++++++++++
> >  1 file changed, 170 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/firmware/fsl,scu.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/firmware/fsl,scu.yaml b/Documentation/devicetree/bindings/firmware/fsl,scu.yaml

[...]

> > +properties:
> > +  $nodename:
> > +    const: 'scu'
> 
> Why enforcing node name? Second point is that node names should be
> generic, so I wonder what "SCU" exactly means and whether it is generic?
> 

It stands for "System Control Unit" - looks generic to me.
I guess a reason to enforce it - need to check with Abel - might be
the need to group multiple SCU implementations under a common known name.

> > +
> > +  compatible:
> > +    const: fsl,imx-scu
> > +
> > +  clock-controller:
> > +    description: |
> > +      $ref: /schemas/clock/fsl,scu-clk.yaml
> 
> That's not a valid syntax. ref is not part of description
> 

Right, will fix that, thank you for review.

Regards,
Viorel