Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp2904198iog; Mon, 27 Jun 2022 05:28:07 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tl9x7KPsbn7w1MrkE+IAtPU1FM7ZHd1oT4efEaQ4Nwcy8LI+ZrLCef3BgZNNgi+RzORU49 X-Received: by 2002:a05:6a00:2995:b0:525:398b:8585 with SMTP id cj21-20020a056a00299500b00525398b8585mr14908693pfb.7.1656332886914; Mon, 27 Jun 2022 05:28:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656332886; cv=none; d=google.com; s=arc-20160816; b=F3Tv2AoTHYILPH/KSy75sBnfyxu5VgaAwuPImnRzIdeFy49JqC3W+ADw7wNSePRkRb 1oRdIoWokamdMCGgEOyjS+Jv9Qep25h9Ld3OpFxolrSlWOjvwHyWVQpqghcJHGfP4/cY aOe0R3rVgROMtONXmyWLd9qFs63uQZP2pjJovuB4bQLZquQ2B6DRm/yrKPqAYiiaovTB FbBH0S2anLbpdYOw9kT5xP7c0ORe73C0FrmDlI95HC6XxjaYxJiZbAGpoJuJ1s0e2HxO SZ6qHNHZVbKHZZ5m2snI1yV+xLrVIDMENnxVh8aClj9lFPnZKeLWjxHgSMOIn9l4hz5F tbwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=7cTdlJs9DlFkmf53P6ZJIcUaeDtl01E75kK4zo5Zt6Y=; b=CaiagnJsE4U7hTc+pUqFWA/o4ydC4wL2OYYIgLPvlmG6viexAX5hlU9wBKLiQyzm8H +/gcnIMtb59Bt2QqrJT3KN7EZwas6mp06g6npfOJDWJ/OGNGDD/ghGxlQzFsedn/7ty+ gXDgQVA2tgvzFp1yYV/WHP4ypQ9U4sL38UEs298lSN1EkzfGLqWEzpuGcXPL9Y5bk2ez nBjzoAd/GUKoDiZyx/OprCOjUk4YghOiyRevMXMvfwuLIhHsSFRVrxZWO8FPFvZe21Dm WI7VjjeDyM9zss4ZV+RWmPDmXn37v5aX5/QPHpcAwnYhTJ6OWrBRam1ZzrBQSpcxio6A wq+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mjtouuWw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id pc11-20020a17090b3b8b00b001eaac606001si18061495pjb.118.2022.06.27.05.27.54; Mon, 27 Jun 2022 05:28:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mjtouuWw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235557AbiF0LaT (ORCPT + 99 others); Mon, 27 Jun 2022 07:30:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235419AbiF0L3N (ORCPT ); Mon, 27 Jun 2022 07:29:13 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B0B8109; Mon, 27 Jun 2022 04:28:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2D06F61494; Mon, 27 Jun 2022 11:28:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39F97C3411D; Mon, 27 Jun 2022 11:28:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1656329290; bh=NqWKPAx54vazXc3qKoDsW40jReYuUC9TIV8zapkZdIQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mjtouuWwTbNllOMFg/k8oV6IGa1i4Vmy7jdM81p27HdTlg5Zcka/O6By316TrSMdv ElWneVZpW56k6/awhPyTbWwLR2moVAlOP02l/pc2n3fDs1P70flMyjLsHq1tZ2vzVG vXxdITunATjDZkxDd1xmcS7zqESTkiUzXA2CdtCs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Takashi Iwai Subject: [PATCH 5.4 03/60] ALSA: hda/via: Fix missing beep setup Date: Mon, 27 Jun 2022 13:21:14 +0200 Message-Id: <20220627111927.748906353@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220627111927.641837068@linuxfoundation.org> References: <20220627111927.641837068@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Takashi Iwai commit c7807b27d510e5aa53c8a120cfc02c33c24ebb5f upstream. Like the previous fix for Conexant codec, the beep_nid has to be set up before calling snd_hda_gen_parse_auto_config(); otherwise it'd miss the path setup. Fix the call order for addressing the missing beep setup. Fixes: 0e8f9862493a ("ALSA: hda/via - Simplify control management") Cc: Link: https://bugzilla.kernel.org/show_bug.cgi?id=216152 Link: https://lore.kernel.org/r/20220620104008.1994-2-tiwai@suse.de Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/hda/patch_via.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/sound/pci/hda/patch_via.c +++ b/sound/pci/hda/patch_via.c @@ -520,11 +520,11 @@ static int via_parse_auto_config(struct if (err < 0) return err; - err = snd_hda_gen_parse_auto_config(codec, &spec->gen.autocfg); + err = auto_parse_beep(codec); if (err < 0) return err; - err = auto_parse_beep(codec); + err = snd_hda_gen_parse_auto_config(codec, &spec->gen.autocfg); if (err < 0) return err;