Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp2905091iog; Mon, 27 Jun 2022 05:29:25 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uW3Z9PZzqxLH1SjkNk/1eWQtJRWb6HRXTW6iMkCijAxiD6LMQjX9QpPG/lThyP0T20x43B X-Received: by 2002:a50:cb8b:0:b0:435:68a3:4d40 with SMTP id k11-20020a50cb8b000000b0043568a34d40mr16531300edi.394.1656332965167; Mon, 27 Jun 2022 05:29:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656332965; cv=none; d=google.com; s=arc-20160816; b=cbOcQ4Wx5SvvcQA/EgOPNIHAbyy7o3Qi5FDyJFqdc1fpS4bNdgntOk06dwR/1jshxZ DxTUdqyg4sOOzS1cU0mItcxeBUTv6BMpLbg2zWBfgcw+QH52BhK28HUaAPaCABUDtsYG CpAjyS4OXB7HFNBDv7R1iVLDcmKbvcplOfh/8LD2B2keBoViul4uO93QjBM71r9HO1jj pDWrOCHrwM1hxraWpE3nMASxX9i8DUSsEm0DxrP4XVWfHCLgAR1M7WAbTuXp5/yv6XSF F5vn+z4cVUhvw+kM4eOCD7dy4RxVYJHklvEqDUSqxEZPKo7EqnFRalzq1OjIHVi1lB/C 9VuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=7cTdlJs9DlFkmf53P6ZJIcUaeDtl01E75kK4zo5Zt6Y=; b=XKLRP2A0j1CH1P6wsB5+l9wG9zZ2abBYoldtFKZK0S3GYQtAzBgDHy55S0uwH3mzy1 5r63XTGyU1y/eJXwVCpUKn2T9OATaDdYQCHI5s+YykDW0MmNNVzAZ498HbGasEFySp70 Jek/vNveRELMJL/KTBBHEsPxrHH58oW0epelXmRPw17tVXm0CLwqp5+520cSr5mvaSdJ nHAe9nvFqO2Mq4k+LcpK8NzkSN8lSLf9TVZJIxScVs4oJWpozG6zyavPYptIb53u9EKV jqGFz/ZyAdMrn4cWArL/fefGchSjVqwF3o9/gwWaEmCAupEnw7msyI7gTv/zQsCaDbRY lVlw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=pznxYGZ4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y8-20020a50eb08000000b00435775deb20si10800180edp.181.2022.06.27.05.29.00; Mon, 27 Jun 2022 05:29:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=pznxYGZ4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234803AbiF0LYy (ORCPT + 99 others); Mon, 27 Jun 2022 07:24:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234777AbiF0LYh (ORCPT ); Mon, 27 Jun 2022 07:24:37 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA9126586; Mon, 27 Jun 2022 04:24:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 67D37B81126; Mon, 27 Jun 2022 11:24:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1415C341C7; Mon, 27 Jun 2022 11:24:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1656329074; bh=NqWKPAx54vazXc3qKoDsW40jReYuUC9TIV8zapkZdIQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pznxYGZ4wo4UJMSG2VpnIVJ4y2uoxA17KyN3vpcpIqvFd7n820lVKE84TVOF8sESM zfhtbn7niMG5uLvDRy31tVQnk7TQbZ4d+BEBtg4V24FMFvtdz9kTekeNHpVTj2h5HM IB3NdM31XdNX6qQ86dVmOsF6hUJhtZXdcKZSuO2c= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Takashi Iwai Subject: [PATCH 5.10 004/102] ALSA: hda/via: Fix missing beep setup Date: Mon, 27 Jun 2022 13:20:15 +0200 Message-Id: <20220627111933.591599060@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220627111933.455024953@linuxfoundation.org> References: <20220627111933.455024953@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Takashi Iwai commit c7807b27d510e5aa53c8a120cfc02c33c24ebb5f upstream. Like the previous fix for Conexant codec, the beep_nid has to be set up before calling snd_hda_gen_parse_auto_config(); otherwise it'd miss the path setup. Fix the call order for addressing the missing beep setup. Fixes: 0e8f9862493a ("ALSA: hda/via - Simplify control management") Cc: Link: https://bugzilla.kernel.org/show_bug.cgi?id=216152 Link: https://lore.kernel.org/r/20220620104008.1994-2-tiwai@suse.de Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/hda/patch_via.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/sound/pci/hda/patch_via.c +++ b/sound/pci/hda/patch_via.c @@ -520,11 +520,11 @@ static int via_parse_auto_config(struct if (err < 0) return err; - err = snd_hda_gen_parse_auto_config(codec, &spec->gen.autocfg); + err = auto_parse_beep(codec); if (err < 0) return err; - err = auto_parse_beep(codec); + err = snd_hda_gen_parse_auto_config(codec, &spec->gen.autocfg); if (err < 0) return err;