Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220627075148.140705-1-code@siddh.me> <9f79f8edfa8f7c5099b842f020782ac2@linux.ibm.com>
In-Reply-To: <9f79f8edfa8f7c5099b842f020782ac2@linux.ibm.com>
From:   Vlad Dronov <vdronov@redhat.com>
Date:   Mon, 27 Jun 2022 12:56:12 +0200
Message-ID: <CAMusb+RDvUG9ZmSH0cxqJAXzniDDihsuaWhKu7M8bchatcuUSQ@mail.gmail.com>
Subject: Re: [PATCH 1/1] tools/testing/crypto: Use vzalloc instead of vmalloc+memset
To:     freude@linux.ibm.com, Siddh Raman Pant <code@siddh.me>
Cc:     Herbert Xu <herbert@gondor.apana.org.au>,
        LKML <linux-kernel@vger.kernel.org>,
        Shuah Khan <skhan@linuxfoundation.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Thanks, Siddh,

This change makes perfect sense.

Thanks, Harald, for helping with this!

Best regards,
Vladis Dronov | Red Hat, Inc. | The Core Kernel | Senior Software Engineer

On Mon, Jun 27, 2022 at 11:54 AM Harald Freudenberger
<freude@linux.ibm.com> wrote:
>
> On 2022-06-27 09:51, Siddh Raman Pant wrote:
> > This fixes the corresponding coccinelle warning.
> >
> > Signed-off-by: Siddh Raman Pant <code@siddh.me>
> > ---
> >  tools/testing/crypto/chacha20-s390/test-cipher.c | 9 +++------
> >  1 file changed, 3 insertions(+), 6 deletions(-)
> >
> > diff --git a/tools/testing/crypto/chacha20-s390/test-cipher.c
> > b/tools/testing/crypto/chacha20-s390/test-cipher.c
> > index 34e8b855266f..8141d45df51a 100644
> > --- a/tools/testing/crypto/chacha20-s390/test-cipher.c
> > +++ b/tools/testing/crypto/chacha20-s390/test-cipher.c
> > @@ -252,29 +252,26 @@ static int __init chacha_s390_test_init(void)
> >       memset(plain, 'a', data_size);
> >       get_random_bytes(plain, (data_size > 256 ? 256 : data_size));
> >
> > -     cipher_generic = vmalloc(data_size);
> > +     cipher_generic = vzalloc(data_size);
> >       if (!cipher_generic) {
> >               pr_info("could not allocate cipher_generic buffer\n");
> >               ret = -2;
> >               goto out;
> >       }
> > -     memset(cipher_generic, 0, data_size);
> >
> > -     cipher_s390 = vmalloc(data_size);
> > +     cipher_s390 = vzalloc(data_size);
> >       if (!cipher_s390) {
> >               pr_info("could not allocate cipher_s390 buffer\n");
> >               ret = -2;
> >               goto out;
> >       }
> > -     memset(cipher_s390, 0, data_size);
> >
> > -     revert = vmalloc(data_size);
> > +     revert = vzalloc(data_size);
> >       if (!revert) {
> >               pr_info("could not allocate revert buffer\n");
> >               ret = -2;
> >               goto out;
> >       }
> > -     memset(revert, 0, data_size);
> >
> >       if (debug)
> >               print_hex_dump(KERN_INFO, "src: ", DUMP_PREFIX_OFFSET,
>
> Thanks Siddh
> I'll forward this patch into the s390 subsystem and on the next merge
> window for the 5.20 kernel then it will appear in the upstream kernel.