Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp2910017iog; Mon, 27 Jun 2022 05:34:47 -0700 (PDT) X-Google-Smtp-Source: AGRyM1v87Yye+WEVl2Rpey8Vy1U9q67tTjqaJ1kCpfBR/wUR72Q9vDFQI64orMYeinwQaaLpH3RE X-Received: by 2002:a17:906:8894:b0:726:2b46:a978 with SMTP id ak20-20020a170906889400b007262b46a978mr12396864ejc.86.1656333286835; Mon, 27 Jun 2022 05:34:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656333286; cv=none; d=google.com; s=arc-20160816; b=F6DHBAcZHwb320tGN/1oHhujSbB74CZsfsmU7hASt81gZ6PMrjXKJMjBRUI856VhaR flPLStjtgRHLbVVEFzF19UthW2yRw6q3LSEJgmP2BIle5aOXhf44s9sjrZ80oR0yGemG C3jjQGB8hNfqN4NrN37cdlm2iwTw7/V4pFANSMQjZqFuBauX+yxzE/GqQlB1vzEhwlDR rP1LMp73eEfTKwOsqqpmqCY/tnUi9Eln0N6P4wTRzyBJU7O0seTQIT9gZ5AgdxhxZxCF +o9YMFllAvyNIXESzDxBa/GcPN0QtnckXWGEKDHDdVKSrHIhnMvrrS7V9T1CAhOjcTrR qCiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=UT2g7ZNHJPbbqwYBdRdSfxWwdcRdfNIQBzEF1qBSqes=; b=x0hO/3vxeYs2js0JOftuSAz+khsPT93w/JqXJzGkLg6oKa146Hwdx79/SvVbJCv594 JxWq9AYXlalDMW9oncCq0wdflArfaeV/m6ySplG+BLYRc522/sysTSDLOd3PpF8HFuKY okcQzyfHfLpJpan0hkR5PDrB+xXoSnbzg0bS/wiMkvgy6UH7SNY0CwqPmGuG8ULGoezA Ffh7uZMez7A9qnGURCB92BAxBqUZDaTZMvXaDr525MBBQjC3khKgIpqy6dqUmlMkT/CQ TWHqozsfKlmmKuS5+uZesnPnYvYg17PaTZe8CV+OVYa+W+9QVkakA9j3ToCCvBvqXDYW uTYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=r2lIVSWx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j37-20020a05640223a500b0042dd46b5a89si13197695eda.243.2022.06.27.05.34.22; Mon, 27 Jun 2022 05:34:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=r2lIVSWx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235282AbiF0L24 (ORCPT + 99 others); Mon, 27 Jun 2022 07:28:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235276AbiF0L1b (ORCPT ); Mon, 27 Jun 2022 07:27:31 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 015979FED; Mon, 27 Jun 2022 04:27:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3BA626149A; Mon, 27 Jun 2022 11:27:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 32DC5C3411D; Mon, 27 Jun 2022 11:27:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1656329229; bh=WZXy+Bd4DgG1VVzSNOzT8zUIRZ/5VvEGPPSlCWy6ceA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=r2lIVSWx7JCzB6xQrJqPjjstDD8Qh4Fi6PP3L5+8l/lMsSWIKIuhikuoOKB6xN/76 V2QsSkhMU2gt+bjS39zWevvNn89Z0D0KrbNFd4X5D77U/Xze+m9fumWOsDcFnhW2E7 QBY/ALuQj9JQYNRN3UAm6IIw/IKFJ3swQCjTuCq0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miaoqian Lin , Krzysztof Kozlowski Subject: [PATCH 5.10 094/102] ARM: exynos: Fix refcount leak in exynos_map_pmu Date: Mon, 27 Jun 2022 13:21:45 +0200 Message-Id: <20220627111936.255657266@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220627111933.455024953@linuxfoundation.org> References: <20220627111933.455024953@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miaoqian Lin commit c4c79525042a4a7df96b73477feaf232fe44ae81 upstream. of_find_matching_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. of_node_put() checks null pointer. Fixes: fce9e5bb2526 ("ARM: EXYNOS: Add support for mapping PMU base address via DT") Signed-off-by: Miaoqian Lin Link: https://lore.kernel.org/r/20220523145513.12341-1-linmq006@gmail.com Signed-off-by: Krzysztof Kozlowski Signed-off-by: Greg Kroah-Hartman --- arch/arm/mach-exynos/exynos.c | 1 + 1 file changed, 1 insertion(+) --- a/arch/arm/mach-exynos/exynos.c +++ b/arch/arm/mach-exynos/exynos.c @@ -149,6 +149,7 @@ static void exynos_map_pmu(void) np = of_find_matching_node(NULL, exynos_dt_pmu_match); if (np) pmu_base_addr = of_iomap(np, 0); + of_node_put(np); } static void __init exynos_init_irq(void)