Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4889b697-c962-a043-f2d2-0788a5bd1deb@nutanix.com>
Date:   Mon, 27 Jun 2022 17:43:38 +0530
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.10.0
Subject: Re: [RFC PATCH 03/26] hugetlb: add make_huge_pte_with_shift
To:     James Houghton <jthoughton@google.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Muchun Song <songmuchun@bytedance.com>,
        Peter Xu <peterx@redhat.com>
Cc:     David Hildenbrand <david@redhat.com>,
        David Rientjes <rientjes@google.com>,
        Axel Rasmussen <axelrasmussen@google.com>,
        Mina Almasry <almasrymina@google.com>,
        Jue Wang <juew@google.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
References: <20220624173656.2033256-1-jthoughton@google.com>
 <20220624173656.2033256-4-jthoughton@google.com>
From:   "manish.mishra" <manish.mishra@nutanix.com>
In-Reply-To: <20220624173656.2033256-4-jthoughton@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c1kvWWc3bDhVZnBPQnhnVVlRcWJwcnFTQ2hkeC9BbitNZk0zU0EzdlZkNksv?=
 =?utf-8?B?djFxMUZyblRZT1BWcWN0dDQzdVpQaXBncVlkK1MvWE02SlVyZnNFSXNwUklU?=
 =?utf-8?B?T3FWNXlmTUprbnMvWE9WWFYwVThTZjI0djkvbDhvcDhLMXlRQ3FJV2xpL0pv?=
 =?utf-8?B?dk1BL0lGN3YwVlFpSDRVcFVEcTU5Vk01L1N5MzhWb091amh2SkhGS3BhSzhH?=
 =?utf-8?B?V3FmcTc3Z1NjM09KMnkzL3JtMDlSTDd3NkJqMkRNdy9ZTmVsd1Fqa2VXeEg3?=
 =?utf-8?B?b2k0NGpuU05IbC9xTWs2YWRHMUh2VVM3SU5wR3YxTjFqMS9PYnVwWjIyZG8x?=
 =?utf-8?B?MytHaWhWY2hxTWRCSFJSYTZibEtHYXVFOEUzYitWSU9rMkJTbVdvSU1MK05a?=
 =?utf-8?B?S2YwMm54cEZlSGFDVHRRQVJqOHg0WVB6c0svNnE3QWN2bDhjLzJMZmFlbXNH?=
 =?utf-8?B?eENaSTEvdU5XSE5UWllKUkhzREkra2treVFldGpzUE1HT25RY3pKMUlHN0Z4?=
 =?utf-8?B?cjllNW11WU9hTW55U09MbldMQ1V5NE0wZGUzZUhCM2ZYTFB3bjk5NWV0TVFa?=
 =?utf-8?B?SVB4L2hYVHVnYUE4Z1BBUVc3VTlVUFdJamxhcDJIdzdNSmNDTFFGK2ppbk9m?=
 =?utf-8?B?UkpFN1dDQmE2M0llOVZ3SERkZ09ES0xMVmlLYXIzcElKWkhJOVpTSDFYdm1K?=
 =?utf-8?B?OXZ0OWZzU2RjK2VuSVAyY3FwMG5hc25hZkljb2FiNVYzNmIxc1YwaTBpSVdL?=
 =?utf-8?B?SGdJM2sxYUg3RUc1Qy9la0NzQUpqTUNjVDVoU05oam95Vk5zZm9Uak4rOEN2?=
 =?utf-8?B?WU9RclN3Z1hJV3Fyb0lVY1EyUUdtME54Z3pXOG1NdW5ZNko0NWdEUVNRelZn?=
 =?utf-8?B?VTNtQTVJM1I1TDEwV2tuUUJYbUFXMG90dkZKazdtYis3cExWV3p5K1lyeWta?=
 =?utf-8?B?SVFBUGk3N3gvSW5RdzY4L3JMdEE4MnhGQTVkZHVxTDJSa2lnQzZDM2VlL3A4?=
 =?utf-8?B?eGU2ZlF5U3Q1RHRIL1U0UTBSTHM5M0pYVTEwL3JqMWZFZ3VjTDlKNTBkM2li?=
 =?utf-8?B?QTNOSGxMRVlOOGE3ME5kZU5JOVNjV3lqdnNrQWZ4bFhYVUxpNEdqM2NtWjYw?=
 =?utf-8?B?bHFzT1J4Y2g2YjNJaUpneEMyWVpBL3M4QkVVLys1VVlKTnFzb2xvVkJ0U04v?=
 =?utf-8?B?SW5Xc2hjd0NtZlBvcFBKYkY0YXE5T1R6Znk5ZXk2Rkl6VVFMWE52WU5UcFkx?=
 =?utf-8?B?ZWpEaU5TSkRab1F6RDlPQVIxYXArSFJoRkZMc1diRVRadFJaYUthMmdNZkVr?=
 =?utf-8?B?SWtBZEIxQnBkeTNkdVl0Zm1keE93UnpSVlkrM3pWOE5TY1pMRmpvdi9vUGcx?=
 =?utf-8?B?QUwrQnFES1V2STFGT09tSzB6TzhCK005WEhpSnNNaktoNVJ1Mkh2SVNXL3Er?=
 =?utf-8?B?TCt4dGZ2N0tzVzhaRjNUQitaMjBiVS9KRnkwNU83dmNqdUphbkVaVTdtOGhD?=
 =?utf-8?B?Z0xva1NJSldPZEYvU2hyczhBTG9XRi9zK3FrbHdpZzJjVHRDUk8yb0p1YjZ4?=
 =?utf-8?B?bUU4UnZYcDYyWTVvb2RRMmVOUkk1QVBHb3phMEFPemQvR3dmZ1RYZ0ZqdndG?=
 =?utf-8?B?b3ArSGZSdUhhdGJ6d1JUT1hhMG1WS29Rc0pzWUNBRDhxc0lzZGYyaklhNXVS?=
 =?utf-8?B?UnQrUVhpMjZKVTJrQkFqMytNSmZHd3doa3dmWTNMUDBQWHJtUXh5UFdXbDFr?=
 =?utf-8?B?NlN1dkxqdnhveDdLdHJrczBzV0JScWhEbXNHMXJmUFpHb2E4UGdVRnhZcG10?=
 =?utf-8?B?Q0sxVnlSUFF5WTgxTEh4c2FVN253VzZOeHRCeHk4ejhYc2pEYkJLT3Z3UzJ0?=
 =?utf-8?B?VGZtdjZWakZOYXBGbjk5em1raG55a0tUVEdKMEVVQ3pSemRYY3Z3RXlPQWhQ?=
 =?utf-8?B?YXpldjMxam8rcDNDVWNTOE9VUGJYRFZBcktpSG5CR0FRSVpDL0NPYmNYWGN4?=
 =?utf-8?B?R2lWaUN3Y0U3dzk5c3BjVnR4TkNRbTVSTzVBSWFGK0owMXVHYm00cEZGenBE?=
 =?utf-8?B?STA5d3RjbU00KytlVVlZeFNYRkV4dlhVR3E4M0RGcjQrYUViNlBTWXdYMVAv?=
 =?utf-8?B?c3RSbUFSeWxhUjh2SlFORC9BNkl4dnBIdloyYm1FQjVyN0R6L1VFdmZPYVFW?=
 =?utf-8?B?Y2c9PQ==?=
X-OriginatorOrg: nutanix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8ac9734f-0ec3-4b37-f64c-08da58367f54
X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7384.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jun 2022 12:13:51.7067
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xuwnMAZL0rAWBGxk0bABpEGiq8wkROwR2yAslGtLEvEcpJH8B0ZN1u6AslvAOXiueIELakyBdcFkWs0UsD920IHSwbO8ZKdj9ewFrFbAg1k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR02MB8225
X-Proofpoint-ORIG-GUID: a6vK394OPPHDMCm1qDn86FdeBYKTHN-A
X-Proofpoint-GUID: a6vK394OPPHDMCm1qDn86FdeBYKTHN-A
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-06-27_06,2022-06-24_01,2022-06-22_01
X-Proofpoint-Spam-Reason: safe
X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 24/06/22 11:06 pm, James Houghton wrote:
> This allows us to make huge PTEs at shifts other than the hstate shift,
> which will be necessary for high-granularity mappings.
>
> Signed-off-by: James Houghton <jthoughton@google.com>
> ---
>   mm/hugetlb.c | 33 ++++++++++++++++++++-------------
>   1 file changed, 20 insertions(+), 13 deletions(-)
>
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 5df838d86f32..0eec34edf3b2 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -4686,23 +4686,30 @@ const struct vm_operations_struct hugetlb_vm_ops = {
>   	.pagesize = hugetlb_vm_op_pagesize,
>   };
reviewed-by: manish.mishra@nutanix.com
>   
> +static pte_t make_huge_pte_with_shift(struct vm_area_struct *vma,
> +				      struct page *page, int writable,
> +				      int shift)
> +{
> +	bool huge = shift > PAGE_SHIFT;
> +	pte_t entry = huge ? mk_huge_pte(page, vma->vm_page_prot)
> +			   : mk_pte(page, vma->vm_page_prot);
> +
> +	if (writable)
> +		entry = huge ? huge_pte_mkwrite(entry) : pte_mkwrite(entry);
> +	else
> +		entry = huge ? huge_pte_wrprotect(entry) : pte_wrprotect(entry);
> +	pte_mkyoung(entry);
> +	if (huge)
> +		entry = arch_make_huge_pte(entry, shift, vma->vm_flags);
> +	return entry;
> +}
> +
>   static pte_t make_huge_pte(struct vm_area_struct *vma, struct page *page,
> -				int writable)
> +			   int writable)
>   {
> -	pte_t entry;
>   	unsigned int shift = huge_page_shift(hstate_vma(vma));
>   
> -	if (writable) {
> -		entry = huge_pte_mkwrite(huge_pte_mkdirty(mk_huge_pte(page,
> -					 vma->vm_page_prot)));
> -	} else {
> -		entry = huge_pte_wrprotect(mk_huge_pte(page,
> -					   vma->vm_page_prot));
> -	}
> -	entry = pte_mkyoung(entry);
> -	entry = arch_make_huge_pte(entry, shift, vma->vm_flags);
> -
> -	return entry;
> +	return make_huge_pte_with_shift(vma, page, writable, shift);
>   }
>   
>   static void set_huge_ptep_writable(struct vm_area_struct *vma,