Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp2923948iog; Mon, 27 Jun 2022 05:53:12 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tCBFErB/CSaMJ0z22wJGQ5oVO6Q/pcDy6hRRklaKM27xuv5gRUMsk8+STGkYibu3GFTZD/ X-Received: by 2002:a05:6a00:451c:b0:525:b802:bc3d with SMTP id cw28-20020a056a00451c00b00525b802bc3dmr5421707pfb.43.1656334392491; Mon, 27 Jun 2022 05:53:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656334392; cv=none; d=google.com; s=arc-20160816; b=e2I6yxL+px5jM4h6uB8Ci1Vj9MAVhDIKJgAuO2MFKVXhLnGZkZbB8y/1onaTSFFTxo 0EzYXt/I2jYDZnV4LrQFWbFFBjAn5vpQPV5B4a5rIptU1lQLFZ3mxrb5rJG574bCbmTN 0PQQLelcakyYGhzEcvO6UmVNt4vYfXaA9pQTzihVquniseonKyQGzwXQaKlkQ2BWQKlr xXYVGjPghLxHhCy2QTGOR5eiApINRdMnrpflNrfsh78JBG7guV0DOK9yRMKg2Uh2s+Y1 +0RwjwpY7FQq1h7sioarQwd32BjloNaNwaA9IYNW7jbcLEWTih5gI04OP5w+JqHN52jj i1DA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=7cTdlJs9DlFkmf53P6ZJIcUaeDtl01E75kK4zo5Zt6Y=; b=sWSgDyGCLlEsPZMiGkwn9g3kdnPUmT92uml4R662g1pg1NwnndRsHIMaNEi/cSDRNr foCdFJ3253SjJYH5BUxubTooWRmpYXsSCvmvMt2o6erv3tskOWj3yIrIVSN9+HKz75rH HqgFkpThbZndysArrNSyfGK+ohuNzxvifDMRxAMmw1TFwCpmvNDEDiiZ3tR6upaTHt8k PTDs4M0v35I/Gf5iBYX1JH+HsG+kKR3mquiJfkE98zvb/CYLhPpdQ8CxRPjWHIDFNyY1 CpGY2hsFArfEowD8QICer8wea5AAUEKud1Bs2wh6MWD3t2hcm2V90+f2z6NR9DULKi40 NeNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=X8e5b3+Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hk8-20020a17090b224800b001ecd7df15a5si13111142pjb.46.2022.06.27.05.53.00; Mon, 27 Jun 2022 05:53:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=X8e5b3+Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237780AbiF0LqQ (ORCPT + 99 others); Mon, 27 Jun 2022 07:46:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237542AbiF0LnE (ORCPT ); Mon, 27 Jun 2022 07:43:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6B8725ED; Mon, 27 Jun 2022 04:38:34 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3C90B6114F; Mon, 27 Jun 2022 11:38:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B05EC36AE7; Mon, 27 Jun 2022 11:38:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1656329913; bh=NqWKPAx54vazXc3qKoDsW40jReYuUC9TIV8zapkZdIQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=X8e5b3+Zh5iDv1F4RX0LQRCTGT5R3nrYHRBPDqCS6oaZvp+AQQc19jcC0LB5Vx1l4 9glTF5jGM1ANfGxoZOfp0gVYoc9Bcu+lrSk3RIANx51cGoETyHM3vd+JYFFYRpTqRe dwsSNQPRZgkEyoLsyWmwwl148pIc/iRQTUplqINo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Takashi Iwai Subject: [PATCH 5.18 004/181] ALSA: hda/via: Fix missing beep setup Date: Mon, 27 Jun 2022 13:19:37 +0200 Message-Id: <20220627111944.687712838@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220627111944.553492442@linuxfoundation.org> References: <20220627111944.553492442@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Takashi Iwai commit c7807b27d510e5aa53c8a120cfc02c33c24ebb5f upstream. Like the previous fix for Conexant codec, the beep_nid has to be set up before calling snd_hda_gen_parse_auto_config(); otherwise it'd miss the path setup. Fix the call order for addressing the missing beep setup. Fixes: 0e8f9862493a ("ALSA: hda/via - Simplify control management") Cc: Link: https://bugzilla.kernel.org/show_bug.cgi?id=216152 Link: https://lore.kernel.org/r/20220620104008.1994-2-tiwai@suse.de Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/hda/patch_via.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/sound/pci/hda/patch_via.c +++ b/sound/pci/hda/patch_via.c @@ -520,11 +520,11 @@ static int via_parse_auto_config(struct if (err < 0) return err; - err = snd_hda_gen_parse_auto_config(codec, &spec->gen.autocfg); + err = auto_parse_beep(codec); if (err < 0) return err; - err = auto_parse_beep(codec); + err = snd_hda_gen_parse_auto_config(codec, &spec->gen.autocfg); if (err < 0) return err;