Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ef93aae8-ad15-9332-7871-4020b126760a@nutanix.com>
Date:   Mon, 27 Jun 2022 18:22:03 +0530
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.10.0
Subject: Re: [RFC PATCH 08/26] hugetlb: add hugetlb_free_range to free PT
 structures
To:     James Houghton <jthoughton@google.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Muchun Song <songmuchun@bytedance.com>,
        Peter Xu <peterx@redhat.com>
Cc:     David Hildenbrand <david@redhat.com>,
        David Rientjes <rientjes@google.com>,
        Axel Rasmussen <axelrasmussen@google.com>,
        Mina Almasry <almasrymina@google.com>,
        Jue Wang <juew@google.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
References: <20220624173656.2033256-1-jthoughton@google.com>
 <20220624173656.2033256-9-jthoughton@google.com>
From:   "manish.mishra" <manish.mishra@nutanix.com>
In-Reply-To: <20220624173656.2033256-9-jthoughton@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eUdlS1ZqNlpOQlRwRmtlbWR1MDBiN2pWUnQ1RVJwUElQUzRWdng0NHBucE5E?=
 =?utf-8?B?SFRQKy8rNmlNeG5VVnN4RU40UFZyaUgybnVmOG84dmZxWkFlRXV5ZWsySFcv?=
 =?utf-8?B?NHBwbElCaUZJS0M3MjM5SlBQUlV2UDB1K1J3UEFIWCtTNTBpMjF0M3ZDbWJa?=
 =?utf-8?B?d3RKYW5Ic1VLT1BXTGhiZHAxNW5pK0ZnM0cxc29kMnpwdjYxZTdLNDJVUFkz?=
 =?utf-8?B?VDF0emdYUk9YSEVjd2JSbVQ4c0EzR3djZ3duYlNqT0JzbFBoaDBDcldBd0FG?=
 =?utf-8?B?OUtTeHV1YWxaajBCWjBkM3ZNOXhpQkJEMDFadnl1WEo5QVMvbCtUZCtUM0Rt?=
 =?utf-8?B?RVg3RGpScFh4MEpsQ25ZNUtjQ1Jub1lVWVJSSUQraGZuZ1lrTmZzYTR0cDBv?=
 =?utf-8?B?NlhIRVVQSEF4QktlSlB2Q1hoSjByZWN5UFV4dVAyT2s3K3ZoNHMrZytkaTA0?=
 =?utf-8?B?Q1ZBbVZhRjVnK1pMWkNtVjdJSmdOVkRtRlpCbHdUdUtLbUFMMHFJWTlRYzdV?=
 =?utf-8?B?a0lIcXI1OUwyWTdmbmpNcllmbkhRN0NrbUEzRmIzODhJU2tUNlcxVHdSY3o5?=
 =?utf-8?B?Mk02R1F6RlA5RktGOFBPdVQ3RkdDLzVOcXY1V1o0WGJKN2FCWm04Q3RvV01i?=
 =?utf-8?B?MGdHc0JnUWdZWXVXUFFOZm5LZkk4amtXRUtxamxJazM5dlpycDV2UElIYTMv?=
 =?utf-8?B?SGFTbU5Dd2laNTBEWUY1NDdJWVU4SWhFOWNxRGx0WmZ6Q1VFOENDN0Z4alJI?=
 =?utf-8?B?ZCt5YXJjWDRhM3ZBU3F4QUJLbi9QaEFuZ2EwY1ZYc3NIYUNCemtNQytxK2pH?=
 =?utf-8?B?M2RXaXBkYnE1NWZ2ajhMTFBqNUp6RExkQjg2MVl2R29uL0thUjdxTHNhQ2dH?=
 =?utf-8?B?b2ZaMGpMcmhTWExlczRrU2VvS3M5SWptZG5IaFBBMVJwczl1N0YyUWUxTlB5?=
 =?utf-8?B?VWwvNGdPYTRTaEZJOTRudmp6cnJzeFdudWpRRjlITzY4dy9VOW1wZGRuNm42?=
 =?utf-8?B?bzIvZlMvMEZhbjdteStuY2p3L1QreUxYRWZtV0ZPNUVpTU5lZ244TmZ4b3F1?=
 =?utf-8?B?eTVyWVJ0ZS9HTGtNNmZSSy8reEtaZkpXaGVSVE05SnMvSGhvZVk5c0UvZXFD?=
 =?utf-8?B?YjhVai9GM0pJeUlDSnNsd3lEeTQyanM5ZHZZbVdTMlZxSmR5OW1zMlBsY0Uz?=
 =?utf-8?B?MWhnVCtmUGI5ZHo3Lzk5NWpzSlFrVVJxZkxnWlNJN1JpSkx1cVZjL1dxTm85?=
 =?utf-8?B?U3U1RksvSVY4ZTJjSjROTi9BRFJ6Nlk0aWYrclJ3WWtWRXRWRFZIcnZsUitW?=
 =?utf-8?B?a0M5NzYycExQNUVKOHNLYXJNRjRwWHFpM1l6dGptaENHdjgrME5BdUpLSnFo?=
 =?utf-8?B?enVFYnNXd3JBVml5SmpYWGlNU3JSR0JPaTY3K1lPYUJzTnNXdTcyZU9kWWNO?=
 =?utf-8?B?VkRxaWpSMnNhMnRsVjE5MjhISkxWMnF0NDZ1Y1FiNjFCNTB1NDdDanB5Y00z?=
 =?utf-8?B?VElaTE1LWVVrZ3Y0ditOWFRmdlg4SGFDZmdxcndtQ2tIQWJDV3JVY1NhMVYx?=
 =?utf-8?B?ZG1YL0xmTzZWTjh1Q3hDUWI2d1NzQXRyNVR4NHYzc1RGbGJhLytlSjJ4UEtj?=
 =?utf-8?B?aktnSjc3aVJ5bmJ4NlRQRitDeWcxa2tJZjVIazNsR2JEK0VQdmpxSVJDRUJs?=
 =?utf-8?B?Z2hIM0cxT1hoN1dVYTB1UE53c3lFUUZ2dTNGTm1oV0JjcjlUOExObDVjWEIx?=
 =?utf-8?B?NmN5Z1IvL2VNcFd1d0hMUzhMVmZXQWJmV21rTVREQ0YvelZUbkVYa3RiTlEy?=
 =?utf-8?B?RmNhYkFjUFRsUGszWmxZbU42Yzd0YTVZNTdXYWV4WlkrSzBMN3FQeTlPVWRj?=
 =?utf-8?B?cE1uMm1jMW5yVVVkOGRXVVJWTDRxaUhDMnppVDVrNjI2Z0JZUHhvRjhuRDJR?=
 =?utf-8?B?NE1kZEVTZTB1SXVuRjJWeUZkRGcrS2lYZmtHWkFhME1RZEF0NWw3TE5QMS9S?=
 =?utf-8?B?VHFXcEtuOWxQK3BYUHhrNzJ6ZUw0a2pOd0VWbTVsczB1WmhveEVMRU1UQklv?=
 =?utf-8?B?MDVlOExyZjY0N1BVY1UxbG9HbWNJeGJuQ2wyVVZzNm1jOGFiM2xjMWx3c1lM?=
 =?utf-8?B?TWQyN2FSaEhpQ2ZRbnBUSXZyMVV1d1FFK2xwSHFaSmxtSHFNMTFjQkVlRC9S?=
 =?utf-8?B?RVE9PQ==?=
X-OriginatorOrg: nutanix.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fd8531b7-e2da-419e-771a-08da583bdf54
X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7384.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jun 2022 12:52:20.0763
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tGHTRRvqucW2UNQFKAon6oGBGPRT0VmYv7NSsE3P81lS+j067a8PW/ZviXBbOzvZ3pNc5zd80DIWu70JxAlBInNIEEaedRrykR9I/2GYCpw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB6185
X-Proofpoint-ORIG-GUID: cIP_dA2jcBBkZp44cx34O88sCAPzhUdA
X-Proofpoint-GUID: cIP_dA2jcBBkZp44cx34O88sCAPzhUdA
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-06-27_06,2022-06-24_01,2022-06-22_01
X-Proofpoint-Spam-Reason: safe
X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 24/06/22 11:06 pm, James Houghton wrote:
> This is a helper function for freeing the bits of the page table that
> map a particular HugeTLB PTE.
>
> Signed-off-by: James Houghton <jthoughton@google.com>
> ---
>   include/linux/hugetlb.h |  2 ++
>   mm/hugetlb.c            | 17 +++++++++++++++++
>   2 files changed, 19 insertions(+)
>
> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
> index 1d4ec9dfdebf..33ba48fac551 100644
> --- a/include/linux/hugetlb.h
> +++ b/include/linux/hugetlb.h
> @@ -107,6 +107,8 @@ bool hugetlb_pte_none_mostly(const struct hugetlb_pte *hpte);
>   pte_t hugetlb_ptep_get(const struct hugetlb_pte *hpte);
>   void hugetlb_pte_clear(struct mm_struct *mm, const struct hugetlb_pte *hpte,
>   		       unsigned long address);
> +void hugetlb_free_range(struct mmu_gather *tlb, const struct hugetlb_pte *hpte,
> +			unsigned long start, unsigned long end);
>   
>   struct hugepage_subpool {
>   	spinlock_t lock;
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 1a1434e29740..a2d2ffa76173 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -1120,6 +1120,23 @@ static bool vma_has_reserves(struct vm_area_struct *vma, long chg)
>   	return false;
>   }
>   
> +void hugetlb_free_range(struct mmu_gather *tlb, const struct hugetlb_pte *hpte,
> +			unsigned long start, unsigned long end)
> +{
> +	unsigned long floor = start & hugetlb_pte_mask(hpte);
> +	unsigned long ceiling = floor + hugetlb_pte_size(hpte);
> +
> +	if (hugetlb_pte_size(hpte) >= PGDIR_SIZE) {

sorry again did not understand why it is >= check and not just ==, does it help

in non-x86 arches.

> +		free_p4d_range(tlb, (pgd_t *)hpte->ptep, start, end, floor, ceiling);
> +	} else if (hugetlb_pte_size(hpte) >= P4D_SIZE) {
> +		free_pud_range(tlb, (p4d_t *)hpte->ptep, start, end, floor, ceiling);
> +	} else if (hugetlb_pte_size(hpte) >= PUD_SIZE) {
> +		free_pmd_range(tlb, (pud_t *)hpte->ptep, start, end, floor, ceiling);
> +	} else if (hugetlb_pte_size(hpte) >= PMD_SIZE) {
> +		free_pte_range(tlb, (pmd_t *)hpte->ptep, start);
> +	}
> +}
> +
>   bool hugetlb_pte_present_leaf(const struct hugetlb_pte *hpte)
>   {
>   	pgd_t pgd;