Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f55999ae-4ff3-2616-fda1-a97e5aa11524@amd.com>
Date:   Mon, 27 Jun 2022 09:20:00 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH] drm/amd/display: Remove unused globals FORCE_RATE and
 FORCE_LANE_COUNT
Content-Language: en-US
To:     Tom Rix <trix@redhat.com>, harry.wentland@amd.com,
        sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com,
        alexander.deucher@amd.com, christian.koenig@amd.com,
        Xinhui.Pan@amd.com, airlied@linux.ie, daniel@ffwll.ch,
        wenjing.liu@amd.com, Jun.Lei@amd.com, George.Shen@amd.com,
        Jimmy.Kizito@amd.com, Jerry.Zuo@amd.com, michael.strauss@amd.com
Cc:     amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20220626142053.3373970-1-trix@redhat.com>
From:   Aurabindo Pillai <aurabindo.pillai@amd.com>
In-Reply-To: <20220626142053.3373970-1-trix@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NytoMldkZGt6UDNTN1dVQ0FtMGZQdzQxN1RCUlA3dzRhRFJka1l6N0xsb25j?=
 =?utf-8?B?TzFPOEl6aTBzUTRFWVFDOWNHbDA2eHRpeGdvd0o0Myt4MVVBTDVoNzMwY3BI?=
 =?utf-8?B?dFlVU3Z2SzJNbWJCUExhUXhTaTFzZkdiZTlFUDh6R0dnSDJESVMrZmRiMDRC?=
 =?utf-8?B?VnZBTkU3TjNqbFBRSnZ6SytTUVNrUVpLUFgzU0tFT0xPZVZ6S3lBdHNiOW1i?=
 =?utf-8?B?UlVadlNUazZHWGtwMWxkUFo0aVlDK3NNREFKQy9FZ0x1aHdMQmVtRWV6bzRx?=
 =?utf-8?B?dld6QTd5ZStTdVE4V1YrWTZxZzgya3o2L1lCZUIzckpGYTNmT2FEN21SN2JZ?=
 =?utf-8?B?TTNpekoxZSt4MC9RQndncVpKK3VNemdVQm9aYUxSNFBUbEo2bThUSXVVQmQw?=
 =?utf-8?B?NlVUZ3R0cjdvQ1FXWklUT3RSTXNHQSt0V281V2puQlE5K2M5dkI4MTQzblVE?=
 =?utf-8?B?WFVsRzJiQnY4Ulc0eHU1ZlNZTGREMHE2cklZOEFwbC9JQWdLUVpnQ2RSaEJG?=
 =?utf-8?B?OFE0WnRwa1FSVVJieE5BdVk4Vjh1d3dHNUJ3eFd5Zk4rN2JhWURiMUFOMHg3?=
 =?utf-8?B?MTlyOHMvb3ZTRDFlRW9vWXBUV0tSdEdSYnhPd1VoWWdFNVpLYnBNVUdwNm90?=
 =?utf-8?B?bVd2Z2dTS2c4RU42VWhWUHNIVnd0YXBMemtSZUovd2NNdUYwdnRPRDh6aEs1?=
 =?utf-8?B?NFdDOUV1ZmZPdWdEVVRSaGJlNTc3SmJkL04za3ptM1hHMVE1ekZGbkkxTngr?=
 =?utf-8?B?a1BDWjdBcjhodHkzQVN3Zkcyd3NlYzI2TklCV2ZDMDJoNDduRkR4VTBKekhw?=
 =?utf-8?B?K2Z3SGZUTGVsRndLRzZad1pwTk8vYXhMdVhpNk1udEd0UXdjYkNuSGFwelo3?=
 =?utf-8?B?NHlDdURxemovdi9keTdRSUt5YUZ5WVJ0NFo2RlE5TXNDRXlrditBNjZEaSt4?=
 =?utf-8?B?NlZIcGxyTWlLZnBzUXg5WkZQSXg2Nld2L0dqcmVLSWJXNDAvcU1ja3J4UHZw?=
 =?utf-8?B?YTNSWGs5Sk0rdzJiMEwyVk5NcGdLMFpXblNpaEV4Tng4anY1Rm52YTVmU3BG?=
 =?utf-8?B?RTAwRnZJbUpibGNzYUZnMHVKazkwSzVmQ0tpTjdNUkxOYmI1Mzd1bmJXM0pM?=
 =?utf-8?B?eFNaSHlPQVQrY1dScjhTR3ZmYU9pN0RXRjBLWjhIdk1hOUo2SkwyT0pub0dH?=
 =?utf-8?B?OWxxQnhUV3JSZnJEQnJJZG5weEdtdW1ZTDJuWDU5NkQyeEZTZ3J6ekkrQTZo?=
 =?utf-8?B?QWk4MHhEMzZzYklrSWJ3NDFmYktsdDVpdzkzM1YxK1lTeVVNZ1A1UkpCRVVL?=
 =?utf-8?B?K3VPdHJIeURuQ1NZTTU3U0Vmc1M3elFuMkhFZFpkTDVhTjlTaFAvU0x6Q3ZT?=
 =?utf-8?B?NDVuTHAvNUtCTzJ1OGZtUnh4YTBLUGh3QkdTd2ZiZ1QxZXFWUlEvR3ZtNFh6?=
 =?utf-8?B?Q2NIV2wvUXR5RGI0K2pHNFdLK0txRnpoRHlxNENZdTZiVllWNDBBaWlRQ2pG?=
 =?utf-8?B?K0RqdDBKNGZiRHBkdThkditMYmw2MC9KNnJWOWl6cVV5M0ppTmVYY3ZjOVBB?=
 =?utf-8?B?VVVOcVg2VWVtNmFWSmRWN2VMMGpLclZ0ZFRTbXNjNVE1N0lhT0pLZnpreFFu?=
 =?utf-8?B?Z2xwV3MxZCt0TnIzTmZNUkhBN1hRZnBhRGFHUjR2TzYyU2hJRVNTbTlpVXVS?=
 =?utf-8?B?UUxjM3RIWEFneTltejNDZ0YrUnBRQVJrMlNVTmxMZXA0U0d6RHVtdVlwZS9a?=
 =?utf-8?B?MkpyQUFVY1h2RVE2WEJSSG52cEdYOGplQjlCTnp4TFp3K0U5YldMNW1tZ2pM?=
 =?utf-8?B?SGhHTm1rR3Jza3hQTVNWWjJ5Vk9VamFjUnRORi9FckRDeE5QZlF0T0Nwdkt1?=
 =?utf-8?B?UU5iKzk3NUNtdEJ6bjFqbW9kWnRHdjBjeXhoZFBFRlQ5KzNZd05RVUlhelI5?=
 =?utf-8?B?VUM5VDF2YWRNZGFhYXRpenBZU1pZOC9kZnkrdXdXK2hta002eFk4TU1qMDJy?=
 =?utf-8?B?ZC9kTXhRR01NbmprMllBcWk1MkZibCtDSFdUbG1YQUIxNVNHcUhWYitIZmhP?=
 =?utf-8?B?dTlKWVI2NVkvODdWM0RKMnJaN2QyN3Y3c2F2anJtWmZtQTZMY1BuUlk2RzUz?=
 =?utf-8?Q?A13HxEyDj1HROjwlaOiq+WiKg?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 24aca21d-a20e-40e4-54b9-08da583fbe92
X-MS-Exchange-CrossTenant-AuthSource: CH0PR12MB5284.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jun 2022 13:20:03.3228
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +Wfz/1VBOsnxCtRAh0Q7AgtJCR/H3JueGkIBpqkwdKP4FviWd5mAJMKYzOlqHh0XVBhVys9RaePnMXbsdk3Jpw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1634
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2022-06-26 10:20, Tom Rix wrote:
> sparse reports
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:3885:6: warning: symbol 'FORCE_RATE' was not declared. Should it be static?
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:3886:10: warning: symbol 'FORCE_LANE_COUNT' was not declared. Should it be static?
> 
> Neither of thse variables is used in dc_link_dp.c.  Reviewing the commit listed in
> the fixes tag shows neither was used in the original patch.  So remove them.
> 
> Fixes: 265280b99822 ("drm/amd/display: add CLKMGR changes for DCN32/321")
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>   drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> index be1dcb0a2a06..f3421f2bd52e 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> @@ -3882,9 +3882,6 @@ static bool decide_mst_link_settings(const struct dc_link *link, struct dc_link_
>   	return true;
>   }
>   
> -bool FORCE_RATE = false;
> -uint32_t FORCE_LANE_COUNT = 0;
> -
>   void decide_link_settings(struct dc_stream_state *stream,
>   	struct dc_link_settings *link_setting)
>   {


Reviewed-by: Aurabindo Pillai <aurabindo.pillai@amd.com>