Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <34b5c26c-bf3f-4b7c-3dd8-9e1317968c28@amd.com>
Date:   Mon, 27 Jun 2022 09:20:13 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH] drm/amd/display: change to_dal_irq_source_dnc32() storage
 class specifier to static
Content-Language: en-US
To:     Tom Rix <trix@redhat.com>, harry.wentland@amd.com,
        sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com,
        alexander.deucher@amd.com, christian.koenig@amd.com,
        Xinhui.Pan@amd.com, airlied@linux.ie, daniel@ffwll.ch,
        Qingqing.Zhuo@amd.com, mario.limonciello@amd.com,
        nicholas.kazlauskas@amd.com, maira.canal@usp.br
Cc:     amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20220626144615.2227149-1-trix@redhat.com>
From:   Aurabindo Pillai <aurabindo.pillai@amd.com>
In-Reply-To: <20220626144615.2227149-1-trix@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TFNDbWM3Q0VKa3hxWWJmaDdsNWhCL2w5UGhHc0dlc2hlbW5mdno5dDRta3ls?=
 =?utf-8?B?R0JkVEVEOThsUUMxWVZ1V3d2OUZKRXFxSVRDUkIzZ1Y5T0tmOG1xMlFiU2Iy?=
 =?utf-8?B?a2RKa1lNaWt6VlVDbDNVTEFjRVp5bDBWNnZhL3VGMjlsR25qTFFJa1lXU21U?=
 =?utf-8?B?ZUtrYjQ4QWVUaVpHLytqMjdzN3hhVVArVjZ0ZUJkVmQ5aVZFQW1XeXUybDdv?=
 =?utf-8?B?aWgwbFZIRkM3WWZJYy9HZDhKbG9ZamVOSzFSUm9DQkxmWVJuSEpBdnBVOWFL?=
 =?utf-8?B?bEZiSDhpRFJuOThJb2lMb0oyd0RZZXFuZnoxOFMzYjQ4UHlPZkkwbm4xSTFM?=
 =?utf-8?B?aURSTlNLQTVUQ3p5d1hnUmxXQWlTMG0rZm0zZ2U3YW5EOFJQM1FiVklGcXIv?=
 =?utf-8?B?b1k4dW1IUjloLzkzeWVBeGk2azkrd2ZQMGEyVDVmVkhsbUhYQUJheVJYdWRs?=
 =?utf-8?B?OGttUzVGbW84ZUxMcTF0N3BDMWlxZ0lDenI0c2tjVGFvelMyQjZjeHd3RTB5?=
 =?utf-8?B?MlJFRXMyZldPYUJuMU53djhtTXFBemxKaGIrME9nb1kyWlNtbGI0SEpacnZx?=
 =?utf-8?B?SXRmMGlhWG1rdkp0QzErYVRPcDQ5S1dQMndyZTUwbm11RUw0ejdmcDA2cGhX?=
 =?utf-8?B?SVlQLy8zd1dQdERZRVBZTnA2T0ZuZXNXdi85REQySTB4RW1BK1IyUkNmV3d3?=
 =?utf-8?B?dFhYWlE4OWZlSFYvemZxTVZ0aFZFQ1ZxSlNOY2NmRG90a1NGTnRYamRUdHps?=
 =?utf-8?B?a21vTmpBbWpGUVY3MHJKb2E5ZDZyOXJTM3FCRzAyRUJUL0hkUDZjUTZPRmc1?=
 =?utf-8?B?M1FzS0dtNFlTejFHdVFWV2c3V0JDdFVaY3JtT25ydW9ZODBJNmVlTWpCVXlK?=
 =?utf-8?B?dVE5c0ZEYmZlR1E5YUhMMFBhQzVTNUlNZnpKTGVSUWNydXgveVR0MU9tYktD?=
 =?utf-8?B?Y2NuK2x3Y3FPVlJURUJqTXpPVDBaNUJnU1hlem91ZXZSSk8wQWdzY2xDZ294?=
 =?utf-8?B?dis2VDBobFZnQUNCZlVWRi9DM0lJNTJEdkZCSzZqT2g0YkM0VHNGK3dodk1x?=
 =?utf-8?B?L2FFN1VUQlFIVS9RUE14VGpnc1ZJMGZQRUhqUnVWTy9Ibzc5SlNtT1BQcEVj?=
 =?utf-8?B?WUs1UDluS3A4bGFjOGdmZGtZK2VMam9rZmMzbVBQN3o4YlEwUnpFWTRMa2w2?=
 =?utf-8?B?VHo1dFhRTldCWGhCVlVHMkFwaFlKNVp6clVvbkNYUStXMkY5V21pTHJIMVZv?=
 =?utf-8?B?eXA4dU91MENsSS9vclUyT29ZcmRKQXBDT2ZzbU84ck05c0VKaExtZFByMFpK?=
 =?utf-8?B?NGcyK1UvK0NGZEhiUS8xRDRZaTc1WWNYV0RxTi9WekFwYmhOTFZmTWZxU2tQ?=
 =?utf-8?B?M1BneDVyNTE3K3BFT092OEdhZ3pWS3g3bWh3N1o0c0hDazA5YXB4S1ZBRk15?=
 =?utf-8?B?T1pVWGxvcjVMOVFBenpGT1BPaUxuMC9xU1ZwWUFwd2VMTTk2bW96NVArTWp4?=
 =?utf-8?B?TnJZRjZQUTJZUnBReVgrQlgzeXhFaDI0bWdXRmkyWHF6cmdFVWhKRlg4cEQz?=
 =?utf-8?B?eFVHeUZjOVVhWXphNHczR1l2R013Y2lxUklRNktRQm1kVzlEOGI5emIxbmM1?=
 =?utf-8?B?M2ZxTFQydktYUkw3NXJ6UUs4MmFOU2NOWlJuRWJCMkR4VGtDaEVkWDV1ZjNN?=
 =?utf-8?B?TWRCZzcxTzBzNGtMSmtBTWtSc2xmQmRuUkcxUUZVL2xRMm90UzlaT1BzaEpR?=
 =?utf-8?B?dzZpQ1J4L3c1R1FqL01yRzJVQ2FBR000RllFUlE4VHVYUThOd3hDSEJtUThj?=
 =?utf-8?B?aEdUNVVEYkY1SEttQ2k0NEUybERBUkhTMEdYZHdmZHArcXRsd1dEQnBsUDg3?=
 =?utf-8?B?eHU1b3hUdllrY05JalZuenhWdi9aNVpBQThhMHpLZVBGYUkzNmdBRFB2UVZp?=
 =?utf-8?B?R25aZjRWU3JOeXZJL3ZiWUZKcFU3OUhuVzhaT0VOdjdvMWxaaWpVcyswS1FR?=
 =?utf-8?B?bEV1dUN0V1U3UDVyVHZremFHVjh2eXlPL0o0RE5pVjVGZ0pQMUxmR3JkNkUy?=
 =?utf-8?B?b1RxcXNEOUhTYjFPYVlqRVpIOGpVV2xha0R5bVB6T2VDajNOK0lrblVzUGRp?=
 =?utf-8?Q?Nxq6PRJBHlpDnfdGh/M23wRRv?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4d03025e-08cf-44a1-90ea-08da583fc5b4
X-MS-Exchange-CrossTenant-AuthSource: CH0PR12MB5284.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jun 2022 13:20:15.0894
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oh+f/K20sjGT4wJRG/zTJ3kxeiiLLmq36LQAntnge8jndNuBC3iq6jZsAMRM3FSKlpK4aygtyMFb5bMK2oBwOA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2953
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2022-06-26 10:46, Tom Rix wrote:
> sparse reports
> drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn32/irq_service_dcn32.c:39:20: warning: symbol 'to_dal_irq_source_dcn32' was not declared. Should it be static?
> 
> to_dal_irq_source_dnc32() is only referenced in irq_service_dnc32.c, so change its
> storage class specifier to static.
> 
> Fixes: 0efd4374f6b4 ("drm/amd/display: add dcn32 IRQ changes")
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>   drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c b/drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c
> index 3a213ca2f077..b1012fa1977b 100644
> --- a/drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c
> +++ b/drivers/gpu/drm/amd/display/dc/irq/dcn32/irq_service_dcn32.c
> @@ -36,7 +36,7 @@
>   
>   #define DCN_BASE__INST0_SEG2                       0x000034C0
>   
> -enum dc_irq_source to_dal_irq_source_dcn32(
> +static enum dc_irq_source to_dal_irq_source_dcn32(
>   		struct irq_service *irq_service,
>   		uint32_t src_id,
>   		uint32_t ext_id)

Reviewed-by: Aurabindo Pillai <aurabindo.pillai@amd.com>