Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0d90c2cb-e0e9-a112-1c85-9aa8fdd54311@linux.ibm.com>
Date:   Mon, 27 Jun 2022 15:29:13 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [PATCH v10 1/3] KVM: s390: ipte lock for SCA access should be
 contained in KVM
Content-Language: en-US
To:     Janosch Frank <frankja@linux.ibm.com>, kvm@vger.kernel.org
Cc:     linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
        borntraeger@de.ibm.com, cohuck@redhat.com, david@redhat.com,
        thuth@redhat.com, imbrenda@linux.ibm.com, hca@linux.ibm.com,
        gor@linux.ibm.com, wintera@linux.ibm.com, seiden@linux.ibm.com,
        nrb@linux.ibm.com
References: <20220620125437.37122-1-pmorel@linux.ibm.com>
 <20220620125437.37122-2-pmorel@linux.ibm.com>
 <74a234eb-0705-3c42-214f-5cdc8b125c63@linux.ibm.com>
From:   Pierre Morel <pmorel@linux.ibm.com>
In-Reply-To: <74a234eb-0705-3c42-214f-5cdc8b125c63@linux.ibm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 6/24/22 07:47, Janosch Frank wrote:
> On 6/20/22 14:54, Pierre Morel wrote:
>> We can check if SIIF is enabled by testing the sclp_info struct
>> instead of testing the sie control block eca variable.
>> sclp.has_ssif is the only requirement to set ECA_SII anyway
>> so we can go straight to the source for that.
> 
> 
> The subject and commit description don't fit together.
> You're doing two things in this patch and only describe one of them.
> 
> I'd suggest something like this:
> 
> KVM: s390: Cleanup ipte lock access and SIIF facility checks
> 
> We can check if SIIF is enabled by testing the sclp_info struct instead 
> of testing the sie control block eca variable as that facility is always 
> enabled if available.
> 
> Also let's cleanup all the ipte related struct member accesses which 
> currently happen by referencing the KVM struct via the VCPU struct. 
> Making the KVM struct the parameter to the ipte_* functions removes one 
> level of indirection which makes the code more readable.
> 

OK done.


> 
> Other than that I'm happy with this patch.


Thanks,

Pierre


-- 
Pierre Morel
IBM Lab Boeblingen