Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp3008109iog; Mon, 27 Jun 2022 07:22:39 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vBaTYVDWNJRFYrsfUINWFmzCjwY1wXTgH0mqS5f0yJGWW1AF1sKbiE9KSr10NalVT3ZC+X X-Received: by 2002:a17:906:7742:b0:708:ad9f:8e88 with SMTP id o2-20020a170906774200b00708ad9f8e88mr12929660ejn.735.1656339759434; Mon, 27 Jun 2022 07:22:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656339759; cv=none; d=google.com; s=arc-20160816; b=i7PMDZgeGS4PZV6UczqP2LlhCMphZPjvWd/fKWFumpTUc/PqXcNDUSHhjf8D8Z5s8A A/IYccV0HsY3evXrPyB38U98FxAbDP9BzHkF1PijjAImEgLRKrFrWVNooMKgNXXe6gK0 Hz4aCssgzbMrgU3qIeJnjeEt8HKq/OutRG0oUZHYzWsXNh4Ct9QFYyVQ5Km9zUbJSgGD f8/UTTiy0cMZ3bVICwVUy2e6inch1GtpKf/9BTnLWI+qkFS6ceF4z+GkmayuQNL2/dvj GWN2s/iCPbwQ75YHDCM10Z7cVjlgypUkdh/SX7C/WPUruHF3TLbXzx0plFHJKGQ61/bz V7cA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=kX6TxBhPYP7/zzOagr1iopz1md+3ufdCaT6isU511rc=; b=sAbN0UX9LFH+AsBIwZqDDQoS15Y84/Vt5HCVrXvQXdnZSyR3iJ+1mrLRTKTjvye62U IrlUiwIFhexkKwCsZuLb3Y9OUdnC0BY7++a77ILWYCIasBI13/oEBC1CYSg/Nb8wDb3s aRZB2lWxv4Xy3QsQWdcfhQJokQ69Tpcap3x3Tyf/u4UVpfvYDAXZXD1w5QKUaYnj0VNM /YXBu3aqVlutiEE4lQ/avFOBjsyJxWChPYoeyT7ovH5+QQkJVWOvYblzNiU5RrxQLaf+ lwI1vsfTDv7b2KepvY1f2STAafTalZxQJS7W7P9ZxRKepuWJ1DLKAPLifn+byketomIj GhQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@kapsi.fi header.s=20161220 header.b=rQSsuZ0u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nd8-20020a170907628800b007262b057924si13765628ejc.900.2022.06.27.07.22.14; Mon, 27 Jun 2022 07:22:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@kapsi.fi header.s=20161220 header.b=rQSsuZ0u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237128AbiF0OU5 (ORCPT + 99 others); Mon, 27 Jun 2022 10:20:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236980AbiF0OUm (ORCPT ); Mon, 27 Jun 2022 10:20:42 -0400 Received: from mail.kapsi.fi (mail.kapsi.fi [IPv6:2001:67c:1be8::25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FD97FD0A; Mon, 27 Jun 2022 07:20:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kapsi.fi; s=20161220; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=kX6TxBhPYP7/zzOagr1iopz1md+3ufdCaT6isU511rc=; b=rQSsuZ0ukcjbxSYIvYrEODLIIK zTn7kRwdehCHH/WKw75C+cye8yo1UvUcFbqND2lk6SrNi0BxUjcKFMAoplNVrEggfFA58Cr5m6NWu 2PXltBaL9mVs7cWNEWf2BUarPQmD9T7yqBDkAOvn/HZlVU6m4mI1tUcj+LVjcAiAyZDwb1+CEB8uA VrQRb7SPiFisN+pPRHIbeeQm4XjMeFA5UwO6kDeyKMKbyccppZURc93S7mOqj7eUhr4xco8rFjlGy 4m/Gpajf1+vT2cE7QN/h8HG6JrjJBndrtrkKjgYpnwt1I+RBgISescQG6UB58koy18TNNRzR14jV9 XnMOSFIQ==; Received: from 91-158-25-70.elisa-laajakaista.fi ([91.158.25.70] helo=toshino.localdomain) by mail.kapsi.fi with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1o5pbL-003N2J-Sy; Mon, 27 Jun 2022 17:20:30 +0300 From: Mikko Perttunen To: Rob Herring , Krzysztof Kozlowski , Thierry Reding , Jonathan Hunter , Dmitry Osipenko Cc: Mikko Perttunen , Robin Murphy , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v7/v3 06/22] drm/tegra: nvdec: Fix TRANSCFG register offset Date: Mon, 27 Jun 2022 17:19:52 +0300 Message-Id: <20220627142008.2072474-7-cyndis@kapsi.fi> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220627142008.2072474-1-cyndis@kapsi.fi> References: <20220627142008.2072474-1-cyndis@kapsi.fi> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 91.158.25.70 X-SA-Exim-Mail-From: cyndis@kapsi.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mikko Perttunen NVDEC's TRANSCFG register is at a different offset than VIC. This becomes a problem now when context isolation is enabled and the reset value of the register is no longer sufficient. Signed-off-by: Mikko Perttunen --- v6: * New patch --- drivers/gpu/drm/tegra/nvdec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tegra/nvdec.c b/drivers/gpu/drm/tegra/nvdec.c index 79e1e88203cf..386f9b2e78c4 100644 --- a/drivers/gpu/drm/tegra/nvdec.c +++ b/drivers/gpu/drm/tegra/nvdec.c @@ -21,6 +21,8 @@ #include "falcon.h" #include "vic.h" +#define NVDEC_TFBIF_TRANSCFG 0x2c44 + struct nvdec_config { const char *firmware; unsigned int version; @@ -63,7 +65,7 @@ static int nvdec_boot(struct nvdec *nvdec) u32 value; value = TRANSCFG_ATT(1, TRANSCFG_SID_FALCON) | TRANSCFG_ATT(0, TRANSCFG_SID_HW); - nvdec_writel(nvdec, value, VIC_TFBIF_TRANSCFG); + nvdec_writel(nvdec, value, NVDEC_TFBIF_TRANSCFG); if (spec->num_ids > 0) { value = spec->ids[0] & 0xffff; -- 2.36.1