Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <e640e330-5318-e60e-d3e3-16d9bd7b289a@roeck-us.net>
Date:   Mon, 27 Jun 2022 07:13:37 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH] watchdog: sp805_wdt: add arm cmsdk apb wdt support
Content-Language: en-US
To:     Bing Fan <hptsfb@gmail.com>, wim@linux-watchdog.org
Cc:     linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1656037482-19505-1-git-send-email-hptsfb@gmail.com>
From:   Guenter Roeck <linux@roeck-us.net>
In-Reply-To: <1656037482-19505-1-git-send-email-hptsfb@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/23/22 19:24, Bing Fan wrote:
> From: Bing Fan <tombinfan@tencent.com>
> 
> Support arm CMSDK ip apb watchdog device.
> Description details of this device can be found in the
> document DDI0479D_m_class_processor_system_r1p1_trm.pdf
> on the arm's document web. Which periphid is 0x001bb824.
> The registers are basically the same as the 805, just a
> few more: Periphid4/5/6/7 with offset 0xFD0/0xFD4/0xFD8/0xFDC.
> For the register description of arm,sp805, please refer
> to the document DDI0270-arm-sp805.pdf.
> 
> Signed-off-by: Bing Fan <tombinfan@tencent.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   drivers/watchdog/sp805_wdt.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/watchdog/sp805_wdt.c b/drivers/watchdog/sp805_wdt.c
> index f9479a3fe2a6..78ba36689eec 100644
> --- a/drivers/watchdog/sp805_wdt.c
> +++ b/drivers/watchdog/sp805_wdt.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0+
>   /*
>    * drivers/char/watchdog/sp805-wdt.c
>    *
> @@ -341,6 +342,10 @@ static const struct amba_id sp805_wdt_ids[] = {
>   		.id	= 0x00141805,
>   		.mask	= 0x00ffffff,
>   	},
> +	{
> +		.id     = 0x001bb824,
> +		.mask   = 0x00ffffff,
> +	},
>   	{ 0, 0 },
>   };
>