Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp3214095iog; Mon, 27 Jun 2022 11:35:36 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vU1mPNDKadJ+Y5Q+qJte+CClEtI1rFxvti1VuwzTVdngTizBAoEqwXHKD/TqGs9mURVZKd X-Received: by 2002:a17:90b:1b0d:b0:1ec:9f74:30ab with SMTP id nu13-20020a17090b1b0d00b001ec9f7430abmr17268380pjb.58.1656354936411; Mon, 27 Jun 2022 11:35:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656354936; cv=none; d=google.com; s=arc-20160816; b=D1LShpIgQ7J+BcNftbmSdPdZzej37MEoqOtUJcQqOOQqSu2lDK02MYU7cbQB+1l0im m7bv4wnmF/OYx0Tt6GL4MXCw+sX60yNQ78w30qImkYoi4A1VmQBM8RYpEMQdckHAi0P9 LN8cyJm6iJtJ00iolDjYRp2EfPSrVejpn9n9kjESJc0609m/kTtSJVX8CUix7jS8Hu62 ZThJTpOKpyow6/gorsCKZ7M9Evtx/uH+RuntTSh2JAmFHxsyOaS38kkC/Ame32c03P9D ZLFRwzXAvKpnGNVPpa3pseuuZvl3uFeIzBhI0W8gLxpkkL1M2mWL8cvOLl7uyLIGCt4w HlNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=FW3bKANshCTMYUfWSsXBAPlzgVtCXzCw0VyzRToRMks=; b=W1LpLxPbd0UxmmcXobavNNWQw/yj7DRJev9C4cG5jr2GNlgiMZUJt+bFFs8fXPAU5t 7iCk8BPuDkvlgyLAMK2Vsfuj0d+l4E+yVmlXFAgcuiZ9lnvRARlxcV6AcBaQBz0FDQEQ YSMTr151EuEXjqdMV/5G1LOP/z27Jt03P/Vhhjso3/pdRPt/da8WkcSJw50w/bxOT44x PBtyYWGUTO1/gBi8CiWQeRkuzW78jcnYynjodrMaVwefZeS8v+hCydwQVNkyOljYu9+t YD/TfY6b0d+zQGcbPdXiSmkblRbrsEa1/v83xZlELWzWLPSO7SN9VPfHJB3Xh/AgbzGh 5YLg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=FeAwLx+r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t20-20020a170902dcd400b0016a214e46c8si12805568pll.187.2022.06.27.11.35.24; Mon, 27 Jun 2022 11:35:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=FeAwLx+r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240164AbiF0STe (ORCPT + 99 others); Mon, 27 Jun 2022 14:19:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234890AbiF0STc (ORCPT ); Mon, 27 Jun 2022 14:19:32 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2E3EE008; Mon, 27 Jun 2022 11:19:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7F468B81A2E; Mon, 27 Jun 2022 18:19:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98E2BC3411D; Mon, 27 Jun 2022 18:19:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1656353969; bh=TWYurZfD/jUE/28ERIZq8LqjtfVRpiQiuznUyRsMsO8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FeAwLx+rI+mBj0NI0QoHuA4Rvcx16ZYK+rUfbIaWckGhHUG3auHvoG7DiEo27CxjZ Or0f6z+BNgZY2MAa270mBYYezoq1NWsREaFd+XKeSK7xj8hfT8F1fpz3SFBnoMTSxl /E1FBs2J9PvQ62Si3qjuZde6FIQGne1a+3Bh+mks= Date: Mon, 27 Jun 2022 11:19:27 -0700 From: Andrew Morton To: "Fabio M. De Francesco" Cc: David Sterba , Chris Mason , Josef Bacik , Nick Terrell , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, Ira Weiny , Matthew Wilcox , Kees Cook , Sebastian Andrzej Siewior , "James E . J . Bottomley" , Helge Deller , John David Anglin , linux-parisc@vger.kernel.org, David Sterba Subject: Re: [RESEND PATCH v4 1/2] highmem: Make __kunmap_{local,atomic}() take "const void *" Message-Id: <20220627111927.3ef94745aab4491901d43028@linux-foundation.org> In-Reply-To: <2192593.iZASKD2KPV@opensuse> References: <20220616210037.7060-1-fmdefrancesco@gmail.com> <20220616210037.7060-2-fmdefrancesco@gmail.com> <2192593.iZASKD2KPV@opensuse> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 27 Jun 2022 19:02:31 +0200 "Fabio M. De Francesco" wrote: > > v1->v2: Change the commit message to clearly explain why these functions > > should require pointers to const void. The fundamental argument > > behind the commit message changes is semantic correctness. > > Obviously, there are no changes to the code. > > Many thanks to David Sterba and Ira Weiny for suggestions and > > reviews. > > > > arch/parisc/include/asm/cacheflush.h | 6 +++--- > > arch/parisc/kernel/cache.c | 2 +- > > include/linux/highmem-internal.h | 10 +++++----- > > mm/highmem.c | 2 +- > > 4 files changed, 10 insertions(+), 10 deletions(-) > > @Andrew: > > Ira Weiny asked David Sterba for taking this patch through his tree because > it is a pre-requisite for a patch to fs/btrfs. He agreed with the above- > mentioned suggestion, however I suppose that an ACK by you is needed. > > Can you please take a look at this patch and say what you think about it? Looks OK to me. It's one of those "if it compiles, it's good" things. I don't believe the patch has ever appeared on linux-mm? Please send it there for some review then go ahead and merge it up.