Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d9df53b3-97ea-d394-fb04-ce2c95d76d82@intel.com>
Date:   Mon, 27 Jun 2022 11:51:33 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v8 0/5] Add TDX Guest Attestation support
Content-Language: en-US
To:     Sathyanarayanan Kuppuswamy 
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org
Cc:     "H . Peter Anvin" <hpa@zytor.com>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Tony Luck <tony.luck@intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Kai Huang <kai.huang@intel.com>,
        Wander Lairson Costa <wander@redhat.com>,
        Isaku Yamahata <isaku.yamahata@gmail.com>,
        marcelo.cerri@canonical.com, tim.gardner@canonical.com,
        khalid.elmously@canonical.com, philip.cox@canonical.com,
        linux-kernel@vger.kernel.org
References: <20220609025220.2615197-1-sathyanarayanan.kuppuswamy@linux.intel.com>
 <9abde78c-d2c5-c762-24fe-f26669b7cc6c@intel.com>
 <2502d21b-8f27-ebe5-b677-4cc56b03ee2c@linux.intel.com>
From:   Dave Hansen <dave.hansen@intel.com>
In-Reply-To: <2502d21b-8f27-ebe5-b677-4cc56b03ee2c@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 6/27/22 07:51, Sathyanarayanan Kuppuswamy wrote:
> In TDX guest, attestation process generally involves the following steps:
> 
> 1. Get the TDREPORT using user specified REPORTDATA. This is implemented
>    using TDG.MR.TDREPORT Module call. An IOCTL interface is added to let
>    userspace get the TDREPORT data  (implemented in patch #1).
>    
> 2. Using the TDREPORT data, generate a remotely verifiable signed Quote.
>    Quote can be generated either using GetQuote hypercall or by communicating
>    with VMM/Quoting Enclave(QE) using VSOCK. In this patch set, only the
>    GetQuote hypercall model is supported. Since Quote generation is an
>    asynchronous request, and takes more time, we let VMM notify the TDX Guest
>    using the callback interrupt. Patch # 2-5 implements Quote generation support,
>    in which Patch # 2 implements the callback interrupt support.

IMNHO, too much gibberish, not enough English, too much superfluous
information.

For instance, why do we need a quote and a report?  Why does this have
an interrupt?