Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp3274105iog; Mon, 27 Jun 2022 12:42:47 -0700 (PDT) X-Google-Smtp-Source: AGRyM1s4RkRyyNRWvjRbH/ZkDTbp1ClYZ9v3DTm6xjYZ+GOfgesXEpJ/tSLKKxFm0y5bdi/1oKXi X-Received: by 2002:a17:906:794f:b0:722:e857:1a8f with SMTP id l15-20020a170906794f00b00722e8571a8fmr14195835ejo.494.1656358967484; Mon, 27 Jun 2022 12:42:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656358967; cv=none; d=google.com; s=arc-20160816; b=kMmGSURGkYzej3gyeAemHym08s6DGjjOZeCVi8tSeiNn5SoO0seYIqdY/NutqxIoaQ 3FKxvO5XYAcBD56QED6iHOoqbuTUNkT3A/wSx63Gd6+kPIZTyOB/p67zjE+/vGoJPDza kuaOSsl7VvYQaz2xFiz/8ryTPzbc3SOojskPmVYS1QuBk8IGQe9SmVsX/tXEbQYGwexm 3Q0O38FXXYK9wOiG+lpQcnlk4ja2OIys8pnqSsr2qToc9EMiAKc1InKk/KvDj9uAyppU 31ZZ9fO8y9mOrG5SY0Zu62JlCXDzNeijCic8xJ8Hnkz2ga3PqtPycymHQb7AGW/aO+l2 iJAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=PZ6plud3Rf5fEMbZRuJvL10vqzgxzYsgamogPc/ulSs=; b=CpjqpYnD9BLTCkVE2Wi86b/XW4JF9LRJaUjwYCnWnw2KE0NMVFjxu81ZRNp6oy7Own 3x/Db6l9RTeFJraJXCg3Vcm0JEoMhoB/+1Ha+vMsUeloFhjMP1bpucXMKbnQGImbsx9+ v+EiQuQhTSW0gSZdjEZ6ME2NnXi+c/dKT31iMlOTz/hqZLKcjZ4oi7ZDm+c8Gds4RcGt Zs3QWJESgJfWl8ZC3gjVvscOH5Wj6BKPPDw/D09aLAph0CFCuvYg3HlybsFCBKHmFDrP WTLeBiGJlXUeSWjmY1mVwh3ZHqzteMqipN4t5x5wQx4coDD+FlKD0Nh1yUEM/tUOxLK6 7/Lw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=zi+neXZS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gm1-20020a1709073d0100b0072693a80bf2si8729624ejc.105.2022.06.27.12.42.21; Mon, 27 Jun 2022 12:42:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=zi+neXZS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240385AbiF0Tfn (ORCPT + 99 others); Mon, 27 Jun 2022 15:35:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236184AbiF0Tfm (ORCPT ); Mon, 27 Jun 2022 15:35:42 -0400 Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5766A62EC; Mon, 27 Jun 2022 12:35:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1656358541; x=1687894541; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=PZ6plud3Rf5fEMbZRuJvL10vqzgxzYsgamogPc/ulSs=; b=zi+neXZS5Tfo8fYmWYaZOlttgNGauVp6rk2ICfxqGMGlQse7BKBO7maI eN5wZGHT8LvaOr6ITx1HFWxxGYmFMckpxD0oewFFbcRNNQfEBHQ2M5Lua GqUZfBFVk/15lH2LNTw1JuzUqSUBPQVIqubt+ixvOSNDPq/3LahM1Xvqf 0=; Received: from unknown (HELO ironmsg05-sd.qualcomm.com) ([10.53.140.145]) by alexa-out-sd-01.qualcomm.com with ESMTP; 27 Jun 2022 12:35:41 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg05-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2022 12:35:40 -0700 Received: from nalasex01c.na.qualcomm.com (10.47.97.35) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Mon, 27 Jun 2022 12:35:40 -0700 Received: from [10.216.11.205] (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Mon, 27 Jun 2022 12:35:35 -0700 Message-ID: <1a58e260-773e-754c-6f85-b4b2cbd19d2a@quicinc.com> Date: Tue, 28 Jun 2022 01:05:31 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH V2 5/8] pinctrl: qcom: Add IPQ5018 pinctrl driver Content-Language: en-US To: Bjorn Andersson CC: , , , , , , , , , , , , , , References: <20220621161126.15883-1-quic_srichara@quicinc.com> <20220621161126.15883-6-quic_srichara@quicinc.com> From: Sricharan Ramabadhran In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01c.na.qualcomm.com (10.47.97.35) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks Bjorn for your review On 6/24/2022 9:24 AM, Bjorn Andersson wrote: > On Tue 21 Jun 11:11 CDT 2022, Sricharan R wrote: > [..] >> + >> +static const struct of_device_id ipq5018_pinctrl_of_match[] = { >> + { .compatible = "qcom,ipq5018-pinctrl", }, > Please make this qcom,ipq5018-tlmm, as requested in the binding.  Sure will do. > > With that: > > Reviewed-by: Bjorn Andersson   Thanks for that. Regards,   Sricharan