Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <02bba339-bf85-f178-c1b6-13d553c4a48c@amd.com>
Date:   Mon, 27 Jun 2022 13:57:38 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH v5] x86/mce: Check for writes ignored in MCA_STATUS
 register
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
Cc:     x86@kernel.org, linux-edac@vger.kernel.org,
        linux-kernel@vger.kernel.org, Tony Luck <tony.luck@intel.com>,
        "H . Peter Anvin" <hpa@zytor.com>,
        Yazen Ghannam <yazen.ghannam@amd.com>
References: <20220610192515.98540-1-Smita.KoralahalliChannabasappa@amd.com>
 <YrNRYJx0CNDNj3oX@zn.tnic> <d3f554b8-4fc5-efe8-1ca2-aa95c7e76eb8@amd.com>
 <YrcJKOUSJsmodo70@zn.tnic>
From:   Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
In-Reply-To: <YrcJKOUSJsmodo70@zn.tnic>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SW1LZlJBMG5sckRLemMxVFpCNGwzd0REUlM4VzRKVHJxRVFqSDJUR2dBQ0JT?=
 =?utf-8?B?TXAvbVNkTU1IZXNLM0diaGNzK0MyaG00N005bTJUb2pMQW1QY0cvUXVZUElx?=
 =?utf-8?B?cDIyUGJMZHBPY3dNS1V6MVZJZTlVeTZsT2NyR0YyK2VtUkJtOTZyOVFxZlVW?=
 =?utf-8?B?aXdLd2hZNmswUzFDWm1XYTlXbEE5blV5UHJGNTFRLytnVHFmNlhkMG50MjJr?=
 =?utf-8?B?aXp3Z2lFakgzak0ySEV1T1pTZXpuWTdWL3h6Z0xmYk15bzVKZ1NOYjU1Q2xk?=
 =?utf-8?B?VUg4QlplcG4zVStEeFY1TEJtaGxWZ1lCK3JpYnRrZGZvdWFENU1MN1VMbUVD?=
 =?utf-8?B?S2RaQldKeXo2bkpaTVhtOTRDaDFGUTFIcFZYblJxeUF0VS9ucE9sUllUSWZp?=
 =?utf-8?B?UEZiMnM5emRtd1Z5OEVlWkRlZXFyWmpna0NoOGZPT1pIWXFDc1dsdEV4bjZ5?=
 =?utf-8?B?L1BodWdCU254bTZnZFMvbjk1N0ZGaitwL1JMR3RZbWxrODJkeHFDcjBJZktx?=
 =?utf-8?B?dW8yNXRkWXU4U0l4T1AvTDE2VzRiNlQ1b0JYRmsrZXlRcVJ1VVptWG0zeXJE?=
 =?utf-8?B?TUJkZjVXNElCUGJsSWRkcVhMS01jdWVOTjBIWUx3R1BKVmdLTitJcHRsRHBa?=
 =?utf-8?B?c2E0cXE4SFNKSC9kUEdzMExyMHU3VnpRT2ZueWMvUVNCdldsQ2lPRUZPa25x?=
 =?utf-8?B?OHdHMVVCY3RIenVJWkpvRFczNTNTZ3hFRDBkazM1S0QzZmVaNjBURDFkeWhl?=
 =?utf-8?B?akZoRjEwVEwxdGtmNHh6c0hyOHN4YlhnNmVJbVYwMVByVkNERlpvL1hIb2d0?=
 =?utf-8?B?WGMxN3owSVNzeWpRZnduSzc0d0ZNUmo2QmU1dE80RnRFbDRVcm03U1dySWRw?=
 =?utf-8?B?aWlSbFVqTksrVWJBeVFRQkY5d3FNVFRCYk5sWHFITFlzR0xMMys5elZULy82?=
 =?utf-8?B?M2krTFFHdmp0ZzZRZ1crYW03M0NBUUVCTVFkcTc2eHJ2Mm45T2FHd3JTak1y?=
 =?utf-8?B?SSt0MUtPSDlVYU5kdzVaa0dob1hOUXo1aXJQTmZETERtdSt3ZkYzOUZGR3lr?=
 =?utf-8?B?b2RSUVdybmRnUHdmS3pHZ1VEYnEzWmJkcmlRMXZMR3FYSmVLcjd5N1hkRWZV?=
 =?utf-8?B?YnRYMm1KNU5BemFMYVY1SjdpanFVRFlVQmIrZi9YTE9ESzg0M3c2dFBXTGVs?=
 =?utf-8?B?aloxMVpjSTA5UkYwZDBNRkczb3ZVL1NKV1RrN1ZvSW5uajk3ZlZxL1NPQjh6?=
 =?utf-8?B?cUptazNuZXI2eWpySmZoVFoxcW9LdjVud2hxMWxLZFcvT1luQnd4Q0Z0NCt0?=
 =?utf-8?B?M0FFcmlOUTRZZ2xyTkU0U2RrWWpYbWUyWE9GKzg1eFJvTlUxR3NKRThBYnBl?=
 =?utf-8?B?TjhrQTErN2k0OHFYdWlMTG93T2daWHMxc3hGTE5JQXQ5cDVwN2dhRVMrYTFh?=
 =?utf-8?B?Tnc3aE9HTDFMWUVSWUpoSGpXODJ0OW81YlNyd1lrS25GK1hPYUFOaHlaTTRL?=
 =?utf-8?B?cnFYRGtMakR6dVF6ZFpHakIwRDRLZGF4UzIwRE83bnBGaGhndGdWUDJ0YWhn?=
 =?utf-8?B?aTJYTzhlckVaR1dWZGIxemppSWR6UStKMTNCMmhJQ3gwdUlSTUhIOWk3bkc4?=
 =?utf-8?B?R3NrWGNGTk02bGFVV0ZVS201VmM1d3lEbG1UR0NneXlNR2dIQ0h4cUFTQzJn?=
 =?utf-8?B?Vmdud1JudFUwQkVVclJJVWk2ZExpMkFZMmpuMnlUMzNHTEcydmhaRHdsQ1Va?=
 =?utf-8?B?RGNxNFIveGRuL0xQdm1kZjMrZm5ucktJWDhvWDJiMGdKMTRXMlBlWVFsS0Rx?=
 =?utf-8?B?aUZRdi9JREdxazlVMUlNR3gwWXA4cjBxejVmWHhkWmJCdUQ0RXEwbXZnbjN3?=
 =?utf-8?B?WHMzbzlpN3RkRHFZTWRLakNacCtZYWV3cGZkc1hEQXhkdDBUUjVza2wxVkVE?=
 =?utf-8?B?SzZKdVhPaTgxcDZSVU9GYkFmKzFweG5LcEF2UE9ZV3VRZG1HZUQ3SFVWZEE2?=
 =?utf-8?B?dE1iMDVoeWl6UFhZSUsyeXNTVGx5WVdtblNaLzh2ZXRUbmtkNklUSnU3VHdV?=
 =?utf-8?B?TkcxcmJ6ZUtUK1BuKzVhWWRERUluMEtXdGtxRnBoWTBUV1pOKzk4UFdWT0tn?=
 =?utf-8?Q?It87s8NlTUXDXlrbUOKZ7TA0h?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e46b2eb1-3953-4606-9f82-08da587fadf5
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jun 2022 20:57:43.1180
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UjPhNY4U44+NUmYHWvo0XSERpuBgOcRdotfnNF3N8pP/hMOjarEKONvGO2NBJJCDtKyT5CN0ypEGkz8NQwDx/g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1201MB0084
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 6/25/2022 6:10 AM, Borislav Petkov wrote:
> On Fri, Jun 24, 2022 at 03:34:42PM -0700, Smita Koralahalli wrote:
>> The wrmsrl_safe() doesn't throw an error here.
>> I think we need to read back the written value and check for it whatsoever.
>> What do you think?
> Ah, that's the write-ignored thing. Not the #GP-generating thing when
> McStatusWrEn=0.
>
> Sorry, I got confused.
>
> Can you pls change that part back to reading the previously written
> value and send me a tested version?
>
> Thx.
Thanks, I have sent them.
>