Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 27 Jun 2022 13:51:53 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     James Houghton <jthoughton@google.com>
Cc:     Muchun Song <songmuchun@bytedance.com>,
        Peter Xu <peterx@redhat.com>,
        David Hildenbrand <david@redhat.com>,
        David Rientjes <rientjes@google.com>,
        Axel Rasmussen <axelrasmussen@google.com>,
        Mina Almasry <almasrymina@google.com>,
        Jue Wang <juew@google.com>,
        Manish Mishra <manish.mishra@nutanix.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 04/26] hugetlb: make huge_pte_lockptr take an
 explicit shift argument.
Message-ID: <YroYaWVvNZJvtqsH@monkey>
References: <20220624173656.2033256-1-jthoughton@google.com>
 <20220624173656.2033256-5-jthoughton@google.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220624173656.2033256-5-jthoughton@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?GVrW/n0puFuFUiygcJVdUMgeHU2UjW2kpXoohA5wYBoU3T6TGj2RHvJPtatX?=
 =?us-ascii?Q?WmN4ydDCo6uksyqU060jl+5j7PbcGsI04RB2jRvKbRwun/9eD5EwMWt2zaJ0?=
 =?us-ascii?Q?M4C3KHp5McqoCE+R76LXF8O/sQU9Uqu9SK5JV4RG1pI5Vic80kF8EB2GT1CJ?=
 =?us-ascii?Q?6MHuwqJ7hI87qa87uTg+FPl2Ioz72sM4Gy9Dtd4X9frCUJ6S6lQOcl3bgWsB?=
 =?us-ascii?Q?wx1y/y9AY7+s85Gr76fsaJXkhpzCuJeKBqGK7GTcUc9Y3ltXr2VieXukUJ5S?=
 =?us-ascii?Q?7h1abSDK9+FQUBZPzdjoUPd+t3EhBGzyGE3GeLmAFt0tFpilVhJPXfMnAT7w?=
 =?us-ascii?Q?0dI+Tafj2IubGHJuCmvrJWoyQhYbN2j9EtiRZijEgtzkct6/WCaEUmPjPotB?=
 =?us-ascii?Q?pLtSPFUQh63QlKGw7JDqAic92yfldFD+IJ2UVDTJCSUSD4vFK7gReeM7xKrb?=
 =?us-ascii?Q?GBi4TrickHkh4u3BuQNN6AAsOH8NWeUsj7QLCmCRjK9B5Mtzkihw67S0yuHU?=
 =?us-ascii?Q?y7PDTjImoyE0dlZu6MBC+9zc901ACreciJ1bE5Hazv05vM+yIYP26JaJ1For?=
 =?us-ascii?Q?koBng8OkD+9i6BCJX53VkSpPhauPCBSUVca9RGRhajyETTXgZeZ7bM+ltHAg?=
 =?us-ascii?Q?B0V39V8oHUW0fV3Q8rFeJP6fd3XLCECen50uqDlegcRQ5Bc6kGUNv1BoiDYH?=
 =?us-ascii?Q?PXlFFgG3GuLTa/EYlWB/GhhgY7Xm4vhnlgl5uetE3nYcQoq1FpOBe4WaH53o?=
 =?us-ascii?Q?wiCCNsZv6xrOw7XRSe12WAJXHy/e95vfyNfNuFcSG5lWK3+1f1/WLX8KlYhS?=
 =?us-ascii?Q?YhlfA+9adykOM21gW0DfCg3tHoy7Ch40G4QgK5+qjpCHiNXJ4V5I4kN7HiUy?=
 =?us-ascii?Q?dXZQeTuFaT4ftqkOI9TB1Oup9H54MvatJwIaQMQjPrw38tQWhNa2/N31VPdm?=
 =?us-ascii?Q?4FuN5prNQghe2xwtVl+jljpHThVd/XpRxfq+CIjxbrj4Ym8Z2+W0rpmkZV0f?=
 =?us-ascii?Q?c0coTwJ6n1WKIIsZrSkIy/7WkHXLKAvef5JXW1hnLWSGxSFAMkp0PMcS9y2P?=
 =?us-ascii?Q?gmyQ62WagvGb7lIQxIc+MWU9ylgweY7zxvHbNwjclfe3VH0nWDUqREuJangC?=
 =?us-ascii?Q?zp0odsnsv59XFXVnCSrujuqkjH5FBCa7juaht1KdA04cQPwc3Y7PuGR8rJ5H?=
 =?us-ascii?Q?2Bu6t3fqyheFhnvxgELR/sH2CEGy610dy14Gmj1kGodK5nAGs6wM76+n4VoY?=
 =?us-ascii?Q?kXBbmz7IsL/0S+kt7MA2O6x42zekC6/FRDhXqvw6e+qIoCry45Kgx7nHnvNP?=
 =?us-ascii?Q?2xwCgKiXCIkvPHHwStC+apPcrldVHDgT/cWiZsISiI+DwDPRsVpblPebxMz2?=
 =?us-ascii?Q?WeezZ10IAiAr152TBuoG8zvbubI47vijiv7umRlh2ZfCk13ETSozcGgP0brE?=
 =?us-ascii?Q?N60t76ykXsn5CVxrMF4bs2uK3SfYM6hgr7P1zUFeyHTbuBY6ppxbsEsT1MOm?=
 =?us-ascii?Q?7THDMDHP9aSXXEJ4h5JFLlOuv8u8DTe645AAxzFqlYvBjFU7xnnY1s2GkYaf?=
 =?us-ascii?Q?MOKuVQuvPp34ddtnfV2dgQENBJGrd8oOM8uczbQmJ0tPvvbDIetUFrtc9AYc?=
 =?us-ascii?Q?IA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4a3f6de7-9a8a-4fc2-785d-08da587edf90
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jun 2022 20:51:56.7350
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: n6nUGplN9HF9ToAdytGjp/8R48fro8+myZ3fAJNzXFDJcxPCVneymMXOD1Zh6g5foKxAKVBWWyut4/D25Y40pw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR10MB1386
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-06-27_06:2022-06-24,2022-06-27 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0 bulkscore=0
 phishscore=0 mlxlogscore=539 adultscore=0 mlxscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000
 definitions=main-2206270085
X-Proofpoint-ORIG-GUID: pgAzCPE3nc05LZT6N4jGI2qILS15rrkE
X-Proofpoint-GUID: pgAzCPE3nc05LZT6N4jGI2qILS15rrkE
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/24/22 17:36, James Houghton wrote:
> This is needed to handle PTL locking with high-granularity mapping. We
> won't always be using the PMD-level PTL even if we're using the 2M
> hugepage hstate. It's possible that we're dealing with 4K PTEs, in which
> case, we need to lock the PTL for the 4K PTE.

I'm not really sure why this would be required.
Why not use the PMD level lock for 4K PTEs?  Seems that would scale better
with less contention than using the more coarse mm lock.  

-- 
Mike Kravetz