Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220625014157.5004-1-jrdr.linux@gmail.com>
In-Reply-To: <20220625014157.5004-1-jrdr.linux@gmail.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Mon, 27 Jun 2022 17:39:02 -0400
Message-ID: <CADnq5_McHFHKiXWMpMEo0QtKW_HMe5dkp9-Q-3LFs1AjDQ0Kzg@mail.gmail.com>
Subject: Re: [PATCH] drm/amd/display: Removed unused variable ret
To:     Souptick Joarder <jrdr.linux@gmail.com>
Cc:     "Wentland, Harry" <harry.wentland@amd.com>,
        "Leo (Sunpeng) Li" <sunpeng.li@amd.com>,
        "Siqueira, Rodrigo" <Rodrigo.Siqueira@amd.com>,
        "Deucher, Alexander" <alexander.deucher@amd.com>,
        Christian Koenig <christian.koenig@amd.com>,
        xinhui pan <Xinhui.Pan@amd.com>,
        Dave Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Wenjing Liu <wenjing.liu@amd.com>, Jun Lei <Jun.Lei@amd.com>,
        Jimmy Kizito <Jimmy.Kizito@amd.com>,
        Jerry Zuo <Jerry.Zuo@amd.com>,
        Meenakshikumar Somasundaram <meenakshikumar.somasundaram@amd.com>,
        "Leo (Hanghong) Ma" <hanghong.ma@amd.com>,
        kernel test robot <lkp@intel.com>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Applied.  Thanks!

Alex

On Fri, Jun 24, 2022 at 9:42 PM Souptick Joarder <jrdr.linux@gmail.com> wrote:
>
> From: "Souptick Joarder (HPE)" <jrdr.linux@gmail.com>
>
> Kernel test robot throws below warning ->
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c:
> In function 'dc_link_reduce_mst_payload':
>    drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c:3782:32:
> warning: variable 'ret' set but not used [-Wunused-but-set-variable]
>     3782 |         enum act_return_status ret;
>
> Removed the unused ret variable.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Souptick Joarder (HPE) <jrdr.linux@gmail.com>
> ---
>  drivers/gpu/drm/amd/display/dc/core/dc_link.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> index 55a8f58ee239..445357623d8b 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> @@ -3706,7 +3706,6 @@ enum dc_status dc_link_reduce_mst_payload(struct pipe_ctx *pipe_ctx, uint32_t bw
>         struct fixed31_32 pbn_per_slot;
>         struct dp_mst_stream_allocation_table proposed_table = {0};
>         uint8_t i;
> -       enum act_return_status ret;
>         const struct link_hwss *link_hwss = get_link_hwss(link, &pipe_ctx->link_res);
>         DC_LOGGER_INIT(link->ctx->logger);
>
> @@ -3777,7 +3776,7 @@ enum dc_status dc_link_reduce_mst_payload(struct pipe_ctx *pipe_ctx, uint32_t bw
>                         &link->mst_stream_alloc_table);
>
>         /* poll for immediate branch device ACT handled */
> -       ret = dm_helpers_dp_mst_poll_for_allocation_change_trigger(
> +       dm_helpers_dp_mst_poll_for_allocation_change_trigger(
>                         stream->ctx,
>                         stream);
>
> --
> 2.25.1
>