Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: YfruM3WpxOaIniRtNESqOpGbs5nm3tjmRNkK2Vn5AuQLereOM7xdRo0gykKLmM4axoaaV8l9dN
 LkCqDvUNTn646aLtaOuWGr16vXkrT/+jMaj6oKWCgD/5rukFjWy9WSD+AblEGvs72iPMcxwTKp
 2NEMr38cbYKEo76KNYsqxoZx6VH5btft2oWmy1il+dyjm6SJnwmvYI8Q9gtba6KG/Z1m4MH9wG
 rvNMprKs0bJ7x1mEeTiSnZRvKxOWiPEXKc+hdzYQE3IgtlYwZuwX3D9sm5ONHhJzAnZ4RBkBrP
 a1RclBCUBoE1CPkJq2n87F2G
IronPort-SDR: VTnkQYTygL7EDjTA1sJqf7Hac+Y34iZSTRzTi/JS/1oeRBm8sGkoMMHpyPkR2Iv/QvFiEJUPSU
 7sfaMXxJ/G0b6ZDUIgSSszm6//9dbndVTIoq1jPto2b8vQ3GBnL/mOv1DSY2L5w06LsXfOj/GN
 NphxVGGub6T/Ft5qAEPem/IDOIIFJ2aGiHTugJOKoUjhI2YVBUEj170YD5HDakttRzQdzQFd9e
 EdNa8Sz46qwDy++scIIz5KQ0y258QpiBrxUSn7Pq5YC/gp8d+5YzNb1gxsjG7NJUS81tOoNfUH
 rrU=
WDCIronportException: Internal
Message-ID: <b69c6112-98b7-3890-9d11-bb321a7c877a@opensource.wdc.com>
Date:   Tue, 28 Jun 2022 08:24:08 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH v4 5/5] libata-scsi: Cap ata_device->max_sectors according
 to shost->max_sectors
Content-Language: en-US
To:     John Garry <john.garry@huawei.com>, joro@8bytes.org,
        will@kernel.org, jejb@linux.ibm.com, martin.petersen@oracle.com,
        hch@lst.de, m.szyprowski@samsung.com, robin.murphy@arm.com
Cc:     linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-ide@vger.kernel.org, iommu@lists.linux-foundation.org,
        iommu@lists.linux.dev, linux-scsi@vger.kernel.org,
        linuxarm@huawei.com
References: <1656343521-62897-1-git-send-email-john.garry@huawei.com>
 <1656343521-62897-6-git-send-email-john.garry@huawei.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <1656343521-62897-6-git-send-email-john.garry@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/28/22 00:25, John Garry wrote:
> ATA devices (struct ata_device) have a max_sectors field which is
> configured internally in libata. This is then used to (re)configure the
> associated sdev request queue max_sectors value from how it is earlier set
> in __scsi_init_queue(). In __scsi_init_queue() the max_sectors value is set
> according to shost limits, which includes host DMA mapping limits.
> 
> Cap the ata_device max_sectors according to shost->max_sectors to respect
> this shost limit.
> 
> Signed-off-by: John Garry <john.garry@huawei.com>
> Acked-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

Nit: please change the patch title to "ata: libata-scsi: Cap ..."

> ---
>  drivers/ata/libata-scsi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
> index 86dbb1cdfabd..24a43d540d9f 100644
> --- a/drivers/ata/libata-scsi.c
> +++ b/drivers/ata/libata-scsi.c
> @@ -1060,6 +1060,7 @@ int ata_scsi_dev_config(struct scsi_device *sdev, struct ata_device *dev)
>  		dev->flags |= ATA_DFLAG_NO_UNLOAD;
>  
>  	/* configure max sectors */
> +	dev->max_sectors = min(dev->max_sectors, sdev->host->max_sectors);
>  	blk_queue_max_hw_sectors(q, dev->max_sectors);
>  
>  	if (dev->class == ATA_DEV_ATAPI) {


-- 
Damien Le Moal
Western Digital Research