Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <606f7526-23b8-a114-020f-b5fcdeecf90b@intel.com>
Date:   Mon, 27 Jun 2022 17:03:58 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v5 08/22] x86/virt/tdx: Shut down TDX module in case of
 error
Content-Language: en-US
To:     Kai Huang <kai.huang@intel.com>, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org
Cc:     seanjc@google.com, pbonzini@redhat.com, len.brown@intel.com,
        tony.luck@intel.com, rafael.j.wysocki@intel.com,
        reinette.chatre@intel.com, dan.j.williams@intel.com,
        peterz@infradead.org, ak@linux.intel.com,
        kirill.shutemov@linux.intel.com,
        sathyanarayanan.kuppuswamy@linux.intel.com,
        isaku.yamahata@intel.com
References: <cover.1655894131.git.kai.huang@intel.com>
 <89fffc70cdbb74c80bb324364b712ec41e5f8b91.1655894131.git.kai.huang@intel.com>
 <765a20f1-681d-33c2-68e9-24cc249fe6f9@intel.com>
 <cc90e5f8be0c6f48a144240d4569b15bd4b75dd8.camel@intel.com>
 <77c90075-79d4-7cc7-f266-1b67e586513b@intel.com>
 <2b94afd608303f104376e6a775b211714e34bc7e.camel@intel.com>
 <6ed2746d-f44c-4511-7373-5706dd7c3f0f@intel.com>
 <a3831d3fc926905585f9fb1e14e13e502c1f5b65.camel@intel.com>
From:   Dave Hansen <dave.hansen@intel.com>
In-Reply-To: <a3831d3fc926905585f9fb1e14e13e502c1f5b65.camel@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/27/22 16:59, Kai Huang wrote:
> If so,  in the assembly, I think we can just XOR TDX_SW_ERROR to the %rax and
> return %rax:
> 
> 2:
>         /*
> 	 * SEAMCALL caused #GP or #UD.  By reaching here %eax contains
> 	 * the trap number.  Convert trap number to TDX error code by setting
> 	 * TDX_SW_ERROR to the high 32-bits of %rax.
> 	 */
> 	xorq	$TDX_SW_ERROR, %rax
> 
> How does this look?

I guess it doesn't matter if you know the things being masked together
are padded correctly, but I probably would have done a straight OR, not XOR.

Otherwise, I think that looks OK.  Simplifies the assembly for sure.