Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Zhang, Qiang1" <qiang1.zhang@intel.com>
To:     "paulmck@kernel.org" <paulmck@kernel.org>
CC:     "frederic@kernel.org" <frederic@kernel.org>,
        "joel@joelfernandes.org" <joel@joelfernandes.org>,
        "quic_neeraju@quicinc.com" <quic_neeraju@quicinc.com>,
        "rcu@vger.kernel.org" <rcu@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] rcu: Add a warnings in sync_sched_exp_online_cleanup()
Thread-Topic: [PATCH] rcu: Add a warnings in sync_sched_exp_online_cleanup()
Thread-Index: AQHYhQ20/x4TmjWtSEepVJie126Nl61cGSeggAezNQCAADNyMA==
Date:   Tue, 28 Jun 2022 00:31:12 +0000
Message-ID: <PH0PR11MB5880B496CB57A804B95977A9DAB89@PH0PR11MB5880.namprd11.prod.outlook.com>
References: <20220621012412.2724457-1-qiang1.zhang@intel.com>
 <PH0PR11MB588005D38E08891423310EBBDAB29@PH0PR11MB5880.namprd11.prod.outlook.com>
 <20220627211658.GN1790663@paulmck-ThinkPad-P17-Gen-1>
In-Reply-To: <20220627211658.GN1790663@paulmck-ThinkPad-P17-Gen-1>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 11.6.500.17
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dPUksDYLZarJHpdjHz3B0isG8dzUKFTeYlw4E0aknaD3bqsJtaZbexjsoNLY?=
 =?us-ascii?Q?hIozNjdFp/LkOI0kQ0QMA6wIWMzlq9ueRK9PLGGQHYVoGJbL198I7lHiz5d0?=
 =?us-ascii?Q?tKt2o461+tr7vWOSQfk9V7Y3206TUGy8gNwZOFy2Azvc8JEslOoTeKxZCbq6?=
 =?us-ascii?Q?nV0KL/fqiTxswundW6EvWXi5eEaq0+BKB/eoNhV9uxKpCMh71ZGO17af7zo4?=
 =?us-ascii?Q?K3eKRLs88OTxDqRHFeDvzax9f+WtiFimD2lq1c2/r18YVi0qwaZl7pz8q8oM?=
 =?us-ascii?Q?KmhidJlT7PN86gJOnhBMPV+0H6tj17ZpXmHpPMdllzNnr8HgM2IqYlxmDkX+?=
 =?us-ascii?Q?V1aZ0Hc02noyLsDQoTUaN5NjKIFw6UhuNysBa7iZZ+PVYt8EiZOq+Yqd8Ltw?=
 =?us-ascii?Q?s42UOat4ZyL6Qhi3p1o4111AHpBqDXBkbWcYyB+iMRF+YIr0doxdnwahFaPl?=
 =?us-ascii?Q?KyJkhqS9YURnZx4icnB4Y8dQdXBxTaQSyRRHPBvI+nmRFQYpgkxh9vjsHNoX?=
 =?us-ascii?Q?tPQHGwHoQpihsfisMaIcqrADCjm/h4TvpY+g7UmKCCVl7B8rVjS+LopPmz/L?=
 =?us-ascii?Q?04+Z4kPvRq7GuDXai6/ELTyc6wqnBEup/EDvYPXIPQjd/i1WJSObKkqmxtgF?=
 =?us-ascii?Q?JjG8MUDyg2zPtADE9jTKWQSO8oL0LaJ0IiLtJW+GwbY+4Sov3jj8evIOFKH2?=
 =?us-ascii?Q?xRG1VCeCSual8J5/rXazXwtK08GzWwTfDifFoMCHJrDuGaMMUxQu5CQJjP6h?=
 =?us-ascii?Q?3V+pdiidisDgMxi7AzVqLbeW5is6couIRcE9wwzBdheWjTKB1w40VGsLTjgx?=
 =?us-ascii?Q?BTl5v2X5xOgzkeeIdKoxkHUEKA69lrfDlHxY++g2GcmoMmws0Vroo3NkME5m?=
 =?us-ascii?Q?70V1s/q9xY9Ta3kKVoIAfWpB6nqlE0L1yXdm+nNL6r7oFvRUZIN9Kwsdqj5H?=
 =?us-ascii?Q?XJhFzYSdbwtuSCGGvTL2QLdKobbclMK5AAKhX75+QIYYn2reR/Xhw3UEtQBg?=
 =?us-ascii?Q?wIp1WjimQRqAq/RPncIzIwLf6HwvsYinp7iVnNRL5dCo88HFIO5+H/Ob+A+1?=
 =?us-ascii?Q?G6oHjqe61CiPfmmULCzr/cn1FZozEmcXNDwvhTZy6ixpz+4/71yJjJ5UXGbR?=
 =?us-ascii?Q?qOmXwUH5YX4RJL1eFYb08C0FXo+sRM/7UXchXy/FxVDpZMnVD7Z29bzIxW+R?=
 =?us-ascii?Q?bkkehuwdS+dzLKB0waMog+iYKV2T4xj+GaodQ6zWpd20au2YYE0fhcF5OfJ3?=
 =?us-ascii?Q?pirRdAmKwbeXjMibl9wGjgd3hUnEMEatXIrfcyaNhQumvkbxv8tUIDkDJyDi?=
 =?us-ascii?Q?WaM8zkq0E4TyrhWuPHnFCtjROJjXuSjpBAkF4kN3ODFPn6JfZLLsDtFxQar7?=
 =?us-ascii?Q?5c0983El4hVsOFA/79eP19KaeH5+1u+XtSL9IobTX/bWA/T5rbiWAwNE2ob+?=
 =?us-ascii?Q?l8zBgBPIT96qBb4H14xi6J/h983fcv3yxcgmR1GZM4X6juvkpRl5sf3PA0FY?=
 =?us-ascii?Q?4wQmigwhlzSJjYtqmL+/rouFukumwabKTY/nbh039z42mwVSpLJnkuQ/PyYa?=
 =?us-ascii?Q?8XDbO3MUowjb4dLT6jrkXGkNQXhL/mcUZKCGCCtP?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5880.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 43a715ae-3a59-41b5-0365-08da589d80fd
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2022 00:31:12.3208
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wa3Qoe3nKWXHY6whV4Fsh6rFbx+TgTwIO/hPHsBP+Rao/55QeWAXYTm8w1akQf028qf8ucnmiARbp20vSU34vw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB6004
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>=20
> Add Cc=20
>=20
> Currently, the sync_sched_exp_online_cleanup() is invoked in
> cpuhp per-cpu kthreads when CPU is going online, so the CPU id
> obtained by get_cpu() should always be equal to the CPU id of
> the passed parameter, that is to say, the smp_call_function_single()
> never be invoked, if be invoked, there may be problem with cpu-hotplug,
> this commit add WARN_ON_ONCE() to remind everyone.
>=20
> Signed-off-by: Zqiang <qiang1.zhang@intel.com>
> ---
>  kernel/rcu/tree_exp.h | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/kernel/rcu/tree_exp.h b/kernel/rcu/tree_exp.h
> index be667583a554..ae8dcfd4486c 100644
> --- a/kernel/rcu/tree_exp.h
> +++ b/kernel/rcu/tree_exp.h
> @@ -865,6 +865,8 @@ static void sync_sched_exp_online_cleanup(int cpu)
>  		put_cpu();
>  		return;
>  	}
> +
> +	WARN_ON_ONCE(my_cpu !=3D cpu);

>If we are going to add this sort of warning, why not instead add it
>to rcutree_online_cpu()?
>
>The reason the warning has not been present is the prospect of concurrent
>onlining at boot time, which might have rcutree_online_cpu() invoked
>from CPU 0 for multiple CPUs at boot.  However, the for_each_online_cpu()
>loop has recently been removed from rcu_init().

The rcutree_online_cpu() is always invoked in per-cpu cpuhp kthreads,=20
and even if it is called directly through the for_each_online_cpu() loop in
rcu_init(), since the rcu_init() takes precedence over smp initialization,
only the CPU0 is online at this time, still only called on CPU0.

Thanks
Zqiang

>
>But I would like to hear what others think.  Would such a warning
>significantly help debugging?
>
>							Thanx, Paul
>
>  	/* Quiescent state needed on some other CPU, send IPI. */
>  	ret =3D smp_call_function_single(cpu, rcu_exp_handler, NULL, 0);
>  	put_cpu();
> --=20
> 2.25.1
>=20