Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Neal Liu <neal_liu@aspeedtech.com>
To:     Alan Stern <stern@rowland.harvard.edu>
CC:     Felipe Balbi <balbi@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Roger Quadros <roger.quadros@nokia.com>,
        Miaohe Lin <linmiaohe@huawei.com>,
        Wesley Cheng <quic_wcheng@quicinc.com>,
        "Eric W . Biederman" <ebiederm@xmission.com>,
        Matthew Wilcox <willy@infradead.org>,
        Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
        Cai Huoqing <cai.huoqing@linux.dev>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        BMC-SW <BMC-SW@aspeedtech.com>
Subject: RE: [PATCH v2] usb: gadget: f_mass_storage: Make CD-ROM emulation
 works with Windows OS
Thread-Topic: [PATCH v2] usb: gadget: f_mass_storage: Make CD-ROM emulation
 works with Windows OS
Thread-Index: AQHYh3DSTidIVUKmfU2+k/4XOqVQ6a1engoAgAPzy4CAAMrSAIAAuStw
Date:   Tue, 28 Jun 2022 01:57:49 +0000
Message-ID: <HK0PR06MB3202C5E9147EA7E7B91C6B0380B89@HK0PR06MB3202.apcprd06.prod.outlook.com>
References: <20220624021916.318067-1-neal_liu@aspeedtech.com>
 <YrXJss4cTtfenu90@rowland.harvard.edu>
 <HK0PR06MB320272ACB1CA4ADFF8DDABC080B99@HK0PR06MB3202.apcprd06.prod.outlook.com>
 <YrnEli0fdOERpIXe@rowland.harvard.edu>
In-Reply-To: <YrnEli0fdOERpIXe@rowland.harvard.edu>
Accept-Language: en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2nEKWb96WrA6Pf9wXrgFmTcfjr7b8bqCf4ymQlemxY9HA1Nzt0iqMYcmQcfN?=
 =?us-ascii?Q?16QJ+w7FMZtfHuYt7EcxmorqIWQRKQlDkRCwRHw/ExjXcSDyXwvObZEC2wWs?=
 =?us-ascii?Q?kpCT24C3pozF8mKq3EbFJ9/0IFHHll/0XTBppFh0dIvhX/LiiyURHnyxP2Lo?=
 =?us-ascii?Q?AYwgC3pqkMaek+eVBEmUMX1BvxrrPVgMQr31FxYqIVjER93cQZRxmLOp9/ez?=
 =?us-ascii?Q?um0iArB1KtOSTbd1ry9PuKEt/rTFfK1BVxJ4LmaPE/7qP1rIC52TrYcRE7AH?=
 =?us-ascii?Q?7Q9e67+xyRE8PyspU1KW0BI6PgJOUOVIvOhg/VnR5iUqBxB8nr4tdjyNlrxH?=
 =?us-ascii?Q?shXefgwuNYaG5sJGpwMeyYUQWAy0iMUheZBNNZL6t2muI6Mjs4BLIHFD7HuC?=
 =?us-ascii?Q?0FfzYWs9PjqBGNX+JSF9dHm1BYgblHxMyTFa7/ebbNbgrlh/Vp3KQ7Nq/nSm?=
 =?us-ascii?Q?Sfmc8apazN5A/g1/663ZxSblp8ZF+F0RdlYpq3W1JxSWF5ZHdnYa9mXqrtg9?=
 =?us-ascii?Q?Xoh4+iU7S9JX1R4JxyXw+iPVZ9IwJ30yDtmgf0jE9y/f3ttG1QWByBcdVu3h?=
 =?us-ascii?Q?VYUFUKWnPnt1Zy4RPH48xocQ84fkbOfG0Meqej2U2y2RXFmxSycnQtI1dOrG?=
 =?us-ascii?Q?k+YiIyjiqqUp4oJFMUU657KFUygrD91usKzXRVscPnPTPtDbcNorJPB04sp1?=
 =?us-ascii?Q?/AFccZkFxyHeBE3G9ZczAGZdstid/Kox78lPdtipEXPSuxPpqNiVZbL30ISU?=
 =?us-ascii?Q?MSfPV+fu8UkatzMuT2pc3gxIqyqGhu+P1eOEwQWxyVnTkwgWLrvC3dzF412Y?=
 =?us-ascii?Q?GXfYZ3vMS8TA3LCjsCOw9frCQlWb3uxzKbqO7i9B/zmM/Eok6p5QaPdG+r43?=
 =?us-ascii?Q?ufc0h1FR7hQ5qaYk4ki+YNon+EbES2AEK0uJP1TR7t1L0z+6QS0Xo7zHa1I5?=
 =?us-ascii?Q?1AbTv8LQMqaz1/hOEpMMp71Q/s7ze/ND65UCBijz/Vb35UIKMDP44UE3qIgp?=
 =?us-ascii?Q?QV4+oQjjr2gUz4Cd52dofXmQjiu8q+bRrb4dTGaGA3wQxdS31KlckIxgZGAP?=
 =?us-ascii?Q?2xad8RdzWPDWJlokY/vxSlWXsnm1YqTNEJQQxoHG4mKVuA0EzDg/JcutM6Vd?=
 =?us-ascii?Q?mjynLdVGVEipZeLwo7GcwEPxY3dElR7OMaidreVkT1QMapi+AhlEr10m09C3?=
 =?us-ascii?Q?LggXPUQDiXddAp8Osu2T7jO+4HOhz6V9sPftswfh8zzWmLPsq0ndQZe6eJWh?=
 =?us-ascii?Q?GkeTibhe3ZtPL84KN/UWO5bDSwRlLTsIq8DWK1GqjWl26XPLKV4rK2gIXst3?=
 =?us-ascii?Q?LA0Q43A8OZJLY+/LyXq+PhL5G52Cfs3fR5nghWnYHgrkoR0K+nyAuhMl9Q//?=
 =?us-ascii?Q?AaWG1fzLhik3owXGfQRUJpumCu5oSrJNigne2ilsaAk9hbPJhnSTmF1x79Oi?=
 =?us-ascii?Q?Ozkk0BCJ5wjzkkYhk5lANLfFBMjr51Dt993PTLFi9gfB2wFWVt+5brsh2TTy?=
 =?us-ascii?Q?ZDz+Kabmtf2UVELfPt+p9aUeNY7bWTo/wJLgqvFIWp9fAc9b5CzOf2Upzf2D?=
 =?us-ascii?Q?QDF8/G2eZ4k00/I8aby0vkHRPUF49DE6avhu19Vm?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: aspeedtech.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: HK0PR06MB3202.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e1a5d998-80f5-40be-69c8-08da58a99b0c
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2022 01:57:49.9877
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: LgFhCMPXLwTndTelfgRINi3jy9MkOFsayL2F942FMKkT7PBXmz9UdcVren/Zdz+WoU62AmESc/mPWL0vgIEpIw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB3468
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_INVALID,
        DKIM_SIGNED,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> On Mon, Jun 27, 2022 at 02:56:40AM +0000, Neal Liu wrote:
> > > On Fri, Jun 24, 2022 at 10:19:16AM +0800, Neal Liu wrote:
> > > > Add read TOC with format 1 to support CD-ROM emulation with
> > > > Windows OS.
> > > > This patch is tested on Windows OS Server 2019.
> > > >
> > > > Signed-off-by: Neal Liu <neal_liu@aspeedtech.com>
> > > > ---
> > > >  drivers/usb/gadget/function/f_mass_storage.c | 5 +++--
> > > >  1 file changed, 3 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/drivers/usb/gadget/function/f_mass_storage.c
> > > > b/drivers/usb/gadget/function/f_mass_storage.c
> > > > index 3a77bca0ebe1..9edf76c22605 100644
> > > > --- a/drivers/usb/gadget/function/f_mass_storage.c
> > > > +++ b/drivers/usb/gadget/function/f_mass_storage.c
> > > > @@ -1209,7 +1209,8 @@ static int do_read_toc(struct fsg_common
> > > > *common, struct fsg_buffhd *bh)
> > > >
> > > >  	switch (format) {
> > > >  	case 0:
> > > > -		/* Formatted TOC */
> > > > +	case 1:
> > > > +		/* Formatted TOC, Session info */
> > >
> > > This comment is a little misleading.  0 is formatted TOC, and 1 is
> > > multi-session info.  The way you wrote it, it looks like the comment
> > > applies to both formats.  Do it like this:
> > >
> > > 	case 0:		/* Formatted TOC */
> > > 	case 1:		/* Multi-session info */
> > >
> >
> > Okay, looks more clear. I'll fix it in next patch.
> >
> > > >  		len =3D 4 + 2*8;		/* 4 byte header + 2 descriptors */
> > > >  		memset(buf, 0, len);
> > > >  		buf[1] =3D len - 2;	/* TOC Length excludes length field */
> > >
> > > It looks like you ignored one of the problems I pointed out in my ear=
lier
> email:
> > >
> > > > When format is 1, the driver is supposed to ignore the start_track
> > > > value.  Your patch does not do this.
> > >
> > > Please fix this.
> > >
> >
> > Do you mean ignore the "start_track > 1" above?
>=20
> Yes, that's what I mean.
>=20
> > Do this check only for format 0? Or format 0 & 2?
>=20
> According to the MMC spec, the Track/Session Number is ignored for format=
 1.
> For format 0 it is valid as a Track Number, and for format 2 it is valid =
as a
> Session Number.  Therefore it should be checked for formats 0 and 2 but n=
ot
> for format 1.
>=20
> Alan Stern

Got it. I'll fix this in next patch, thanks for pointing out.