Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Zhang, Qiang1" <qiang1.zhang@intel.com>
To:     "Zhang, Qiang1" <qiang1.zhang@intel.com>,
        "paulmck@kernel.org" <paulmck@kernel.org>
CC:     "frederic@kernel.org" <frederic@kernel.org>,
        "joel@joelfernandes.org" <joel@joelfernandes.org>,
        "quic_neeraju@quicinc.com" <quic_neeraju@quicinc.com>,
        "rcu@vger.kernel.org" <rcu@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] rcu: Add a warnings in sync_sched_exp_online_cleanup()
Thread-Topic: [PATCH] rcu: Add a warnings in sync_sched_exp_online_cleanup()
Thread-Index: AQHYhQ20/x4TmjWtSEepVJie126Nl61cGSeggAezNQCAADNyMIAABWIAgAAApwCAABMMIA==
Date:   Tue, 28 Jun 2022 01:52:49 +0000
Message-ID: <PH0PR11MB5880EBF5E1DD2C08FA3D2600DAB89@PH0PR11MB5880.namprd11.prod.outlook.com>
References: <20220621012412.2724457-1-qiang1.zhang@intel.com>
 <PH0PR11MB588005D38E08891423310EBBDAB29@PH0PR11MB5880.namprd11.prod.outlook.com>
 <20220627211658.GN1790663@paulmck-ThinkPad-P17-Gen-1>
 <PH0PR11MB5880B496CB57A804B95977A9DAB89@PH0PR11MB5880.namprd11.prod.outlook.com>
 <20220628004022.GU1790663@paulmck-ThinkPad-P17-Gen-1>
 <PH0PR11MB5880C30FB7101CE64485EAF9DAB89@PH0PR11MB5880.namprd11.prod.outlook.com>
In-Reply-To: <PH0PR11MB5880C30FB7101CE64485EAF9DAB89@PH0PR11MB5880.namprd11.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 11.6.500.17
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/JRzcY3ZSbirAlgAH+4c9/eBGdBqE4T133x3BD3NiR+XQYbSOf+kvtpJ7mqh?=
 =?us-ascii?Q?NShbv2vXP6DmKPZu1Px4BJjwjm1LvEc8g7zZRvbdJxsyJPKggRWnMc2zGa1D?=
 =?us-ascii?Q?l/8OAO7JvMYO2AYxgdnLh+dmMEAP5573K5X3j4qCQeCXyjEFdQhNo4FZQq00?=
 =?us-ascii?Q?prd9UcKTky0wrt1CHKe7TnoemCt/tQRBT8s0v/EEFJNzxV8EJ1pmrgbCJ2ks?=
 =?us-ascii?Q?XVTAQWjFubXEB2AJ28/64KO197SZzlOkVCGBtmB4RczljfC4H07q68DSLwcL?=
 =?us-ascii?Q?7VsoJTBgOHfq838B4Qu2XBKvfGU2dceKES/5pp4CHzU8iVu2zwuyokQk9tWv?=
 =?us-ascii?Q?j48E1w1RGacbCwNWHt13xU3ARCmaas082XSvsKLGvdMaxk4cLGrinDmxHUoK?=
 =?us-ascii?Q?XupgrsItqhVKtTmIPqnQaaqZl4ihWMc3CMxpdsH0FUkteiDGqPPndKcGc4my?=
 =?us-ascii?Q?3F2OEPPmRN0BX8V6rEssHsMMMEiJnWCYNNupMwg2I6Z9mAhbDHvjueo1Piv5?=
 =?us-ascii?Q?OgVcrH5GGKss5MQrpkmhy39Js+g7fvd/u3tWm6Xe/+epJPaiWdz5Vh6zYpSV?=
 =?us-ascii?Q?bFspBdv2WO/Kq0kMjFYWevcr2Cq3rZcdOv2dyTywkczCu7DhsYZLTbv4VZ5S?=
 =?us-ascii?Q?eTpU2zDmOGpjKVcJpDqY9GsoCPnTPr+x6WnBMXF2iCS7RBPuZhKR0ryzi56n?=
 =?us-ascii?Q?dDpMchGJ2rC5AiTzycSzSznpgTr+hpBwhWk9Pyc7MUwT7/V0HXGVi00zOMst?=
 =?us-ascii?Q?hglsdqoQdUF0DIVfAviUuVAYxhjJKnnI1r+rhMetPB9ONc2HLxDTkAlA2GI9?=
 =?us-ascii?Q?bxI0C3YKmRVMnqS3kFKdpbxiPJY+DmWEp5NnDBgmCfszohozXT33NA1e1Ky0?=
 =?us-ascii?Q?ksySjhmvouqTWudm076Kt/K5QjwedU4tuzK66wSRGdaAIvoh44y/k7XK/b6s?=
 =?us-ascii?Q?1c5XNyWmHRYRS2mBWyRriPjnaiPAxWH5EMx2wnCJGY2xP14jENbIinRf0Z2N?=
 =?us-ascii?Q?J2wkXJ4dJqi9qHT1aCj0RcWn9z/9bQYYbjkq6PKYRxMTOIVnWmgYovqLci19?=
 =?us-ascii?Q?1llHt5QCsFRbXEgIc6lYhSMrIllcaD1aY26aeZnVSHU+qx7rzMsbnvW+ZlY5?=
 =?us-ascii?Q?h5CTigSmgcYSWRa+pqBFTQv1qjWJysztC59Jk0fqKzyqdXQmlRjB0A/h1EQG?=
 =?us-ascii?Q?kHPhrR3A/MExzULM2sFygOcqumo6NeLJC9IjoqHM+4hdPdauWy5s/Osg9iEa?=
 =?us-ascii?Q?8NKvA+iRQKygodZnQr7O5e6NM4t3DnhK7t0OSbMZkaeg/hfRZ2xihzpEewBG?=
 =?us-ascii?Q?uuhkdrKE31aXlq6iPMuN42SeEm4o7ElrcPgtm0mjrTbq4UIn8x+EOfzz81tv?=
 =?us-ascii?Q?Qx/GQxzK4tOOtlP4B9CZOMzXA0CRlm0oCrmB8qNbbPfHlXCuQscxNVfyr10Z?=
 =?us-ascii?Q?kVz/1lb0OVwjs/jd9gukevzr+uqpKCpDwjwpEaaTppqE0BUILECnxrtvC6/I?=
 =?us-ascii?Q?3y2ZOfydWjU43NakKwu7iMlQKLxjJakoY/2PIXWbIViO1I2Koh+TrcU/HaF7?=
 =?us-ascii?Q?qS0luAqUMT3N2nnXSlGHpJOKBqkiiTYBoWrbhV3i?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5880.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4db4a7e8-2a42-459f-89b6-08da58a8e819
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2022 01:52:49.7772
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: zXrC4nZKInzhapN1Lxhf5juE6X4NROaM797H2S8/0KPfmiUYQs6Df6sLwJamdatbidk2ZJwUgZM8fCQ5anfy4g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3458
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 28, 2022 at 12:31:12AM +0000, Zhang, Qiang1 wrote:
> >=20
> > Add Cc=20
> >=20
> > Currently, the sync_sched_exp_online_cleanup() is invoked in
> > cpuhp per-cpu kthreads when CPU is going online, so the CPU id
> > obtained by get_cpu() should always be equal to the CPU id of
> > the passed parameter, that is to say, the smp_call_function_single()
> > never be invoked, if be invoked, there may be problem with cpu-hotplug,
> > this commit add WARN_ON_ONCE() to remind everyone.
> >=20
> > Signed-off-by: Zqiang <qiang1.zhang@intel.com>
> > ---
> >  kernel/rcu/tree_exp.h | 2 ++
> >  1 file changed, 2 insertions(+)
> >=20
> > diff --git a/kernel/rcu/tree_exp.h b/kernel/rcu/tree_exp.h
> > index be667583a554..ae8dcfd4486c 100644
> > --- a/kernel/rcu/tree_exp.h
> > +++ b/kernel/rcu/tree_exp.h
> > @@ -865,6 +865,8 @@ static void sync_sched_exp_online_cleanup(int cpu)
> >  		put_cpu();
> >  		return;
> >  	}
> > +
> > +	WARN_ON_ONCE(my_cpu !=3D cpu);
>=20
> >If we are going to add this sort of warning, why not instead add it
> >to rcutree_online_cpu()?
> >
> >The reason the warning has not been present is the prospect of concurren=
t
> >onlining at boot time, which might have rcutree_online_cpu() invoked
> >from CPU 0 for multiple CPUs at boot.  However, the for_each_online_cpu(=
)
> >loop has recently been removed from rcu_init().
>=20
> The rcutree_online_cpu() is always invoked in per-cpu cpuhp kthreads,=20
> and even if it is called directly through the for_each_online_cpu() loop =
in
> rcu_init(), since the rcu_init() takes precedence over smp initialization=
,
> only the CPU0 is online at this time, still only called on CPU0.
>
>And sync_sched_exp_online_cleanup() is only ever invoked from
>rcutree_online_cpu(), correct?
>

Yes, currently the sync_sched_exp_online_cleanup() is only invoked from rcu=
tree_online_cpu ().
(Sorry, wrong wording in previous email.)

Thanks
Zqiang

>
>							Thanx, Paul

> Thanks
> Zqiang
>=20
> >
> >But I would like to hear what others think.  Would such a warning
> >significantly help debugging?
> >
> >							Thanx, Paul
> >
> >  	/* Quiescent state needed on some other CPU, send IPI. */
> >  	ret =3D smp_call_function_single(cpu, rcu_exp_handler, NULL, 0);
> >  	put_cpu();
> > --=20
> > 2.25.1
> >=20