Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp3556407iog; Mon, 27 Jun 2022 19:55:23 -0700 (PDT) X-Google-Smtp-Source: AGRyM1t2U79qDII70nhm/Hr41Qev1I6juqK3uM+afT4r2xIvrx5aBhA1pUT4TiV+t/mFnlclleOm X-Received: by 2002:aa7:c7cc:0:b0:435:81f5:2021 with SMTP id o12-20020aa7c7cc000000b0043581f52021mr20480192eds.62.1656384923602; Mon, 27 Jun 2022 19:55:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656384923; cv=none; d=google.com; s=arc-20160816; b=xDN5QlxcHt6aejhYOqTI2oYYLdxXgtPO6+9qIPRTUvZ+GLuennr4ZJgAZJGnoyd+x5 UudKSpXJZAW04L5CN8QBfxhn2zzJXhgTuLZDqwYlDrZyU2fl+pL7U0t6fFI1sB6G5U8d TM82JY/lUYAjKGAVn0aQVMNpWKwkz3NEOrtF9o6yGEASWSWYdfpe04GBHWmiuE6ztYHJ 1c+FtikEPSRWZLYSuGB0o4lVkCdGDAo5ZNS8eTjUWfE7rfLRQ7iZkW85c312BoZ2/hX2 fol5qALv84v4OmoIGCNrxJAD1k4qcUdvq+7dBPjwcGcBQjnpPT9EhhGm0kyNMjPMMBZH OOrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=jq6NgEVhoW+GH3P5Ph67yag/nQ0jqfosmK2J2YGjI4I=; b=Xd8FV2NyD55/7o4MuJ7c69PkX20RrVkvVVMVg2uayQ9p+WE5Dom9yANlTTiL1KUC0F cy8C6DekBoceUL9RckJuv4EXTaMFtrbzr1/cqglXPdFmfInVWWbP5tds/l2Od9r2Jr25 V5Km1/CijjwSHv5UXVoO5I9iy4UZJV5EXCmd+I4LN0CJ2nr64qPblFRraGgzsiDo+S75 j9HCCh/X+dMNDd/ki0iDDwkkE2AQP4iNqhJ69YTjrYLlBc9KPKo20p1vkdbvjHGhZAOK TZ3coCFNcP/A3zP5BhuW6MBeNzun1Nz1QqEHnEv0NSlwk/QfDdHU7+qdnLQlS2TdYLgS aC3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bBczAIs8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ga39-20020a1709070c2700b00726b4dfce1esi4367756ejc.167.2022.06.27.19.54.59; Mon, 27 Jun 2022 19:55:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bBczAIs8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244235AbiF1CYF (ORCPT + 99 others); Mon, 27 Jun 2022 22:24:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243955AbiF1CWf (ORCPT ); Mon, 27 Jun 2022 22:22:35 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 132C025285; Mon, 27 Jun 2022 19:22:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 430E2B81C12; Tue, 28 Jun 2022 02:22:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0556CC341CD; Tue, 28 Jun 2022 02:21:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656382921; bh=rOos/ArnyqrU9+/UDMZ/R2BUkprdvSdRzCRG/yD/lQ8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bBczAIs825MzX6CRYQGzoLE37ery5+KW1kpHUG2AvwvjsVa0jAjW0TGjMYExCzSfd 2d/iuwTnordUhtmK6SrgvB6/Jgj23EvvJTsfjtxWz/ASsX0DLNqh/O/Vg0PpIyqiyG ltbRdOL06T8QnbZXmvhV5nlOdPuZooi8bv/UBaoKObPXM0GZ2jMMHr40g2mv/nvEfa G6c1ErlVMeGGpXLxg2wB3KfE7fRSFwnzuF9t09CHuEgIJ1DNxLAhFCt8SWGhoPadsj P0hW8TrOgBQod6zb2XOo/sDK/sG58IfUuFsQd9lCsvG/yys1F9gG9tiDugIxudXAI2 +8OvTtxO3+kig== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Hyunwoo Kim , Helge Deller , Sasha Levin , yang.lee@linux.alibaba.com, yangyingliang@huawei.com, cai.huoqing@linux.dev, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 5.15 22/41] video: fbdev: pxa3xx-gcu: Fix integer overflow in pxa3xx_gcu_write Date: Mon, 27 Jun 2022 22:20:41 -0400 Message-Id: <20220628022100.595243-22-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220628022100.595243-1-sashal@kernel.org> References: <20220628022100.595243-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hyunwoo Kim [ Upstream commit a09d2d00af53b43c6f11e6ab3cb58443c2cac8a7 ] In pxa3xx_gcu_write, a count parameter of type size_t is passed to words of type int. Then, copy_from_user() may cause a heap overflow because it is used as the third argument of copy_from_user(). Signed-off-by: Hyunwoo Kim Signed-off-by: Helge Deller Signed-off-by: Sasha Levin --- drivers/video/fbdev/pxa3xx-gcu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/pxa3xx-gcu.c b/drivers/video/fbdev/pxa3xx-gcu.c index 9421d14d0eb0..9e9888e40c57 100644 --- a/drivers/video/fbdev/pxa3xx-gcu.c +++ b/drivers/video/fbdev/pxa3xx-gcu.c @@ -381,7 +381,7 @@ pxa3xx_gcu_write(struct file *file, const char *buff, struct pxa3xx_gcu_batch *buffer; struct pxa3xx_gcu_priv *priv = to_pxa3xx_gcu_priv(file); - int words = count / 4; + size_t words = count / 4; /* Does not need to be atomic. There's a lock in user space, * but anyhow, this is just for statistics. */ -- 2.35.1