Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp3558219iog; Mon, 27 Jun 2022 19:59:20 -0700 (PDT) X-Google-Smtp-Source: AGRyM1s34T8v9jBeNaaTB5MSS9mfiuMuDf00icf6gC4G+xDtnGN9fBhn3uCJXWNc3IL/ryY0MXKX X-Received: by 2002:a05:6402:2750:b0:435:ab9f:1235 with SMTP id z16-20020a056402275000b00435ab9f1235mr20829598edd.188.1656385160515; Mon, 27 Jun 2022 19:59:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656385160; cv=none; d=google.com; s=arc-20160816; b=dv7rS65vw48/NNAEVBHh3DRbrq2VXplYk765mcbPKpCH8pPPFnIm27bACd3p0Nr9Qf 0V+ySXZZ6cmj+4IPrZgdLYvm47qdG2JSo6yhQjy0JsdExJLlMfLSagiGlSCppMJhSfkt dHzWY0B6JPWPG0n9yIXwoaiCEq3+JRKmY9SPBwdVIoJYLXsOv/6ImHmI5gUnqI9L4YAC nMoqiiaodezLYdj+SRAGxq5fopZi45el2WoDUnzFHt5/CGP+aVI3cxvuqjb5g6QiNpVK W3JDV5mXhB3xyyvRk8ITxPWxeSJjVA+NjDDiFhywPuEBf7k+tSWzr3hojDiI7zZZqrQb Nyng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=phWC8VmrUq42z1vssr4HDRBdZb5Bs5PJMtwBq70d0VM=; b=igl2NO4FxpaIc/oQ3cTji7HvJiISfmR+5/q4IWkTS6MbcV5J9T+U8Ila1S3GeYVTyx MHudt7MD37N2gjHJHfxdhq7IX00jiBm94/PqJ6X2LEq5pwzDIc2XA+lL2a04vD97oJ+f wl4r6S5ephd67VweXcon+G0B0/ku389CatXGRgPnZKJjoA89Ysee8M+9B/sVTBSllosg WabKBHTqPKVzGFNXmYI0A3v75zdbQrUpOLrTdzHGWMnnZFbmqpKVzB9n8ang9S4G+X9v aOkQAkjdhe1r7k9uoqcUxVJ9O5pJK0QIALDwotrfe4sZNNRqf6YRGOYcAIlh2MXwqKOJ ThwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Sr+SxODc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c20-20020a05640227d400b00435c05a5304si17067803ede.11.2022.06.27.19.58.56; Mon, 27 Jun 2022 19:59:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Sr+SxODc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343815AbiF1Ct5 (ORCPT + 99 others); Mon, 27 Jun 2022 22:49:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343773AbiF1Ctn (ORCPT ); Mon, 27 Jun 2022 22:49:43 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4864EB99 for ; Mon, 27 Jun 2022 19:49:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id B62DECE1D9A for ; Tue, 28 Jun 2022 02:49:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C931FC341CE; Tue, 28 Jun 2022 02:49:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656384579; bh=zGk3NdtsCMsFxVCICZyhbXYWgZgrCoRU5D4V1L9Q1rw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Sr+SxODcFiYmahDdpnMlMDN+y60Li7+aDagwpBtY1Pxcu4sjDbwUcpwkAe6LSCSE/ z39uki/0RaDplB0pI2UY7/cs98kNYxfvmLwdj+qh66CZ7vxCNqf719GbjECTmT4WsX ZuUKuiV90GFkrd9GRpwwsEXncpK2Z0700JisuVPtcs+CupoP9W9M03bL6JzSObnjWH S0ZoqCDCCXvUN4W1O6iH7RUZAsLFnKpf+8luvYXDB3Pg2ogc5tVUmK8hCXTYImkAgn blrmI9nYoHynvtlqvI5h/IG9wEX2U4ijTybiOGMWYs0sWp7OPIk9flBSGu6BAXoCNt Myxazg/uzpiOw== From: Tzung-Bi Shih To: bleung@chromium.org, groeck@chromium.org Cc: chrome-platform@lists.linux.dev, tzungbi@kernel.org, linux-kernel@vger.kernel.org Subject: [RESEND PATCH 06/11] platform/chrome: cros_ec_proto: change Kunit expectation when timed out Date: Tue, 28 Jun 2022 02:49:08 +0000 Message-Id: <20220628024913.1755292-7-tzungbi@kernel.org> X-Mailer: git-send-email 2.37.0.rc0.161.g10f37bed90-goog In-Reply-To: <20220628024913.1755292-1-tzungbi@kernel.org> References: <20220628024913.1755292-1-tzungbi@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org While EC_COMMS_STATUS_PROCESSING flag is still on after it tries EC_COMMAND_RETRIES times for sending EC_CMD_GET_COMMS_STATUS, cros_ec_wait_until_complete() doesn't return an error code. Change the expectation to an error code. Signed-off-by: Tzung-Bi Shih --- drivers/platform/chrome/cros_ec_proto_test.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/platform/chrome/cros_ec_proto_test.c b/drivers/platform/chrome/cros_ec_proto_test.c index 64100fd81c6a..fbb872040711 100644 --- a/drivers/platform/chrome/cros_ec_proto_test.c +++ b/drivers/platform/chrome/cros_ec_proto_test.c @@ -1870,9 +1870,7 @@ static void cros_ec_proto_test_cmd_xfer_in_progress_retries_status_processing(st } ret = cros_ec_cmd_xfer(ec_dev, &msg); - KUNIT_EXPECT_EQ(test, ret, sizeof(struct ec_response_get_comms_status)); - - KUNIT_EXPECT_EQ(test, msg.result, EC_RES_SUCCESS); + KUNIT_EXPECT_EQ(test, ret, -EAGAIN); /* For EC_CMD_GET_COMMS_STATUS EC_COMMAND_RETRIES times. */ KUNIT_EXPECT_EQ(test, cros_kunit_ec_pkt_xfer_mock_called, 51); -- 2.37.0.rc0.161.g10f37bed90-goog