Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp3558325iog; Mon, 27 Jun 2022 19:59:34 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vtItjgi1pvSjuFzwfKDegI87uKznq2ghYyqEsnrTWLYQFLDB2BGSO7umn9mmot8BXFL7SG X-Received: by 2002:a17:906:7303:b0:722:f008:2970 with SMTP id di3-20020a170906730300b00722f0082970mr15298729ejc.491.1656385174041; Mon, 27 Jun 2022 19:59:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656385174; cv=none; d=google.com; s=arc-20160816; b=d4DPLmB/gTZPK0DIIno581EypVAtjW3VvodVJCQc5iiM9LxeMlscwM8yCpmV5FKOfF Eaj4sC2hJ/Qaq7s0qLQUj9NIXI7oJTwICMZ47Z1tLCU6YpNDwdFSkdw878XvfDlbHSVQ YOPR6nmPmYC8C7swXaWDaNv+6ZEY9hnwYefCSdDc5sYLfsgh1lbzW+7LKYSSY1De00pc Gc2yAfo5EhPTjUZ7OzMxDim4i9WCuetkMVHr0wOSMjVTOgtthNLfc9NPdgMk3xOJylDh 69jceYqWPO3nyO7Wqt62HsLmm2yO8FTJcKd0oj56fQjp+NZ14bqRK5PvKk5iCDwJ9rXW 39Jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=DncWTgSseOEfbSifWNJ1kXoNSzwgGhcU0Mej0twEaAo=; b=DWorUmZUX0E4TenCj6W9pDLRr5mcUi8dmt1lOkCgvDAxunyatCfuz2CNqHuE+rhjpF PLmORiri/7LaL5kQ7Y51J4uynqKesVy7SJfEhvivV36bl8TO+551ryJUv6WczLt8LdcV zsm708OZp4ILNgfdx9f8a3WFBzqU7aXKiBkvC1V5/1y7nsn8jogCnuz7Sb1X464lMOti b3yJssVQcP5TES9Pwj1MU81JDvZTjGa9ghU2DIyy8evlWFD3wj/Y5/TYooP3gxbIG2qH b15d/pJ3rAag0V94mpgtlARulEdYkFCFwypZrm/qMh6VN58jEiLg218LzJ5CrqMYKBF4 Gj+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kEkHb4EO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sb33-20020a1709076da100b00726bfffe257si3153815ejc.166.2022.06.27.19.59.09; Mon, 27 Jun 2022 19:59:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kEkHb4EO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343837AbiF1CuH (ORCPT + 99 others); Mon, 27 Jun 2022 22:50:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244548AbiF1Ctt (ORCPT ); Mon, 27 Jun 2022 22:49:49 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 671A710E7 for ; Mon, 27 Jun 2022 19:49:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 93DE561486 for ; Tue, 28 Jun 2022 02:49:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19158C34115; Tue, 28 Jun 2022 02:49:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656384586; bh=RCdzDyyspYZBbTy21S73pVMkpsXGg+X2fE0S4NTTvrE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kEkHb4EOokE+b0s6/tFxK/7Dy/zJ2l5+Y2TaH19ERYx3aocGIFDuMWGQhRX6QF43Q xo1WLZ6dytalM553zy0QzILZK2FTiWNG23Lp4/ozz3yh/tmL8IA+9gxiw5iKNltwwl FmlQXR02CE8tFJts0zr2k4W9ZgZ8Rln0Laz0+GsestXhNvWjES7HHtCBQNlQxB/S4C uZCJTcRBNfK92pCzOXrFeryDfh2a6O8WmbIQND+aNdnIWvmWpRJT16B5hNXlf8cX4w l72m2X836aQh9pFgAt3SMeJAhpIwxk51sTyxVa+t3eib1y8+/N3zJ4Gom+M01mWojg wr8uXUYj/hw3g== From: Tzung-Bi Shih To: bleung@chromium.org, groeck@chromium.org Cc: chrome-platform@lists.linux.dev, tzungbi@kernel.org, linux-kernel@vger.kernel.org Subject: [RESEND PATCH 11/11] platform/chrome: cros_ec_proto: return -EPROTO if empty payload Date: Tue, 28 Jun 2022 02:49:13 +0000 Message-Id: <20220628024913.1755292-12-tzungbi@kernel.org> X-Mailer: git-send-email 2.37.0.rc0.161.g10f37bed90-goog In-Reply-To: <20220628024913.1755292-1-tzungbi@kernel.org> References: <20220628024913.1755292-1-tzungbi@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org cros_ec_wait_until_complete() sends EC_CMD_GET_COMMS_STATUS which expects to receive sizeof(struct ec_response_get_comms_status) from cros_ec_xfer_command(). Return -EPROTO if cros_ec_xfer_command() returns 0. Signed-off-by: Tzung-Bi Shih --- drivers/platform/chrome/cros_ec_proto.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/platform/chrome/cros_ec_proto.c b/drivers/platform/chrome/cros_ec_proto.c index 5323edddb540..0c7042aa2640 100644 --- a/drivers/platform/chrome/cros_ec_proto.c +++ b/drivers/platform/chrome/cros_ec_proto.c @@ -166,6 +166,11 @@ static int cros_ec_wait_until_complete(struct cros_ec_device *ec_dev, uint32_t * break; } + if (ret == 0) { + ret = -EPROTO; + break; + } + if (!(status->flags & EC_COMMS_STATUS_PROCESSING)) break; } -- 2.37.0.rc0.161.g10f37bed90-goog