Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp3559567iog; Mon, 27 Jun 2022 20:01:29 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tKRUINn4YI74pwd2kGjvWX30qCE3SV7kfOCx4t98ioxYL4ZW9KF0BsxVGWmnb8nviOhq4J X-Received: by 2002:a17:907:2d2b:b0:726:a628:d1ae with SMTP id gs43-20020a1709072d2b00b00726a628d1aemr8050438ejc.336.1656385289121; Mon, 27 Jun 2022 20:01:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656385289; cv=none; d=google.com; s=arc-20160816; b=jbuxei6ibZBwjwosmT1jgVF1vDNhCNbIRYFiOpk8T0hxw+vrLwgKWQlEw9MIUmqp4S Bep3OTjgPfYzPrkOCJuYDTZc4ANVbv/QB2p5OToa77EiglhzWIMicN4W6ev+lrRCDwhW WWeEMTwjWH2cO0rf+TrRlIZTRjp/XViotkoEiMW5fmRLPJiltaACR8hh4oUxr/2IhF6k +8gRRQAGe5l/Zs02bqzfS+KzsKryiltHdqJUJkXCDY40haxd5BcfmdLCgsr/Z386J22e bv/sSACEmBepLpOwc13goWaGHB2oVNJW0MaOypTcrF8ePqLFuTLhiwoPd1/sOO/LY0RW q5SQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=UzhoWqCJnqOyUe7iAEBoE2sbSgdS6MEFq3V2SLhNjNs=; b=tw/so4aP9WmXbNHfyBqrMqkr8kn+dyDuM1cmyd/tWYQIEUqdaOdf3Z+S8qje/PGZ2b f6De65F2139QQi3UX3dOYOLmk4yk5gygDR9l6JOi+aRuCSBVdT0w/NZv9cK8YsmiLNDU Pyz1NtsswNLN8xsypj6lzBAmYwAmK/TSxfdaSjxESkgqFCbZtGhN/YwfYLBDAEUaFTfI J7smbtNxe3VM1pXtWPGjC95PLdM3bP/78oYb3ybhX2iEYbIHfrOULHMK/08Z8zUyztvW jxd9QRBdgXRBYk9ipGKuOlOR3QOCHR8JmOMSqwLGmY0F82WSb6HJkbb5mVTqfVHCRMvQ 7fCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Cyj0asfm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b4-20020a1709063f8400b006f3941cda0bsi9922659ejj.129.2022.06.27.20.01.04; Mon, 27 Jun 2022 20:01:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Cyj0asfm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343877AbiF1Ct7 (ORCPT + 99 others); Mon, 27 Jun 2022 22:49:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343789AbiF1Ctp (ORCPT ); Mon, 27 Jun 2022 22:49:45 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0A26F29 for ; Mon, 27 Jun 2022 19:49:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 86D93B81BC2 for ; Tue, 28 Jun 2022 02:49:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52CD0C341CF; Tue, 28 Jun 2022 02:49:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656384582; bh=MY2CsMAMjNg3ebYD8mcpnnStMEQdNHHn6XyNk73BJns=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Cyj0asfmbcWRj+P0vYwcNJAQzXxyVEwl1Fqu+MX2+CSbO56uL+eFaZ/wf/fHF5s1y AYnj+ClwJrZg21B3BGFIo7V6QVPzLuBWhYy/ATo2FehHCJE3kmP3BHFwbeDEaXV507 ytgaFg5DJewASj3L4o277RpAQ8m8UmMaqYBpf6Lf7KoHfyP037RelpfVPp6CKPuPv4 WqKYF8lzaTEpClxmNfAiDaGNwDL1yo2pVaJj1OJrjOzHDBvzqcjMsPAmbrhdua0GAn 9MYHnRr7LR03/pimbrEv/Z3UQ0nyK0KbFgRV1BOsmFE6BFcKEgWT6mOur1ABUPleIx lSRCwyO3Vz0eA== From: Tzung-Bi Shih To: bleung@chromium.org, groeck@chromium.org Cc: chrome-platform@lists.linux.dev, tzungbi@kernel.org, linux-kernel@vger.kernel.org Subject: [RESEND PATCH 08/11] platform/chrome: cros_ec_proto: change Kunit expectation for EC errors Date: Tue, 28 Jun 2022 02:49:10 +0000 Message-Id: <20220628024913.1755292-9-tzungbi@kernel.org> X-Mailer: git-send-email 2.37.0.rc0.161.g10f37bed90-goog In-Reply-To: <20220628024913.1755292-1-tzungbi@kernel.org> References: <20220628024913.1755292-1-tzungbi@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org cros_ec_wait_until_complete() checks `msg->result` for EC_CMD_GET_COMMS_STATUS. However, it doesn't return standard error codes like most of others. Change the Kunit test expectation to align them. Signed-off-by: Tzung-Bi Shih --- drivers/platform/chrome/cros_ec_proto_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/chrome/cros_ec_proto_test.c b/drivers/platform/chrome/cros_ec_proto_test.c index fbb872040711..2a6b099fbfd9 100644 --- a/drivers/platform/chrome/cros_ec_proto_test.c +++ b/drivers/platform/chrome/cros_ec_proto_test.c @@ -1927,7 +1927,7 @@ static void cros_ec_proto_test_cmd_xfer_in_progress_return_error(struct kunit *t } ret = cros_ec_cmd_xfer(ec_dev, &msg); - KUNIT_EXPECT_EQ(test, ret, 0); + KUNIT_EXPECT_EQ(test, ret, -EOPNOTSUPP); KUNIT_EXPECT_EQ(test, msg.result, EC_RES_INVALID_COMMAND); -- 2.37.0.rc0.161.g10f37bed90-goog