Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 28 Jun 2022 06:49:42 +0200
From:   Oleksij Rempel <o.rempel@pengutronix.de>
To:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
Cc:     Anton Lundin <glance@acc.umu.se>, kernel@pengutronix.de,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        Lukas Wunner <lukas@wunner.de>
Subject: Re: [PATCH net v1 2/2] net: usb: asix: do not force pause frames
 support
Message-ID: <20220628044942.GC13092@pengutronix.de>
References: <20220624075139.3139300-1-o.rempel@pengutronix.de>
 <20220624075139.3139300-2-o.rempel@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20220624075139.3139300-2-o.rempel@pengutronix.de>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Fri, Jun 24, 2022 at 09:51:39AM +0200, Oleksij Rempel wrote:
> We should respect link partner capabilities and not force flow control
> support on every link. Even more, in current state the MAC driver do not
> advertises pause support so we should not keep flow control enabled at
> all.
> 
> Fixes: e532a096be0e ("net: usb: asix: ax88772: add phylib support")
> Reported-by: Anton Lundin <glance@acc.umu.se>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>

In different mail thread Anton reported as tested.
Tested-by: Anton Lundin <glance@acc.umu.se>

> ---
>  drivers/net/usb/asix.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/usb/asix.h b/drivers/net/usb/asix.h
> index 2c81236c6c7c..45d3cc5cc355 100644
> --- a/drivers/net/usb/asix.h
> +++ b/drivers/net/usb/asix.h
> @@ -126,8 +126,7 @@
>  	 AX_MEDIUM_RE)
>  
>  #define AX88772_MEDIUM_DEFAULT	\
> -	(AX_MEDIUM_FD | AX_MEDIUM_RFC | \
> -	 AX_MEDIUM_TFC | AX_MEDIUM_PS | \
> +	(AX_MEDIUM_FD | AX_MEDIUM_PS | \
>  	 AX_MEDIUM_AC | AX_MEDIUM_RE)
>  
>  /* AX88772 & AX88178 RX_CTL values */
> -- 
> 2.30.2
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |