Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp3640271iog; Mon, 27 Jun 2022 22:38:09 -0700 (PDT) X-Google-Smtp-Source: AGRyM1t6oH8XBA4TmjQYYfKyyuUCYwBdhT5IXRtPMDb22t6wGXTCPQpyTCOiIVrDnVvjPqV9peVs X-Received: by 2002:a17:907:6289:b0:6e0:eb0c:8ee7 with SMTP id nd9-20020a170907628900b006e0eb0c8ee7mr15521712ejc.245.1656394689497; Mon, 27 Jun 2022 22:38:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656394689; cv=none; d=google.com; s=arc-20160816; b=TEX6DYNIOW/Cawn/+8G5lB0ieHNenf+H9h/DwyolScnSyiJjhZ8b9sDz6uHyLPqHyQ 0FUbEXhVoJ4O6/K3q/hUA1FjbHyk60ZUetfux5mJ8o2CICU8OT6Uq1xqHmPO32YHgRLW +PUq+mLv/9mTWfCBg7Dd5FkY5UuV0onB5vZuv6A7QC5hxnauuUpmU4vxe7LBKqc1ga1o T/r06ClC2peLypNvJVh5KR8VIABrEH9CmDQ/rR8d9GI3qrLBa2YmuhBlEqOHSFp3YQLs xoqFo9mEH4J6bd4NXa91P8ZiCHmIDNVhvbFBckDrf63SWPdM9XvxNaalKHqOCxnFfJUc YmLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=2t3ECN0KaA8G7pMY/rN1hBOlXkWy8C+27ccuf5eGEEw=; b=Ld0QholY2beNwXIMUpsAKKEwq3IPlacO+nXhUdvTE2Tf+JcQL5FB9gRtFrltV4FQA4 SS/F/4ulIMKQL3MCJnXdmqDXkzodkde2z9uJJJ+DYy/6jA2Ba6xfF6kD387CNoyMrA0c 6abkQyngn4QKZtAaXuVgR06rv09rE5b3NK9vTxTGIa0VB0A1KpiuylGqRPKCw95Q+mk5 Qv42Cy1cU9ZFY1fGxCYg/IiEztJhZLBb0DjApgXY/AFlixeAJ/b5ArmTEbkVdtrI82kx H261FjHLPEpR8hsFMjyzVLwec/u6Qlx9nVDuzkQgoBhMqH4JdVOjGNiznQDU6b+J9M06 cBOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="mZBJ/fzy"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j19-20020a05640211d300b004356a5f330fsi16784585edw.445.2022.06.27.22.37.44; Mon, 27 Jun 2022 22:38:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="mZBJ/fzy"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237478AbiF1FAU (ORCPT + 99 others); Tue, 28 Jun 2022 01:00:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231331AbiF1FAT (ORCPT ); Tue, 28 Jun 2022 01:00:19 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14B7025C6C; Mon, 27 Jun 2022 22:00:17 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 562E0B808C0; Tue, 28 Jun 2022 05:00:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 0FEC7C341C6; Tue, 28 Jun 2022 05:00:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656392415; bh=qGZe+ejHbGYf++Nv+InVQVdxCtp1qdpdb8Fwn+VNK1E=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=mZBJ/fzyd8mT2914urcaywKNC9xwYGclLYHn+GOQFNRh3SVr9OrQIKa828ajqthYK JBAtnW8ETi4BIHDcoV4qyZOI5hhaMSsuliXHcymMHupy7iU7iAso5XAIZE6sa5EDgk pR8Zts5Q6fi7Cdgy+sFiihfBDa7VpVacVUNc6jHbLwA2+XuDDHwYvItl+Ml8pHsunV glNI0orcmHLb9AYS3aSF54SdXLJZDtJQNXTZmdjtDip3OH/I/Gbbc0H8V31eGKyn9M ywRnDo8L+I9XYl8UgnmARUD9jD8AcboYdr8PeI6Ibm1Jr2rcqXsXADgV1O/IULHK9W ZK2GH1OrAXf8g== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id E5CE3E49BBA; Tue, 28 Jun 2022 05:00:14 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH v2] epic100: fix use after free on rmmod From: patchwork-bot+netdevbpf@kernel.org Message-Id: <165639241493.25506.6577886408154853926.git-patchwork-notify@kernel.org> Date: Tue, 28 Jun 2022 05:00:14 +0000 References: <20220627043351.25615-1-ztong0001@gmail.com> In-Reply-To: <20220627043351.25615-1-ztong0001@gmail.com> To: Tong Zhang Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, f.fainelli@gmail.com, jgg@ziepe.ca, arnd@arndb.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, yiluwu@cs.stonybrook.edu, romieu@fr.zoreil.com X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski : On Sun, 26 Jun 2022 21:33:48 -0700 you wrote: > epic_close() calls epic_rx() and uses dma buffer, but in epic_remove_one() > we already freed the dma buffer. To fix this issue, reorder function calls > like in the .probe function. > > BUG: KASAN: use-after-free in epic_rx+0xa6/0x7e0 [epic100] > Call Trace: > epic_rx+0xa6/0x7e0 [epic100] > epic_close+0xec/0x2f0 [epic100] > unregister_netdev+0x18/0x20 > epic_remove_one+0xaa/0xf0 [epic100] > > [...] Here is the summary with links: - [v2] epic100: fix use after free on rmmod https://git.kernel.org/netdev/net/c/8ee9d82cd0a4 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html