Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Ming Qian <ming.qian@nxp.com>
To:     mchehab@kernel.org, hverkuil-cisco@xs4all.nl
Cc:     shawnguo@kernel.org, robh+dt@kernel.org, s.hauer@pengutronix.de,
        kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: [PATCH] media: amphion: defer setting last_buffer_dequeued until resolution changes are processed
Date:   Tue, 28 Jun 2022 13:21:12 +0800
Message-Id: <20220628052112.27350-1-ming.qian@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qwpr+spgkR3Zpbc8fOPOM50sBKT27BkCm9zPRrJ5IMr4rn2Rf8PISxIsX83i?=
 =?us-ascii?Q?6SP2r3s0T3MBG1PU158PkTT97ZmEzWV8gSPSQYU+hAorKYBWTKnSK6FfdsFF?=
 =?us-ascii?Q?zMj1vySziDkAqJAUF5AAn3wnNlzjrY4vFM69cGLCQMv/OgjGGRf63ZnkJk0N?=
 =?us-ascii?Q?gPhkMStRPlnWNJfemR5CZ+Fvxowfz2hadpU27ZROjUV5PIhHFcqZ+UFrq67o?=
 =?us-ascii?Q?IfD74+Extv6fDYP1o28hC1ZDCuK36yqdEHKm/3Xfv7DliTzldEyBvXfPsKA/?=
 =?us-ascii?Q?n+lxjc86L40it0mDbwXHWnBh4qAntU5ikiD7JyJDIRTQqbGKHkuaGeeTPEyn?=
 =?us-ascii?Q?hEmcsrWNf9bgWqRZPTiykaGgy5fc/a91T5jJL8oBenFFt2xVcix93xzWxvuX?=
 =?us-ascii?Q?v3rzX9+o2w7Due6blpWucEwoxXMn+ZLH5Px778QeHkqTKQruqy9zi8UHXU+E?=
 =?us-ascii?Q?PQvvNGuoD3i6WC6+E6KnRv59KsFf4r3lUPljijsVmX57uuNMRmXS+N+zJSX3?=
 =?us-ascii?Q?DYvk4H9Q21+dKrHFDHvzVGGvItlGLWqObTn86OXlFVQl5chpuJxZ/D4IC1ML?=
 =?us-ascii?Q?9GvYFmV2fAPPbMOAT4TV3B1P3vuV2fdtUq17ghUMnB0ByxFw/eUZpvMQxH4K?=
 =?us-ascii?Q?rcMivaEEy3IDLbUGmxxUBoE4b0/bP0tVlVrjMul2zrihxfzqP4CA0gPeUBf9?=
 =?us-ascii?Q?4Nk1eZGUFeu4TUC/v3QlKDoYTCll0uolnttH8oLTSMDdWeCBQRsZQUVq4QH7?=
 =?us-ascii?Q?+t6rz0UTzwcc54M625TgNQDhuMrpF83Jho2pLqVwXwPjOd5E76l0sG5VtOsr?=
 =?us-ascii?Q?FzzuXZxUJv1xyWOArNe+ve7WHayN5AtTYfpmm5zdI90+nhQUZ8FULFtmGXW8?=
 =?us-ascii?Q?Q0N2mMmH//GT9b6vxhYjtKNbE7B6SPBGv9VI1GJIp91Cd/ckUb2br7LQMF2s?=
 =?us-ascii?Q?Qeyj6FB9S5HOOnEdDKh0c3oJkyvFTBhDkf04bi4Mvbp7IYZONn3QZ4BYr0T+?=
 =?us-ascii?Q?9trr3jGZhL6WRx0baulrA0NPqTA13tPVHAePz7oiLJiKqyFk33DPij9EtxXN?=
 =?us-ascii?Q?9tUyZDGw4H0oGH71pKWJ0mxrVQaz8d1lLaVlAhH8SsKUlAxEXSNzt86g9OJD?=
 =?us-ascii?Q?3TTeJyQZV71a1LOQ0AHcFg6MpnsDykyE1ex0jNND2XjEkf2lw3nNq6V913bC?=
 =?us-ascii?Q?EkuOZUhSK/DAF279Vd+AlTu8FtWihHTgbo0xrXZXV9q5v+d30U2LlsnEZ0TQ?=
 =?us-ascii?Q?jcPo3Bip2R8w6/O6+GOev5hJmXbaQpNGfRF7r6KI1p+oFiIZPjfEACVuQHOR?=
 =?us-ascii?Q?bpn/nUor1dtPII67p09YHrr5gfSbk4vKgl0b8n1KwRrQizGkBHCnV8HFlzCd?=
 =?us-ascii?Q?2xX2ywUHV/dzOE2dmUN8b+hMZvgkDgd//oLIHjSKhcc0fz1Y1vo4BZi6C5hq?=
 =?us-ascii?Q?MXTY3W1KVcvPuHv8PoQ5+XqYdHFNaQRCvcx2VtQBLhppnZGs9atjP1q6EqtL?=
 =?us-ascii?Q?0qlOGlQOIts28OAlqXmLL2vp09ai/0NKVvSbO6nrxP3aS4pMfnWMuxaGd7hn?=
 =?us-ascii?Q?L88vU8hFukDlmimCWSwZcxqyzgxC0FUf/sSGSnc1?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 04fbb354-1cc2-43de-6113-08da58c60d4a
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6341.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2022 05:21:27.7812
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BxzWWi1hjLvnn39r+TOqQGwZkZiI6oRB14Smn4MdoC6DbeQrbg7jmw5s7ruHM3C6jpQV4UEBcBeJzR6a3n0H0g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5168
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Don't set last_buffer_dequeued during dynamic resolution change,
otherwise it may be cleared in handling resolution change,
as streamoff may be called in dynamic resolution change.

Normally, this does not happen.
But we encounter a special testcase,
User issue V4L2_DEC_CMD_STOP after enqueue one buffer
that only contains codec config header, but not any frame data.
So VPU report the parsed resolution, then report the eos event.

So driver should notify user to handle resolution change first,
after it's handled, set the last_buffer_dequeued.
then the user can exit decoding normally.

Otherwise the user may be stalled.

Fixes: 6de8d628df6ef ("media: amphion: add v4l2 m2m vpu decoder stateful driver")
Signed-off-by: Ming Qian <ming.qian@nxp.com>
---
 drivers/media/platform/amphion/vdec.c     | 36 ++++++++++++++---------
 drivers/media/platform/amphion/vpu_v4l2.c |  2 +-
 2 files changed, 23 insertions(+), 15 deletions(-)

diff --git a/drivers/media/platform/amphion/vdec.c b/drivers/media/platform/amphion/vdec.c
index 51218a41a5ac..1a00f1926b57 100644
--- a/drivers/media/platform/amphion/vdec.c
+++ b/drivers/media/platform/amphion/vdec.c
@@ -178,16 +178,6 @@ static int vdec_ctrl_init(struct vpu_inst *inst)
 	return 0;
 }
 
-static void vdec_set_last_buffer_dequeued(struct vpu_inst *inst)
-{
-	struct vdec_t *vdec = inst->priv;
-
-	if (vdec->eos_received) {
-		if (!vpu_set_last_buffer_dequeued(inst))
-			vdec->eos_received--;
-	}
-}
-
 static void vdec_handle_resolution_change(struct vpu_inst *inst)
 {
 	struct vdec_t *vdec = inst->priv;
@@ -234,6 +224,21 @@ static int vdec_update_state(struct vpu_inst *inst, enum vpu_codec_state state,
 	return 0;
 }
 
+static void vdec_set_last_buffer_dequeued(struct vpu_inst *inst)
+{
+	struct vdec_t *vdec = inst->priv;
+
+	if (inst->state == VPU_CODEC_STATE_DYAMIC_RESOLUTION_CHANGE)
+		return;
+
+	if (vdec->eos_received) {
+		if (!vpu_set_last_buffer_dequeued(inst)) {
+			vdec->eos_received--;
+			vdec_update_state(inst, VPU_CODEC_STATE_DRAIN, 0);
+		}
+	}
+}
+
 static int vdec_querycap(struct file *file, void *fh, struct v4l2_capability *cap)
 {
 	strscpy(cap->driver, "amphion-vpu", sizeof(cap->driver));
@@ -493,6 +498,8 @@ static int vdec_drain(struct vpu_inst *inst)
 
 static int vdec_cmd_start(struct vpu_inst *inst)
 {
+	struct vdec_t *vdec = inst->priv;
+
 	switch (inst->state) {
 	case VPU_CODEC_STATE_STARTED:
 	case VPU_CODEC_STATE_DRAIN:
@@ -503,6 +510,8 @@ static int vdec_cmd_start(struct vpu_inst *inst)
 		break;
 	}
 	vpu_process_capture_buffer(inst);
+	if (vdec->eos_received)
+		vdec_set_last_buffer_dequeued(inst);
 	return 0;
 }
 
@@ -1204,7 +1213,6 @@ static void vdec_event_eos(struct vpu_inst *inst)
 	vdec->eos_received++;
 	vdec->fixed_fmt = false;
 	inst->min_buffer_cap = VDEC_MIN_BUFFER_CAP;
-	vdec_update_state(inst, VPU_CODEC_STATE_DRAIN, 0);
 	vdec_set_last_buffer_dequeued(inst);
 	vpu_inst_unlock(inst);
 }
@@ -1480,10 +1488,10 @@ static int vdec_stop_session(struct vpu_inst *inst, u32 type)
 		vdec_update_state(inst, VPU_CODEC_STATE_SEEK, 0);
 		vdec->drain = 0;
 	} else {
-		if (inst->state != VPU_CODEC_STATE_DYAMIC_RESOLUTION_CHANGE)
+		if (inst->state != VPU_CODEC_STATE_DYAMIC_RESOLUTION_CHANGE) {
 			vdec_abort(inst);
-
-		vdec->eos_received = 0;
+			vdec->eos_received = 0;
+		}
 		vdec_clear_slots(inst);
 	}
 
diff --git a/drivers/media/platform/amphion/vpu_v4l2.c b/drivers/media/platform/amphion/vpu_v4l2.c
index da455e5ab337..8a3eed957ae6 100644
--- a/drivers/media/platform/amphion/vpu_v4l2.c
+++ b/drivers/media/platform/amphion/vpu_v4l2.c
@@ -500,8 +500,8 @@ static int vpu_vb2_start_streaming(struct vb2_queue *q, unsigned int count)
 		  fmt->sizeimage[1], fmt->bytesperline[1],
 		  fmt->sizeimage[2], fmt->bytesperline[2],
 		  q->num_buffers);
-	ret = call_vop(inst, start, q->type);
 	vb2_clear_last_buffer_dequeued(q);
+	ret = call_vop(inst, start, q->type);
 	if (ret)
 		vpu_vb2_buffers_return(inst, q->type, VB2_BUF_STATE_QUEUED);
 
-- 
2.36.1