Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp3656862iog; Mon, 27 Jun 2022 23:09:38 -0700 (PDT) X-Google-Smtp-Source: AGRyM1u+3sWAr2JhDehgxtKlRSNhya3NAKebMOWMre+D9lR1GXajOVyXhebgp2TXE7t5mTF3/Ovc X-Received: by 2002:a05:6a00:811:b0:525:50c2:4c2f with SMTP id m17-20020a056a00081100b0052550c24c2fmr3090911pfk.62.1656396578246; Mon, 27 Jun 2022 23:09:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656396578; cv=none; d=google.com; s=arc-20160816; b=lj5LgkkjALK+1IkvrfcKPWy9i3IHieRABtWr/MTdEgwSt1ghNzu9mfznVB0iLQB2lV 8SCnHpxNUmQ1dRCJJQrzu/5VHsAZRtm/VddJbTqUwdGzgPOAbPzphPTd3EFFI7wXlkya dA2L6HlycSaRJjMSepJHhUzz5M3qEaJWXSP8g3QhV8nUHScL71MncSK2N41hb2u2rvSd JR/fh+2j816pehNPDa6loi4pq7pyJ6oA2JIff8QqU+iEbkxVKsrP7NErbckn5hYPJRQj 3oTvg72zSK+b8AMy8VMVlTcT8n+NEdNAudz0e2LDtX9R4wg9G5MzOk6DOoK9AIe3KqEK 2VTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=CBj+Cn4MKugecKoog8ybdIr5Daaq1aTcCFNZ89ZBHME=; b=Nf1Yp45dMew1sxC58trcuUXALJaAPWbAYgX2KNXacvzcZD+zAQozhUt4nVfAbNk/35 NroFC1xE+VDgrZO25U6LpAshKzNDxmYQGlkYCTyZULZNtzIspAlFpj8iPRjUTitbyWE9 S05KzO2t6A4gyHkp/rtnyQjSsU4cXu1Q5HVBcATKWsIAWIO5HXv+b9tEuFnR9GGX/hs4 a8F7FZSA+R8vinLLZz0uKNSmcodTJ27MDA1yF7yjjVImLwjnc4I4iQIEFaMfa+IgNJ7w 5kDRUQm3gFd75I5PMMIDJ/x/a4SjNjTTP645s16IzNl/TO/z5FY+Itn3IExzlbhM6aTm y6zA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=j177mRzN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t189-20020a6381c6000000b0040db5dc75fcsi11171528pgd.383.2022.06.27.23.09.26; Mon, 27 Jun 2022 23:09:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=j177mRzN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245240AbiF1GGk (ORCPT + 99 others); Tue, 28 Jun 2022 02:06:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243515AbiF1GGi (ORCPT ); Tue, 28 Jun 2022 02:06:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9324B2315F; Mon, 27 Jun 2022 23:06:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 33A4161861; Tue, 28 Jun 2022 06:06:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1770AC3411D; Tue, 28 Jun 2022 06:06:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1656396396; bh=Q3rlk/VjGtCIyeHgAcTX+dBcAyjfukbpCkgFdAUNBNI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=j177mRzNk+QH+cwF05/tUQQiM+MaTW+e8suFIlVwVSDIJNsadptiFKZsLUN3K2iRb ha32m5m5Gnon2aPkGA6lXxd932LiNLglFXy4HJEGe5waW18Jg009OOsQTwDNXmgOWp jIo8cmE4iO0j3nnvvXVIn4+wpX64pV8IbOkpVJtI= Date: Tue, 28 Jun 2022 08:06:33 +0200 From: Greg Kroah-Hartman To: ira.weiny@intel.com Cc: Dan Williams , Bjorn Helgaas , Jonathan Cameron , Lukas Wunner , Alison Schofield , Vishal Verma , Dave Jiang , Ben Widawsky , linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH V12 5/9] driver-core: Introduce BIN_ATTR_ADMIN_{RO,RW} Message-ID: References: <20220628041527.742333-1-ira.weiny@intel.com> <20220628041527.742333-6-ira.weiny@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220628041527.742333-6-ira.weiny@intel.com> X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 27, 2022 at 09:15:23PM -0700, ira.weiny@intel.com wrote: > From: Ira Weiny > > Many binary attributes need to limit access to CAP_SYS_ADMIN only; ie > many binary attributes specify is_visible with 0400 or 0600. > > Make setting the permissions of such attributes more explicit by > defining BIN_ATTR_ADMIN_{RO,RW}. > > Cc: Greg Kroah-Hartman > Cc: Bjorn Helgaas > Signed-off-by: Ira Weiny Reviewed-by: Greg Kroah-Hartman