Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 28 Jun 2022 08:19:16 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Xin Ji <xji@analogixsemi.com>
Cc:     Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        bliang@analogixsemi.com, qwen@analogixsemi.com,
        jli@analogixsemi.com, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org
Subject: Re: [PATCH v12 3/3] usb: typec: anx7411: Add Analogix PD ANX7411
 support
Message-ID: <YrqdZE7IfKYZHkCu@kroah.com>
References: <20220628044843.2257885-1-xji@analogixsemi.com>
 <20220628044843.2257885-3-xji@analogixsemi.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220628044843.2257885-3-xji@analogixsemi.com>
Precedence: bulk

On Tue, Jun 28, 2022 at 12:48:42PM +0800, Xin Ji wrote:
> Add driver for analogix ANX7411 USB Type-C DRP port controller.
> 
> Signed-off-by: Xin Ji <xji@analogixsemi.com>
> ---
> V11 -> V12 : Fix Greg Kroah-Hartman's comment

Which comment?  This is very vague, it's almost like "made changes".

We need specifics here, otherwise it's impossible to review.  Would you
want to see this as a changelog statement for something you spent time
in reviewing?

Also, your changelog itself needs more text, as to what type of device
this is and more information about it if possible.

thanks,

greg k-h