Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <60365571-bcf0-d096-d023-c9a8bc9a40a7@fb.com>
Date:   Mon, 27 Jun 2022 23:11:13 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.10.0
Subject: Re: [PATCH bpf-next v2 5/8] selftests/bpf: Test cgroup_iter.
Content-Language: en-US
To:     Yosry Ahmed <yosryahmed@google.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>, Hao Luo <haoluo@google.com>,
        Tejun Heo <tj@kernel.org>, Zefan Li <lizefan.x@bytedance.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Shuah Khan <shuah@kernel.org>, Michal Hocko <mhocko@kernel.org>
Cc:     Roman Gushchin <roman.gushchin@linux.dev>,
        David Rientjes <rientjes@google.com>,
        Stanislav Fomichev <sdf@google.com>,
        Greg Thelen <gthelen@google.com>,
        Shakeel Butt <shakeelb@google.com>,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        bpf@vger.kernel.org, cgroups@vger.kernel.org
References: <20220610194435.2268290-1-yosryahmed@google.com>
 <20220610194435.2268290-6-yosryahmed@google.com>
From:   Yonghong Song <yhs@fb.com>
In-Reply-To: <20220610194435.2268290-6-yosryahmed@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Tk5QTkRFRW5zakcra0E0ekZxSlp0bWZzRnJBWFBzQWNwaGZtakkwYlJvZit6?=
 =?utf-8?B?SWNKeGQ1enJXc3NaWGZuRFh1RWxlNVlSWFlEcmFsZ0k1cFdMOGRiU0taRndi?=
 =?utf-8?B?S0NJNHp6QnRIVytWZzlHaEFpZ0tqUzR0MmtFSkhMVUw1NWhKV092dmRzaUJO?=
 =?utf-8?B?dVZwVGk1KzdUby91QlI2Qk5zd0ttKytMM29GZ2hPMkpadGg2TmRYTGZFMURJ?=
 =?utf-8?B?S2hleTdxMlQvbncwcnpWQTh0Nm4rN0hTT3dzayt3b2tYZis5SWVtRUtPQ2Nv?=
 =?utf-8?B?dVVaU2dwdFFPUE1MVjJRR1Bwa3pHdWJQZmVyZHo2YVVlY2ZiVno0UlBqQis0?=
 =?utf-8?B?ZDdTL1BmRGRmejVicTQvWk9NTzVhTWlaTmlFS1ZKcWhhM0w2NjlDYUxZUGpu?=
 =?utf-8?B?Q0tyNm5SQ0EwOGh6bjVmczM0SDBjcW0rWmRkSE9zV1h0eTdyNTBIaDJCemdt?=
 =?utf-8?B?Uy9YYXVKYk9Vd0lMNU9BTkpLQ1dDclJzekFDcWpjVm5FUkx1Yzk2dHRrSlhv?=
 =?utf-8?B?VmsvU1lESjVIZU1RYUMrd0RDVVJTM1FFMWRwOWU5cEw1ZkJ0cXBtdEdqemt3?=
 =?utf-8?B?OElDM1JreDQzczNFY3FNWVBpb3gvL1lmNlZMWlMvMmNzd1V5MlVEd3g5TjlG?=
 =?utf-8?B?RkYrZ1pKdEFMYmRPZHBIdXFRV0ZvVGh5anhFUERqR05SdzFXS0l3OXNuTU5K?=
 =?utf-8?B?REZKdGxDc0dCY01lVUs1S2JUNjk5L2J0VGwrWEUzQlJaQ0ZmazlmYklYQjVF?=
 =?utf-8?B?K2RkSEVEc2lOUHBVRHorbGY2SXd3SFM4TkRVWGNDaFhKQlE0c2lVQng3elNh?=
 =?utf-8?B?bENTNXQvL1poVGZzT1J6NmpNU2JZUkxDMWFtRXkwZ1ZnZVV2VTZ6NmJQeHht?=
 =?utf-8?B?dDZ1RDhsRXdZTDJXSldGcjZCajBSd2Q5cGxXREFTMDEzQVR4SjBaRk5rbVh0?=
 =?utf-8?B?SzFTaGwvZXNJdWlSUUZ2QThoSjNvTDh6bzNlbEhvcWxreSsvanh3VmIrQzZw?=
 =?utf-8?B?MUlOSnlQZUExYkE1ME1SYW4vTmEyRFBkWXpKV2pPWVNsbGNJZUlTUFoxVDVU?=
 =?utf-8?B?aTBENG1rNXNNWGlWTXpwM3BocU5IMnh6alRNb2RLWTJBcDlmbHdUYUhGeTQ4?=
 =?utf-8?B?L0hqQS9ocHVsam8xNXVWMEhYUnpTMjQzTnZDQ2tFWVZXUTlXVmlGaFArYnY1?=
 =?utf-8?B?aTMyanNHVDUyUEdWSHg0NlRjNDR0RExZbnY0bzRQS2srdlUxcEM3blJzdzN5?=
 =?utf-8?B?QS9QMy9sVUVXRk05SkRDbVBQajkweVhtdFBYNWtydEh2S3ZHREVpYjVIMTFo?=
 =?utf-8?B?M0VXUDYyK2NSVTNUMWROZC84Rk1sMVZqY0hINWlzNHcrZ2luajhDTE11ckg5?=
 =?utf-8?B?d2F3WEUyc0RHYm52L09ZNU91MVFRM2w4RWhMWGNkZFhocUxqUVROUDdGQkNH?=
 =?utf-8?B?eXYrRmRVaWhvM3YrRGpxVUc5NEo2SjNIOFkxTFN3VXM0TlJFZ2Z1bnYwWWZQ?=
 =?utf-8?B?RHRMRk5kSmtlMmpjdkN2aXFHZThrWGY0UzFHME1mSzN3YmNGY3VsVHdoZE5V?=
 =?utf-8?B?Q3dzZFcySTM3QXdjaUhZTmZSeFFxdmQ1MFVySFNtOW5DaXNXZmN5N294UFRN?=
 =?utf-8?B?Y0lyR2V3dldFU0ZTdGlGeFFHcXF2VTVSQ2RJY2tzMnJmaUNhMVArdSsrbkdJ?=
 =?utf-8?B?TzhGdGtvQjdicWhEc2dEWlJEd1hkZ2ozQW5RMG9WSHRjQjRncUdob0toOFJR?=
 =?utf-8?B?MFpsdUZ3SFNCSk5HWWhsY2RwSEFQcVhUcS9Jdk9vdlZkVUQrYXd6U21EVnM5?=
 =?utf-8?B?UWJlSXluNmRFUGtxZlZkc0YrRkErWHp1bHdZeDZNemFZbWppbHl2THZMZFgr?=
 =?utf-8?B?ZmM5Qjk2OEkvTmdldkQrUXlRc1NndFR6TGp6dXpzY05ocjJnY09TNlNSTVdJ?=
 =?utf-8?B?aXI4RzlaaEV6THpOekFlajRxUjVPUkZoVGxrSjZGcVZjTTBsYU9DNWRSSysz?=
 =?utf-8?B?c3RtcWlIM1BwaW1TM1NuN1ZHR1IzWlZCK3dmdlpFcldFL0J5ek5zZ1k3MHM4?=
 =?utf-8?B?WXpNb1NrSWY3NExhd1dKZkxYTEs0Q2NaOUh3TXBsUWw0QWlJY0U1RElvRVVB?=
 =?utf-8?Q?Ye4bBz0zDoRkWn8fiyTUFx4GA?=
X-OriginatorOrg: fb.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6a309d7d-c553-4569-d7c3-08da58cd02f5
X-MS-Exchange-CrossTenant-AuthSource: SN6PR1501MB2064.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2022 06:11:16.9114
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: F1gBjwWygf08dCGqL1iQg9oh6B9fZSfnmO2YlO9jN14imssNjTnZ+3/eKEFj7evX
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB2534
X-Proofpoint-ORIG-GUID: hk4_i9Trha6Jaz6GPVqN3qzzgecEAfpF
X-Proofpoint-GUID: hk4_i9Trha6Jaz6GPVqN3qzzgecEAfpF
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-06-27_09,2022-06-24_01,2022-06-22_01
X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/10/22 12:44 PM, Yosry Ahmed wrote:
> From: Hao Luo <haoluo@google.com>
> 
> Add a selftest for cgroup_iter. The selftest creates a mini cgroup tree
> of the following structure:
> 
>      ROOT (working cgroup)
>       |
>     PARENT
>    /      \
> CHILD1  CHILD2
> 
> and tests the following scenarios:
> 
>   - invalid cgroup fd.
>   - pre-order walk over descendants from PARENT.
>   - post-order walk over descendants from PARENT.
>   - walk of ancestors from PARENT.
>   - early termination.
> 
> Signed-off-by: Hao Luo <haoluo@google.com>
> Signed-off-by: Yosry Ahmed <yosryahmed@google.com>

Acked-by: Yonghong Song <yhs@fb.com>