Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <897594cde5f294f9d5e96917bce1ac751338d0aa.camel@pengutronix.de>
Subject: Re: [PATCH net v1 1/2] net: asix: fix "can't send until first
 packet is send" issue
From:   Lucas Stach <l.stach@pengutronix.de>
To:     Oleksij Rempel <o.rempel@pengutronix.de>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
Cc:     Anton Lundin <glance@acc.umu.se>, Lukas Wunner <lukas@wunner.de>,
        linux-kernel@vger.kernel.org, kernel@pengutronix.de,
        netdev@vger.kernel.org
Date:   Tue, 28 Jun 2022 09:50:42 +0200
In-Reply-To: <20220628044913.GB13092@pengutronix.de>
References: <20220624075139.3139300-1-o.rempel@pengutronix.de>
         <20220628044913.GB13092@pengutronix.de>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Oleksij,

subject of this patch looks strange. It should probably read "can't
receive until first packet is sent".

Regards,
Lucas

Am Dienstag, dem 28.06.2022 um 06:49 +0200 schrieb Oleksij Rempel:
> On Fri, Jun 24, 2022 at 09:51:38AM +0200, Oleksij Rempel wrote:
> > If cable is attached after probe sequence, the usbnet framework would
> > not automatically start processing RX packets except at least one
> > packet was transmitted.
> > 
> > On systems with any kind of address auto configuration this issue was
> > not detected, because some packets are send immediately after link state
> > is changed to "running".
> > 
> > With this patch we will notify usbnet about link status change provided by the
> > PHYlib.
> > 
> > Fixes: e532a096be0e ("net: usb: asix: ax88772: add phylib support")
> > Reported-by: Anton Lundin <glance@acc.umu.se>
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> 
> In different mail thread Anton reported as tested.
> Tested-by: Anton Lundin <glance@acc.umu.se>
> 
> > ---
> >  drivers/net/usb/asix_common.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/net/usb/asix_common.c b/drivers/net/usb/asix_common.c
> > index 632fa6c1d5e3..b4a1b7abcfc9 100644
> > --- a/drivers/net/usb/asix_common.c
> > +++ b/drivers/net/usb/asix_common.c
> > @@ -431,6 +431,7 @@ void asix_adjust_link(struct net_device *netdev)
> >  
> >  	asix_write_medium_mode(dev, mode, 0);
> >  	phy_print_status(phydev);
> > +	usbnet_link_change(dev, phydev->link, 0);
> >  }
> >  
> >  int asix_write_gpio(struct usbnet *dev, u16 value, int sleep, int in_pm)
> > -- 
> > 2.30.2
> > 
> > 
>