Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i8771445c:Fastmail
Date:   Tue, 28 Jun 2022 10:18:24 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     Yu Liao <liaoyu15@huawei.com>
Cc:     emma@anholt.net, eric@anholt.net, bbrezillon@kernel.org,
        liwei391@huawei.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/vc4: fix dereference before NULL check
Message-ID: <20220628081824.5u4p7q6xepp4uvsd@houat>
References: <20220628063657.3169049-1-liaoyu15@huawei.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="auukrdoejisn426n"
Content-Disposition: inline
In-Reply-To: <20220628063657.3169049-1-liaoyu15@huawei.com>
Precedence: bulk


--auukrdoejisn426n
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, Jun 28, 2022 at 02:36:57PM +0800, Yu Liao wrote:
> The "perfmon" pointer is equal to the return value of idr_find
> which may be NULL, access by vc4_perfmon_get before checking if
> it was NULL. Fix this by dereferencing "perfmon" after "perfmon"
> has been null checked.
>=20
> Addresses-Coverity: ("Dereference before null check")
> Fixes: 65101d8c9108 ("drm/vc4: Expose performance counters to userspace")
> Signed-off-by: Yu Liao <liaoyu15@huawei.com>

A similar patch has already been merged:
https://lore.kernel.org/dri-devel/20220622080243.22119-1-maxime@cerno.tech/

Thanks!
Maxime

--auukrdoejisn426n
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYrq5UAAKCRDj7w1vZxhR
xd9KAP9+WatATh3hNMH6GeSkuP3T4bsk3GeDzOoHsrHhLCmvKAD9HJY6o/84y8so
/KpOXTRwS9prU1ikQ4hFYjbSdPJhhgg=
=HmDs
-----END PGP SIGNATURE-----

--auukrdoejisn426n--