Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        "Jason Gunthorpe" <jgg@nvidia.com>,
        Christoph Hellwig <hch@infradead.org>,
        "Raj, Ashok" <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Jean-Philippe Brucker <jean-philippe@linaro.com>,
        "Jiang, Dave" <dave.jiang@intel.com>, Vinod Koul <vkoul@kernel.org>
CC:     Eric Auger <eric.auger@redhat.com>,
        "Liu, Yi L" <yi.l.liu@intel.com>,
        "Pan, Jacob jun" <jacob.jun.pan@intel.com>,
        "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Jean-Philippe Brucker" <jean-philippe@linaro.org>
Subject: RE: [PATCH v9 09/11] iommu: Prepare IOMMU domain for IOPF
Thread-Topic: [PATCH v9 09/11] iommu: Prepare IOMMU domain for IOPF
Thread-Index: AQHYhX4Co7eoDM+XZUiUgFo8UF9Xaq1khWPA
Date:   Tue, 28 Jun 2022 08:29:09 +0000
Message-ID: <BN9PR11MB527687EE83BC26F08A7D99908CB89@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20220621144353.17547-1-baolu.lu@linux.intel.com>
 <20220621144353.17547-10-baolu.lu@linux.intel.com>
In-Reply-To: <20220621144353.17547-10-baolu.lu@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Xwntihsir9Zib6ZEiP4fzZyPyAaWXqAc91XPB6VHYuqapZx/VjovSibAxSOB?=
 =?us-ascii?Q?Dn1kdW3YOUYfQKB5S5DZfLoA1HYt9xjUKc0H6gJD+/jA+BCIo15Q/tXhTrQT?=
 =?us-ascii?Q?X0j+osLN2pq908YnxGTZoavKC9tWpe/Z2d7gcnUeDh2d4aekbKtmuIXubzF+?=
 =?us-ascii?Q?dSJRfi/DC6ctHJfiU0Qpmd/JV+muWvy2q2VKn7ZDOQiWU4p5RiV6apvLcBBP?=
 =?us-ascii?Q?FsJSzPqaLTOQgD5VVyzvdIE+QNYWGXRJ95RSFi3gEEtPL7jpOHvsVnld9fTQ?=
 =?us-ascii?Q?0HC5ABw8bJtHrDjpU2GDQYo2wIMC96ZUAS7PyvT38HxPn121OyOOsxsYDqlD?=
 =?us-ascii?Q?NuErBk+G4RcIzXqpDM7PDEbumrgmJFcboO+LWpWni3WeXsKfxX4mKhQ1nen3?=
 =?us-ascii?Q?XtbrcHaZfq/+wxYECiIsgG8Rl/4BL1PQs4Cyo7hdTos/LWmZEFZisKb6056e?=
 =?us-ascii?Q?w6hwqoSqZaX7FmqV5daPEg+FgOblCgIu7snjAsq0QuoPa0WYZFcBC/npkEUw?=
 =?us-ascii?Q?CO4zRdPqvOtxLQojHWr71FewK/cDxiNN6uwAAa6vuv/TxeAEyGH3Bxd0PnRE?=
 =?us-ascii?Q?rmvQz97goXMRD9frkJ105hyicG7VIErsslS24k8luOp0JSA4hAcIfHV8vttf?=
 =?us-ascii?Q?TLUj0MVll+bJaHxAY6ewBuyh6N0olxXGuZ9PxiiPcmcbCdQ6D1uBdthSmwxE?=
 =?us-ascii?Q?IZvk3kOfe4kbwxabA6loP2FWqV71nwUZf018KshIdcb4EO3KaWxGq/wW1VQf?=
 =?us-ascii?Q?K7cNeBrQKgleUkJMvMAQRNH9aZTLnNB+XdBWiuLneAzxYhXTlF1il1KIhzkm?=
 =?us-ascii?Q?UtDL15qTRyLhIV/RCyOdcggrLCoBj9YxcVnnW8FcltIg0FI5clAcxgd0lRU7?=
 =?us-ascii?Q?fItJIOHvZwtwFBB9HBrCo9nnDOwGh+myfSi7PgcsXDWT0iDYM2iWCiYRe7fC?=
 =?us-ascii?Q?FwFSELQQVejmPgqBFM0VX+2MV9E24CZRk9YV4VlFkKb/WT9fg0Bj4V0sPgKn?=
 =?us-ascii?Q?ISShfux1JLit94pmZG37wkKCoPAeAc1pLl/XxXgv1WZx8XbyjQkWny4qpn4K?=
 =?us-ascii?Q?dS+cDfb+9nBOvnyRlDzXLE4MLm2/Jn8ZGKLAXc9vYdJ0qsfi95CYVV7LDGz9?=
 =?us-ascii?Q?rEGhQq2zB6RQ/gqiXwuhBBXtbR3UqUkJ+shZMWguGTH6cMXSzyLi3hC/Bil9?=
 =?us-ascii?Q?fckyTZcvDauEHnL7l9qiEzD2aGvoABfg0MRp6hN3eYnUNpTD8rC4UKCP83L1?=
 =?us-ascii?Q?aeGvvYbLJ124SNIAOILCuHhUQnHAOXEvKM+CQ06JXVrKzKJ03br2/67NZnn8?=
 =?us-ascii?Q?xm1Zz0UPMR/wF5E2Z1kw5IXk8zkk7VBtEOv2AADamPX6XJrQl6Pv8GK96isz?=
 =?us-ascii?Q?cLTxgiMWdUWwcp66jVk8WXLvHIp8JUPNGnGyn/hdq6oBplp7hSf879SfDilX?=
 =?us-ascii?Q?NCKONjlO8B5QPOPvsCoxT0HIXqvyIbXGYGp7CBFr9rEdMWz/t7AdYV44gNA3?=
 =?us-ascii?Q?q31UChmRkpgw/j/OXrFo85d3P740qLYC54lhB4BkbUU+H/923m44SvYOW9VQ?=
 =?us-ascii?Q?j2MapBZ02Yw4gn8ZIAyttveAo7WUVVYMkVJ8RilY?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 98930d55-d991-4733-6bf4-08da58e045c8
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2022 08:29:09.2607
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: q51Uu6qU0wV6q3JNt3NHQvwjzmAWcgvIS/Zfa0G09ANj5yx+J4qzJ4z2XBY9LC9kiWeOW6rt6noksb8KP528Vw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3260
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Lu Baolu <baolu.lu@linux.intel.com>
> Sent: Tuesday, June 21, 2022 10:44 PM
> +/*
> + * I/O page fault handler for SVA
> + */
> +enum iommu_page_response_code
> +iommu_sva_handle_iopf(struct iommu_fault *fault, void *data)
> +{
> +	vm_fault_t ret;
> +	struct mm_struct *mm;
> +	struct vm_area_struct *vma;
> +	unsigned int access_flags =3D 0;
> +	struct iommu_domain *domain =3D data;
> +	unsigned int fault_flags =3D FAULT_FLAG_REMOTE;
> +	struct iommu_fault_page_request *prm =3D &fault->prm;
> +	enum iommu_page_response_code status =3D
> IOMMU_PAGE_RESP_INVALID;
> +
> +	if (!(prm->flags & IOMMU_FAULT_PAGE_REQUEST_PASID_VALID))
> +		return status;
> +
> +	mm =3D domain->mm;

What about directly passing domain->mm in as the fault data?

The entire logic here is only about mm instead of domain.