Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 28 Jun 2022 09:25:25 +0100
Message-ID: <877d512o0a.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     Stafford Horne <shorne@gmail.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Openrisc <openrisc@lists.librecores.org>,
        Jonas Bonn <jonas@southpole.se>,
        Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] irqchip: or1k-pic: Undefine mask_ack for level triggered hardware
In-Reply-To: <20220628012854.681220-1-shorne@gmail.com>
References: <20220628012854.681220-1-shorne@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Tue, 28 Jun 2022 02:28:54 +0100,
Stafford Horne <shorne@gmail.com> wrote:
> 
> The mask_ack operation clears the interrupt by writing to the PICSR
> register.  This we don't want for level triggered interrupt because
> it does not actually clear the interrupt on the source hardware.
> 
> This was causing issues in qemu with multi core setups where
> interrupts would continue to fire even though they had been cleared in
> PICSR.
> 
> Just remove the mask_ack operation.
> 
> Signed-off-by: Stafford Horne <shorne@gmail.com>
> ---
> Note,
> 
> I currently have this queued with openrisc fixes for 5.19-rcX.  If this is ok
> with the IRQ maintainers I would like to have this merged via the OpenRISC
> queue.
> 
>  drivers/irqchip/irq-or1k-pic.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-or1k-pic.c b/drivers/irqchip/irq-or1k-pic.c
> index 49b47e787644..f289ccd95291 100644
> --- a/drivers/irqchip/irq-or1k-pic.c
> +++ b/drivers/irqchip/irq-or1k-pic.c
> @@ -66,7 +66,6 @@ static struct or1k_pic_dev or1k_pic_level = {
>  		.name = "or1k-PIC-level",
>  		.irq_unmask = or1k_pic_unmask,
>  		.irq_mask = or1k_pic_mask,
> -		.irq_mask_ack = or1k_pic_mask_ack,
>  	},
>  	.handle = handle_level_irq,
>  	.flags = IRQ_LEVEL | IRQ_NOPROBE,

Acked-by: Marc Zyngier <maz@kernel.org>

Feel free to take this via your tree.

	M.

-- 
Without deviation from the norm, progress is not possible.