Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        Jason Gunthorpe <jgg@nvidia.com>,
        Christoph Hellwig <hch@infradead.org>,
        "Raj, Ashok" <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
        "Robin Murphy" <robin.murphy@arm.com>,
        Jean-Philippe Brucker <jean-philippe@linaro.com>,
        "Jiang, Dave" <dave.jiang@intel.com>, Vinod Koul <vkoul@kernel.org>
CC:     Eric Auger <eric.auger@redhat.com>,
        "Liu, Yi L" <yi.l.liu@intel.com>,
        "Pan, Jacob jun" <jacob.jun.pan@intel.com>,
        "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Jean-Philippe Brucker" <jean-philippe@linaro.org>
Subject: RE: [PATCH v9 10/11] iommu: Per-domain I/O page fault handling
Thread-Topic: [PATCH v9 10/11] iommu: Per-domain I/O page fault handling
Thread-Index: AQHYhX4HMU+DWWITC0iALdyeXsFzmK1kiO3A
Date:   Tue, 28 Jun 2022 08:39:36 +0000
Message-ID: <BN9PR11MB52768181B0EB29DBCB11AEA68CB89@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20220621144353.17547-1-baolu.lu@linux.intel.com>
 <20220621144353.17547-11-baolu.lu@linux.intel.com>
In-Reply-To: <20220621144353.17547-11-baolu.lu@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/oTwxbzQLLLeB/bRtPg46EG3cGxT4ptrO8WzeG0Bx1RGFr27LDZvvoQKDtvT?=
 =?us-ascii?Q?rg5KydXCcyB/js7wODoB5T+pEkfPvhHAqKO8qt0QK8BeV0IrYThlnFDHxwQf?=
 =?us-ascii?Q?HG54KxvoE4B2oSpc9LbwwNsrjY/sUdnOpr7pLjp76ZxrrTfiLLPeh+5Eu6fW?=
 =?us-ascii?Q?IyUuLd/nmyQfUVrKmnjffvcPRu99A/3Ljk5XfTakK7I3ETI/VFXdoMPtfbjS?=
 =?us-ascii?Q?c0PeXi6sIuK5MG2Hmmywxip8fLQM7uWFYDejMCbcJ1X7MD2yXAvnUyZtcjUh?=
 =?us-ascii?Q?iI5EHjaAi6r6rUdTVMSxO1KB40gqSQB+M9CCCH7czSWIBqKPuTxa14wCar8p?=
 =?us-ascii?Q?WNkKWcleLP/KrfolVtRgGilDVchlOB2JYvUOZB8X5jiI3zUf0eJNGknguITX?=
 =?us-ascii?Q?lVmRSXJvI/xezf3g+YPdo83JaRrAR2BTgXjky67e6rFVHBQ32W81OauVBaG1?=
 =?us-ascii?Q?RT+us18ps4Qbf9rdpc2dh3sjT4qNyZLo4CktYSB84A659jCZnW87X8WJ1rIW?=
 =?us-ascii?Q?JsMCta+5j7a+h1E8dNN0zao138qA6V4FbWv/qXcVlqZ2QmW4EzO2jP9y6R/g?=
 =?us-ascii?Q?K0TD5SaUujO8Ii3T1acS2q+pq9VQjOkPo6KgWIkeNkCFT2Rkp8EQo9iHDL80?=
 =?us-ascii?Q?+xz5RO2XuID7FOzARIkgLNvceIwQAuIrRbAkcYkOzoO4DeBC/Jz5fXyfQJkD?=
 =?us-ascii?Q?e7QebSRJ5RUzut8YqqjplwBd6hMV+3DXP0veFufyYqC08guQ/GPJ883UbTAa?=
 =?us-ascii?Q?TKqE4ilZGp/fcJbcVSgpjR4vOrfvNNiB6nVu1q4wen9ROgGFPayYX4rNp5ha?=
 =?us-ascii?Q?LL0weeqTL4raPnoAYw7O++m6htSrIq533q8QyAsnR9gQvK7pronSa/2q+HR/?=
 =?us-ascii?Q?iQ/9C1NmnGrqDm/KznLE0uU0sJN7BHKXcaE5qjzLTTfcS8qrKRCdvyL55zyU?=
 =?us-ascii?Q?w9bwVXVYJAXKiOO59AtSkbm7czySmo7+tvSzodd8yEaEqJAPdFBnsXwfa/er?=
 =?us-ascii?Q?nfYAfq5WAb3B7+Sq/0/TPCWbv44eZFa2YIg0jO8t0Az+4C7xelx3B2CWUeB9?=
 =?us-ascii?Q?WGnTSCWwaPdF+WqPMEab/GUPigFUAsCOvfeeZLaIjndWsBFBkM8ZP0+Ksi1P?=
 =?us-ascii?Q?UP6fLVXKTs5lYorAA/6LGioOVjp6ivHcdbo4dYAVFeWbSSIldQsvGTJT7WEQ?=
 =?us-ascii?Q?oUQtlXRndwWXSlsiZgh8bKdgLnA017C1G+Z8ZJ82TkavghMDdA6DyPqZvfiu?=
 =?us-ascii?Q?Tyo8/FM4eg4h0ObFQcLwPOVr7XrWZqNxcFOrzyhMUsTQB5EhbYwkaqTryOk9?=
 =?us-ascii?Q?YMVm5y7lKxbJ+VzqdCOcWOvrVzT8pr0233lcFr/lAQimyporfWNN/YhsW23w?=
 =?us-ascii?Q?y+Vwlqf05CDkuuVwP7po0PVGX5/xoOYYyM1KxhSAo+SMwtvJfqToNZl3NOfx?=
 =?us-ascii?Q?L4cfdebcnzrEQjrdm0zFTNUJU1gz2E+hWAMMLJ9ix+ocFEXd01rPUh0e7hfm?=
 =?us-ascii?Q?GoxltelK1JDH8rUR7ekz5Ikw2DVwFR5VrPam3M5CxRz4zAvI8/o2/zRpBzlT?=
 =?us-ascii?Q?2Wrr9yCn9CIm7CpATk6S/R6VVYIXU5UI9p6f7rkj?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b462f284-969a-4d77-abaf-08da58e1bbd3
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2022 08:39:36.8287
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: v3P8xDqJCwFhFHg3a2AtE/rs09yMI/pbtOO1uHnpHqRkOfbfgobr5JXKUXWRs8VxrqOdb2fgrKHZ0UwauzQ9uw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6153
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Lu Baolu <baolu.lu@linux.intel.com>
> Sent: Tuesday, June 21, 2022 10:44 PM
>=20
> Tweak the I/O page fault handling framework to route the page faults to
> the domain and call the page fault handler retrieved from the domain.
> This makes the I/O page fault handling framework possible to serve more
> usage scenarios as long as they have an IOMMU domain and install a page
> fault handler in it. Some unused functions are also removed to avoid
> dead code.
>=20
> The iommu_get_domain_for_dev_pasid() which retrieves attached domain
> for a {device, PASID} pair is used. It will be used by the page fault
> handling framework which knows {device, PASID} reported from the iommu
> driver. We have a guarantee that the SVA domain doesn't go away during
> IOPF handling, because unbind() waits for pending faults with
> iopf_queue_flush_dev() before freeing the domain. Hence, there's no need
> to synchronize life cycle of the iommu domains between the unbind() and
> the interrupt threads.

I found iopf_queue_flush_dev() is only called in intel-iommu driver. Did
I overlook anything?

>  static void iopf_handle_group(struct work_struct *work)
>  {
>  	struct iopf_group *group;
> +	struct iommu_domain *domain;
>  	struct iopf_fault *iopf, *next;
>  	enum iommu_page_response_code status =3D
> IOMMU_PAGE_RESP_SUCCESS;
>=20
>  	group =3D container_of(work, struct iopf_group, work);
> +	domain =3D iommu_get_domain_for_dev_pasid(group->dev,
> +				group->last_fault.fault.prm.pasid);
> +	if (!domain || !domain->iopf_handler)
> +		status =3D IOMMU_PAGE_RESP_INVALID;

Miss a comment on why no refcnt is required on domain as explained
in the commit msg.