Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp3756357iog; Tue, 28 Jun 2022 02:01:26 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vL80t6AK4FApE4H9/fin3kMZwgJUswsS+6hyPIhv+ljJuF664VRAfDyQQiiY9laQ/F+UWr X-Received: by 2002:aa7:cc03:0:b0:435:5574:bf30 with SMTP id q3-20020aa7cc03000000b004355574bf30mr21915701edt.15.1656406886726; Tue, 28 Jun 2022 02:01:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656406886; cv=none; d=google.com; s=arc-20160816; b=IXXjCsuSaJc+VgwhvyBeseBEe6YFasKjrfKeH0XJBkldjEeiAE6TqpnxKtcfVOPikN CidKWgP7gC28ZGoHHPt0BVOIOVtvRMwTddAQMhQu3h4O6POEisufvN2wCxsiPmkN38QS a43rXO8IAe3AX5LTcLBFo9c43LvI/irPnIckTMoWVNeBTpRCJGJXTs1d1Ufu7MQX4rQ3 tjfAVSVbv9TaTJ3az8tx93171jp47ZvBCg0snu33/HNYxi2K2dxwt4FNCa2PiLofHBPF kai0T7p8/8uK0l9f4a4irlinHnNyIoqxkr+TrePgPOpqijBf3H/ErY626ZIKsF6s+QS1 qGWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=p6k9PAUGs1z+JQ0fp9zJbrOIxdGLr6+feq4PW23Em44=; b=qEFuDRUojbQNUypF0GYW2jgy8BXOXf6OMUSQHYLrooWWBcprvvJzHzsdVcKaJU2Iyo xzpkHrLRQ9Y4rnS5VSVynerzoTlZ2WNog87HI16oPygeJLr+Y6o4MFVWGUxfdRPrFVOk NLKbHuRwuh696uZ2v6y+GNdr5LYdl+0ugMqRR9A0xkgKx8Qi3OzfgmKzuzARJHMhRhbJ xiUgB/7p+krs4KObhyMH4enH4GT72aPE9q6fKCHdE2UKGuQWoKw5zCFeD4cZdmrXeZ5B bSCB4nY+lEV41v1SgTFaYZz9CEIqnFBgqw3XRV4KmcwOee7xr7oJtTlSycWpKtiiOhRC rRbw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y6-20020a056402440600b004357f4a93absi18817302eda.611.2022.06.28.02.01.01; Tue, 28 Jun 2022 02:01:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343905AbiF1Iif (ORCPT + 99 others); Tue, 28 Jun 2022 04:38:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344257AbiF1IiN (ORCPT ); Tue, 28 Jun 2022 04:38:13 -0400 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DD6E39F for ; Tue, 28 Jun 2022 01:38:12 -0700 (PDT) Received: by mail-ed1-f50.google.com with SMTP id r18so8614386edb.9 for ; Tue, 28 Jun 2022 01:38:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=p6k9PAUGs1z+JQ0fp9zJbrOIxdGLr6+feq4PW23Em44=; b=wqvzKGgDVWcxEbh/XlZDO28lM4QcPStqux2QSLQGppBXktNm3IQ6jqd4kOLjO7Ybxt O7g6WhMImOLfFSnMzTYcXUznlKewTqTIw96SZATPsHPEItX6kLtJhif4CbEeWhm2DifP Ya5ukEGtDg+QnSzlDdoXbr9tGu5VwcLPNW8i3KLn5dRe0lTap1iyf1o2xtzQmF5cLzy+ YQH43DXRqDLyjNXQtPdOUTX1UsO6pgi9qKN/8LCDGmWZltfik6c1IbJ/pqEDq4NhEMxs 8yUmx1pPc8c5D5ZUIfSjecfLae0qTTNN+hnd8jbtzg9yLmBCuUPZbMp4TNof374L7PI7 xSXQ== X-Gm-Message-State: AJIora9iYbrT1VbeVeF3XmNGZyC9v0S9ix+NUpwQA8qQgYaq8a5unvzv k+pmbdsE44+SpPcRbzvrN+s= X-Received: by 2002:a05:6402:27cf:b0:435:dae6:26aa with SMTP id c15-20020a05640227cf00b00435dae626aamr21523064ede.323.1656405490615; Tue, 28 Jun 2022 01:38:10 -0700 (PDT) Received: from ?IPV6:2a0b:e7c0:0:107::70f? ([2a0b:e7c0:0:107::70f]) by smtp.gmail.com with ESMTPSA id i10-20020a170906698a00b0071cbc7487e0sm6163445ejr.71.2022.06.28.01.38.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Jun 2022 01:38:10 -0700 (PDT) Message-ID: <466232ee-8d55-e33f-d2ca-e6b9fc0b8103@kernel.org> Date: Tue, 28 Jun 2022 10:38:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] vt: fix memory overlapping when deleting chars in the buffer Content-Language: en-US To: Yangxi Xiang Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Johan Hovold , Igor Matheus Andrade Torrente , Christian Borntraeger , nick black References: <10b4e5f7-95b9-38e6-bcd5-1132d595301c@kernel.org> <20220628082740.4685-1-xyangxi5@gmail.com> From: Jiri Slaby In-Reply-To: <20220628082740.4685-1-xyangxi5@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28. 06. 22, 10:27, Yangxi Xiang wrote: >> Why not to use memmove in both cases? I.e. simply switch scr_memcpyw to >> scr_memmovew? > > Both of them works, and I pick one of them. Sorry, I don't understand. -- js suse labs