Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp3762087iog; Tue, 28 Jun 2022 02:08:23 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sah2CF69mFOZpJH+WOJjoar4n9IgyfVvYx1i7at7xqSZuXlN6XLCxl+916CPqoQY3qerRt X-Received: by 2002:a17:907:1620:b0:726:c0d8:7578 with SMTP id hb32-20020a170907162000b00726c0d87578mr5046245ejc.587.1656407302835; Tue, 28 Jun 2022 02:08:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656407302; cv=none; d=google.com; s=arc-20160816; b=HWpwzdWl8oshoqvCTmsZlIwq61qL/67tkf9a3+RnQOLJXTiCVDMKNIfWXZPfXHvd8d u6zi6f4yYCN4YF7vCLcrYM/FQ0ubWTyVA1YtrNVDDjr8Jw0BCWpeUKM/+wpuZck0ZE/u 9OSaayKycbJdbzmkEBE4Lnk1NiH6XkAPLEl4WGKzK1pN8oIUVmaHADxwOCMIfvoBigUh jl0xWCoM6U3/ewlshZSxEM1xfyiKJdy05jqgnoCPMIVwbeJHd5UOBiiD1KDHzbOyLlSq 3mHbVKMJLRj2Mc8cOrNG49lC7wCK3PnzypSDLKZE4LUjaKH49zDErYgWu6JdjXftTIT1 izIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=ktYB12CuOtgWAClcueyNRFthVvE6XX0IoFemGmYs/DY=; b=OFOI2z0aTndJWcUpbqz9agj7YvZuoVkK5D5B7Z+QKAosI5/xfXaKQhL2QYQOkmuwMq /NpBugINg4ftyp9EWog9Q9MuRXAy8wgDGyWnfL8QA6UEW8BGSUSwH2FTvR8Y8YsHJ66t 86cfnXaEqd+IXxP7O/osbyRD6ShBCgecbD2QV+E+/IZgJLWfTkxE1mC2MbPc9kDkzoDb KVW0P16+5ui01wLCvucnPiOHi+bs7/jVovPLfHUHxfpPtro1Dgtv/VaHd5QSRc6mBSzq K1nVE47tf03LXXobVnxV0f/W10EPgMh7n8lxKQxr6RxM7Kd8rLQZko3YWUuE4ShATh7M XSjg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=B1HxFpCw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hr30-20020a1709073f9e00b00711fa454fb3si14721091ejc.889.2022.06.28.02.07.56; Tue, 28 Jun 2022 02:08:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=B1HxFpCw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229993AbiF1I7o (ORCPT + 99 others); Tue, 28 Jun 2022 04:59:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232339AbiF1I7k (ORCPT ); Tue, 28 Jun 2022 04:59:40 -0400 Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D759FD1A for ; Tue, 28 Jun 2022 01:59:39 -0700 (PDT) Received: by mail-pf1-x42d.google.com with SMTP id t21so11441848pfq.1 for ; Tue, 28 Jun 2022 01:59:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ktYB12CuOtgWAClcueyNRFthVvE6XX0IoFemGmYs/DY=; b=B1HxFpCwwpSl4XqvW/n+RUwu6bw2AeEOralrpD9fzeExPBm7O7fsn/BA/9LtbPyWpv aRUfU5URixo0ywnsoAtwRT3XpXftdHxQCp1W9kug8nfWeRHi640WORv3XFiIvxKFv3YC Hq5ao/Q0wjz7wECHzgSTlC9tQ8hsLk2QL8GtcTjEOSap/TWnrDnZ18AZ3HD0falKK2bt E0HS2SOIu5LzuC9f/gw7wlEmTlz2YB10TGg8U5wPDj9Q5EiUoy2OPY5+y1aT+rnNjrwS Zb28B5WLVfFHPfIAUjv96QbKaNifQfboe+qa4GbVi8NVLs3Oxj/3wGahm0+Dw5KhM2lg bhag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ktYB12CuOtgWAClcueyNRFthVvE6XX0IoFemGmYs/DY=; b=tOIgtN7yVBsoPmlYxMEe/RgQp1LK93DqmkU5MxRrupp9PMZJVp65S44XaRMxMZyptU 84fbzI62ou3kRbje2roTZHz6vnTPbbJB6+xyaIpWfcRG01+eIxgVrdIKy4sTs2f7IwXe /a2KNO9rKpzCWgWrqkyqMzNH4frm3KqcOvKnCbTznp30nkwX6lBZm8WluUK/JsCqMJd8 egJoDxpeFZvUszZzkCZNiH0xwaCKlLIsTUEdr18CIP7urfKtoDju2CZK38N+HKAErlmv ozhji2bmJeCKXxRTpUW2Sh45lm+Hca8w6ZvQNfAu+P4UQjVekFcEvrx4iEomVTcdlrPk oPxA== X-Gm-Message-State: AJIora9DcANLQfPTRb/EIPA5lLyvMyuBWNN2x4C6ww86T6n0aUm3en2x 0WKmKd6RUJ+YjRdO8U7K/uU= X-Received: by 2002:a05:6a00:23c5:b0:525:7f37:b9a9 with SMTP id g5-20020a056a0023c500b005257f37b9a9mr2625443pfc.20.1656406778586; Tue, 28 Jun 2022 01:59:38 -0700 (PDT) Received: from desktop-hypoxic.kamiya.io ([42.120.103.58]) by smtp.gmail.com with ESMTPSA id x9-20020aa784c9000000b005251fc16ff8sm8736481pfn.220.2022.06.28.01.59.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 01:59:27 -0700 (PDT) From: Yangxi Xiang To: Jiri Slaby Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Johan Hovold , Igor Matheus Andrade Torrente , Christian Borntraeger , nick black Subject: Re: [PATCH] vt: fix memory overlapping when deleting chars in the buffer Date: Tue, 28 Jun 2022 16:59:22 +0800 Message-Id: <20220628085922.22460-1-xyangxi5@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <466232ee-8d55-e33f-d2ca-e6b9fc0b8103@kernel.org> References: <466232ee-8d55-e33f-d2ca-e6b9fc0b8103@kernel.org> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> Both of them works, and I pick one of them. > > Sorry, I don't understand. We can use both scr_memcpyw() and scr_memmovew() for the not overlapping case (cp <= nr), which is more likely to happen. In this case I keep using scr_memcpyw(). Yangxi Xiang