Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: Af3MGvAApKtxwOhyv8Zy7EeLZkxH+QOad7BxnyylGS4VGF1HeIbvjtSTcbdgdjXaG2Lh6hXzgs
 U9+fQUnLQjMWyLRgIY9sNI4BULRq/p6sF1G3XmG8wtgep4XSUFlUDQjZ+hZMeyvRgILnhJs+bH
 9eEFKvKnB9ZGm8Ty+rSN+TuFkt5N3Y2wz7vKrvNgCWSmxP1RCuLnSKfh6u7afYKtDz+SzFuCY+
 3UCXfEy3nF1VKXP0Mr6It0K0QDCNPW6E1CRwXAiCvZQbKlKHGvNzmv/8nbMW0xnpZHcbhtELlS
 qV32qI10vTvb6hBWvhDjzA86
IronPort-SDR: ggxvr5zFN8GVH1x5teq5WErLuSDSBSEdW1dgBSufj0K+Ycq3I6S9l4Vqv/MbmQNn7Wkgy7IVPF
 IzpMxlFFwHGG5N3ym7KSsLkMpJTLEz2Eov/w3rOaSmHOOFBDRq0wlcLX7Z1xgY41IUCDzCtXVp
 DD9omeFyAHFH0lZUG4BZJ999Y6FRwco2CmlQsVsEWLIHrJm7n01lOzke5tpByMCO1oQ8zbElqb
 2scMGcgFIjxZcl6u5WEb5S9426Kb8W6zJYeyFpVRVo6pYFpT/TsoeaqgxQrr1N+cTu9oHZ7hIk
 orI=
WDCIronportException: Internal
Message-ID: <ba59a0da-a982-e3eb-1cb7-6e60f80fd319@opensource.wdc.com>
Date:   Tue, 28 Jun 2022 18:14:25 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH v4 5/5] libata-scsi: Cap ata_device->max_sectors according
 to shost->max_sectors
Content-Language: en-US
To:     John Garry <john.garry@huawei.com>, joro@8bytes.org,
        will@kernel.org, jejb@linux.ibm.com, martin.petersen@oracle.com,
        hch@lst.de, m.szyprowski@samsung.com, robin.murphy@arm.com
Cc:     linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-ide@vger.kernel.org, iommu@lists.linux-foundation.org,
        iommu@lists.linux.dev, linux-scsi@vger.kernel.org,
        linuxarm@huawei.com
References: <1656343521-62897-1-git-send-email-john.garry@huawei.com>
 <1656343521-62897-6-git-send-email-john.garry@huawei.com>
 <b69c6112-98b7-3890-9d11-bb321a7c877a@opensource.wdc.com>
 <6619638c-52e8-cb67-c56c-9c9d38c18161@huawei.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <6619638c-52e8-cb67-c56c-9c9d38c18161@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/28/22 16:54, John Garry wrote:
> On 28/06/2022 00:24, Damien Le Moal wrote:
>> On 6/28/22 00:25, John Garry wrote:
>>> ATA devices (struct ata_device) have a max_sectors field which is
>>> configured internally in libata. This is then used to (re)configure the
>>> associated sdev request queue max_sectors value from how it is earlier set
>>> in __scsi_init_queue(). In __scsi_init_queue() the max_sectors value is set
>>> according to shost limits, which includes host DMA mapping limits.
>>>
>>> Cap the ata_device max_sectors according to shost->max_sectors to respect
>>> this shost limit.
>>>
>>> Signed-off-by: John Garry<john.garry@huawei.com>
>>> Acked-by: Damien Le Moal<damien.lemoal@opensource.wdc.com>
>> Nit: please change the patch title to "ata: libata-scsi: Cap ..."
>>
> 
> ok, but it's going to be an even longer title :)
> 
> BTW, this patch has no real dependency on the rest of the series, so 
> could be taken separately if you prefer.

Sure, you can send it separately. Adding it through the scsi tree is fine too.

> 
> Thanks,
> John


-- 
Damien Le Moal
Western Digital Research