Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp3786654iog; Tue, 28 Jun 2022 02:47:23 -0700 (PDT) X-Google-Smtp-Source: AGRyM1s7tWzPMtAfxhCcYwhtn6emeCeuXKpNP+HVsMSm74PSKa7q8sTGHXY+Y4YbedtP149D6ePK X-Received: by 2002:a17:902:ab87:b0:162:26cf:bf7a with SMTP id f7-20020a170902ab8700b0016226cfbf7amr3955099plr.168.1656409643052; Tue, 28 Jun 2022 02:47:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656409643; cv=none; d=google.com; s=arc-20160816; b=Gv1mJbewr7UmD93Eq4431pDu276QrmUoS60ws7w+cAE8ifeyXqVqXlLmqmugQByglU wD8lp+nv4gOdFr9UOJfQLZdTte2KOYSfx1KJEMY/q93mI1WFJ5vEyTT2meLK3f426GdH 2SmcAmZP4n7sRfTPqqazS4jtskYS7lTLPOnIuwj6NwXlI8Orz5fCx/nsk1sekFf7J4N0 4tP5SeiOZev3ucu0spB3Bn0OOpGuJBJj5pt7gszs+VXjZvONimdENR0dJVwyF54s6zHA W3k4rzBi7yp+7/Rb5ZoYL6VHhZXnWckj/HeTcQqGOQ3CWXAa4ixuE0g3IQIiJ5l8f5gL U73w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=23v656EJZgZ2B3RKrxYupmYVBHtGwcHmW+F/2IUSaFE=; b=GNWbJVr71cnQ2Ggl9ZpOAkhcJwz/3xdhQYUtuts1kx01ers7A31XPfv+hRI1nksOFg BYWNnbHb089Lgdj/6gPuYBHTr8hcrmve4f+PxDP9wHUIitl5S4fahLevKMJ2BfRJ2/oj noljxTgpU0mvMNapokx+yZMf8AB9Dcu67asQ72cRB0iYS/32PB9opxtpFaYjQu7x0jG8 X3JarjCF36ohTKvxrmNDxLhH44zWKgYCOrWyCaKLGVy09QWzIKeDJFzYGFZMApHQchBq +82a3YQyK7ywFn4sCUG9jXBs7uNGTSGTHyPrRN350asDzjrwdKcoqwpR9q8+6JMNRBbX 41yw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=O5kYOGNE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nv12-20020a17090b1b4c00b001e31a305868si27037061pjb.168.2022.06.28.02.47.10; Tue, 28 Jun 2022 02:47:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=O5kYOGNE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344106AbiF1JQz (ORCPT + 99 others); Tue, 28 Jun 2022 05:16:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242975AbiF1JQw (ORCPT ); Tue, 28 Jun 2022 05:16:52 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADD011838E; Tue, 28 Jun 2022 02:16:51 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6B0341FD97; Tue, 28 Jun 2022 09:16:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1656407810; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=23v656EJZgZ2B3RKrxYupmYVBHtGwcHmW+F/2IUSaFE=; b=O5kYOGNEuWcGqJsOSHgLzYULiCCU0PUt++61xI0DIuCuCUtRWjJEKfxOKzyFWoxdBB0XJu 7NkDIhBZwwj1lpQ1NmhL/PBQ6RhDgr4rjeikGdfq+oJAVz76W6bNJMKoFaY6DHgUhwwfjV pANFO/pJwqXmHAQJ4E1yl2rFcInDtws= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 301DB139E9; Tue, 28 Jun 2022 09:16:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id /YTtCgLHumI1RQAAMHmgww (envelope-from ); Tue, 28 Jun 2022 09:16:50 +0000 Date: Tue, 28 Jun 2022 11:16:48 +0200 From: Michal =?iso-8859-1?Q?Koutn=FD?= To: Vasily Averin Cc: Roman Gushchin , Shakeel Butt , Michal Hocko , Tejun Heo , Zefan Li , Johannes Weiner , kernel@openvz.org, linux-kernel@vger.kernel.org, Andrew Morton , linux-mm@kvack.org, Vlastimil Babka , Muchun Song , cgroups@vger.kernel.org Subject: Re: [PATCH cgroup] cgroup: set the correct return code if hierarchy limits are reached Message-ID: <20220628091648.GA12249@blackbody.suse.cz> References: <186d5b5b-a082-3814-9963-bf57dfe08511@openvz.org> <17916824-ba97-68ba-8166-9402d5f4440c@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <17916824-ba97-68ba-8166-9402d5f4440c@openvz.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 28, 2022 at 06:59:06AM +0300, Vasily Averin wrote: > I would agree with you, however in my opinion EAGAIN is used to restart an > interrupted system call. Thus, I worry its return can loop the user space without > any chance of continuation. > > However, maybe I'm confusing something? The mkdir(2) manpage doesn't list EAGAIN at all. ENOSPC makes better sense here. (And I suspect the dependency on this particular value won't be very wide spread.) 0.02€ Michal