Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 28 Jun 2022 11:28:33 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc:     linux-kernel@vger.kernel.org,
        Amarula patchwork <linux-amarula@amarulasolutions.com>,
        Oliver Hartkopp <socketcan@hartkopp.net>,
        michael@amarulasolutions.com,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Wolfgang Grandegger <wg@grandegger.com>,
        linux-can@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v4 05/12] can: slcan: use CAN network device driver API
Message-ID: <20220628092833.uo66jbnwhh5af6je@pengutronix.de>
References: <20220614122821.3646071-1-dario.binacchi@amarulasolutions.com>
 <20220614122821.3646071-6-dario.binacchi@amarulasolutions.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="4o7tiudpedbts5sa"
Content-Disposition: inline
In-Reply-To: <20220614122821.3646071-6-dario.binacchi@amarulasolutions.com>
Precedence: bulk


--4o7tiudpedbts5sa
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 14.06.2022 14:28:14, Dario Binacchi wrote:
> As suggested by commit [1], now the driver uses the functions and the
> data structures provided by the CAN network device driver interface.
>=20
> Currently the driver doesn't implement a way to set bitrate for SLCAN
> based devices via ip tool, so you'll have to do this by slcand or
> slcan_attach invocation through the -sX parameter:
>=20
> - slcan_attach -f -s6 -o /dev/ttyACM0
> - slcand -f -s8 -o /dev/ttyUSB0
>=20
> where -s6 in will set adapter's bitrate to 500 Kbit/s and -s8 to
> 1Mbit/s.
> See the table below for further CAN bitrates:
> - s0 ->   10 Kbit/s
> - s1 ->   20 Kbit/s
> - s2 ->   50 Kbit/s
> - s3 ->  100 Kbit/s
> - s4 ->  125 Kbit/s
> - s5 ->  250 Kbit/s
> - s6 ->  500 Kbit/s
> - s7 ->  800 Kbit/s
> - s8 -> 1000 Kbit/s
>=20
> In doing so, the struct can_priv::bittiming.bitrate of the driver is not
> set and since the open_candev() checks that the bitrate has been set, it
> must be a non-zero value, the bitrate is set to a fake value (-1U)
> before it is called.
>=20
> The patch also changes the slcan_devs locking from rtnl to spin_lock. The
> change was tested with a kernel with the CONFIG_PROVE_LOCKING option
> enabled that did not show any errors.

You're not allowed to call alloc_candev() with a spin_lock held. See
today's kernel test robot mail:

| https://lore.kernel.org/all/YrpqO5jepAvv4zkf@xsang-OptiPlex-9020

I think it's best to keep the rtnl for now.

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--4o7tiudpedbts5sa
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmK6ybwACgkQrX5LkNig
010qdggAtdxAjabFrihePEFNk9ZUDi7eeXLiuqtrrmU2gUg88nVIvrbice7mjMcO
m7kFYlSE8iD8nE508gzdgdSDA6s8kav24uKnjjYh9DYkXoaQH5f4JaItkFoK5EDh
uIru50LF4l4Pb3uqOVy5UEYFkZ21g54M7xPEJ8k0Uz8VrKT2IzLPZX3q8H/getGJ
Oz+yOwtHnGJO473wXNjjaFMcYoycxTlDHVAk0SaL4Czy4p49PEAWcusXuFtgXthH
GEQieOTLS4UkLVpM3a93aQUa7PNe4Awv1+SG6HfAmltIrj6/iB0vey9puFbcOi5p
kIGRsHHQXrCaxK0tRC75zdxGabkf2A==
=02Mr
-----END PGP SIGNATURE-----

--4o7tiudpedbts5sa--