Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp3795764iog; Tue, 28 Jun 2022 03:00:22 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sKY5321H6osBF9r1b2NlZhNfEGhskDn5U1rcKk2dx58qjmJpDJlK5AYFdsjIgP3/LMCXVL X-Received: by 2002:a17:90a:8914:b0:1dc:20c0:40f4 with SMTP id u20-20020a17090a891400b001dc20c040f4mr26185775pjn.11.1656410422027; Tue, 28 Jun 2022 03:00:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656410422; cv=none; d=google.com; s=arc-20160816; b=oL7k8bDdvYXRi+a5+XgByE+xgCruXwTUICyqM6sSsok+pwLhv26XL+Xil9kjiWAlI4 RA2rO3rvsEnSo7MSIGNblT2kEWnToHf4LnXg3zGJlNjKqNDkccycGtqRvHo39N0HkA9v HAJB0AXYAvahw6wheQiSMXVZuG+/K8hSQRFh4rL0J5rAVGQHeMbC+Dc0+3to0mO9MEyo sNoSOX+VbGOc8tNlM9JsMaU2CuMmw4T25hwGjXrF6wjtPsDOjkfoQwPDq8TDpVdNjTzf KZYd1RwuErplc/gir9kjntA49j43KheObgvTI6O6afOcMYyZGSMN2G778r8Evzebqgkr YOhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=tKsl/FyBMuyoLwv1dbdkul0HUkyTRTbta9GTd/qg648=; b=Kvg0YfkIGCFx5uUTb2u9syHa3MIqgcJfCd9tweI+zb0HR/iz0lxPs73hGh0i42NUM0 3YdsVGiYtC5bNAL72rmZUHjN4BfVeGIqhq7wEEZ5vF6z9/oFdvC7YyevT6VQ6LgGDCpD TYJZpbmwitjgN7XGdPkg3YaL+0Hal/UmoKq+jzGNxZR/81fqOQZYh18q9G44mDNzWkDy A+tL6cgZja0FbS/s4hDq4ZTg+UTqvDCeeaVxxqebJCv44ajRRhFrcTCEYNv+5YC/Yn8g FnmZBGUk2YhTRI5XTgvjaqd16qqk3ZtSUQ4rV3bjvccDbfOPzNhEro2vIwZO4Xin3lVH bd+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=kmlXP3rm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c3-20020a63ef43000000b0040c7f6b4656si16928752pgk.201.2022.06.28.03.00.05; Tue, 28 Jun 2022 03:00:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=kmlXP3rm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344185AbiF1JYu (ORCPT + 99 others); Tue, 28 Jun 2022 05:24:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344184AbiF1JYQ (ORCPT ); Tue, 28 Jun 2022 05:24:16 -0400 Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8103227FF8 for ; Tue, 28 Jun 2022 02:24:11 -0700 (PDT) Received: by mail-pg1-x52e.google.com with SMTP id r66so11648526pgr.2 for ; Tue, 28 Jun 2022 02:24:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tKsl/FyBMuyoLwv1dbdkul0HUkyTRTbta9GTd/qg648=; b=kmlXP3rmTBXz5+4TJo//hmT2jB4MxmfWPs8iGQkHOlQBg+rsoPITThmujE5oZlqSyG fWu7CtFdyuxFIJPn+ajdlR9dCr4S51oy4WvnwewRQZdfq7E+j0mQSwzwRjSgIvguexqG fk3Qt+5y38+wp9WNkk+LMSBP0nc8nXemI+xT/4laLfvG8cccB66V1pbT2qVRKK9w1/7z UOZnxF6q0kGOYIWB/RFeprJs1fGdcR+PEaOaKE3JNBOyceQycTM2BgCSUGxmZLe99u1C xX95JGCPjlHlauI6BtduVriW4yYgE9uvq9xJq+thJNgUvkPEcXuFCutJkJYjKCnMEGKi LBKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tKsl/FyBMuyoLwv1dbdkul0HUkyTRTbta9GTd/qg648=; b=iWgwWiT9CF5DU7dMuZve8Z75K49m0vmDrPzmxwJLUGOFZ7xDI9FsFtrKxlKs7BCjXe gqkhNXXiRAavRer8U4WI4PXMOLeEmINiWg7SCNbugLCWgM+/VC/wxO2++0pjQsgqSCm9 kYKADxXzXfdLmK61cepjkxPfrtAXuUtJcvf0MW2V0qiUNx1npFhiKtVpwBNjCnEbbi+K ssNLU8tXVjamMwUnCCNFuw0SD07N1NLLn+KCtBO3conL0Cg1no94QAka6wjuIbO8pGGJ ChLl88fAismrdqRKpRRmr0K5cSgmxh+x9akNzNEyAklVE28/Br7wonJSNC/ok3uBCJJE GvWA== X-Gm-Message-State: AJIora84oWEoyF/zFC9ePsBWXYHnzZPQtNqRNGXXLo2ZKLtA/cxcnLLv RK04+1PIba8/hKDvYrrAINfa6Q== X-Received: by 2002:a63:a748:0:b0:40c:9a36:ff9a with SMTP id w8-20020a63a748000000b0040c9a36ff9amr16326337pgo.545.1656408251045; Tue, 28 Jun 2022 02:24:11 -0700 (PDT) Received: from FVFYT0MHHV2J.bytedance.net ([139.177.225.245]) by smtp.gmail.com with ESMTPSA id mm9-20020a17090b358900b001ec729d4f08sm8780463pjb.54.2022.06.28.02.24.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 02:24:10 -0700 (PDT) From: Muchun Song To: mike.kravetz@oracle.com, david@redhat.com, akpm@linux-foundation.org, corbet@lwn.net Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, duanxiongchun@bytedance.com, Muchun Song Subject: [PATCH v2 5/8] mm: hugetlb_vmemmap: replace early_param() with core_param() Date: Tue, 28 Jun 2022 17:22:32 +0800 Message-Id: <20220628092235.91270-6-songmuchun@bytedance.com> X-Mailer: git-send-email 2.32.1 (Apple Git-133) In-Reply-To: <20220628092235.91270-1-songmuchun@bytedance.com> References: <20220628092235.91270-1-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After the following commit: 78f39084b41d ("mm: hugetlb_vmemmap: add hugetlb_optimize_vmemmap sysctl") There is no order requirement between the parameter of "hugetlb_free_vmemmap" and "hugepages" since we have removed the check of whether HVO is enabled from hugetlb_vmemmap_init(). Therefore we can safely replace early_param() with core_param() to simplify the code. Signed-off-by: Muchun Song Reviewed-by: Mike Kravetz --- mm/hugetlb_vmemmap.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c index 4d404d10c682..b55be6d93f92 100644 --- a/mm/hugetlb_vmemmap.c +++ b/mm/hugetlb_vmemmap.c @@ -423,14 +423,8 @@ static int vmemmap_remap_alloc(unsigned long start, unsigned long end, DEFINE_STATIC_KEY_FALSE(hugetlb_optimize_vmemmap_key); EXPORT_SYMBOL(hugetlb_optimize_vmemmap_key); -static bool vmemmap_optimize_enabled = - IS_ENABLED(CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON); - -static int __init hugetlb_vmemmap_early_param(char *buf) -{ - return kstrtobool(buf, &vmemmap_optimize_enabled); -} -early_param("hugetlb_free_vmemmap", hugetlb_vmemmap_early_param); +static bool vmemmap_optimize_enabled = IS_ENABLED(CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON); +core_param(hugetlb_free_vmemmap, vmemmap_optimize_enabled, bool, 0); /* * Previously discarded vmemmap pages will be allocated and remapping -- 2.11.0