Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <YrrQOifFIiISf/3g@hirez.programming.kicks-ass.net>
In-Reply-To: <YrrQOifFIiISf/3g@hirez.programming.kicks-ass.net>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Tue, 28 Jun 2022 13:19:17 +0200
Message-ID: <CAK8P3a2XfzQo6emT4pXXxAjWewdP2LiAe2fOskFf-0suSmBJQQ@mail.gmail.com>
Subject: Re: [RFC][PATCH] kconfig: Add implicit CONFIG_ prefix to IS_ENABLED()
 and co
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     Masahiro Yamada <masahiroy@kernel.org>, mmarek@suse.cz,
        Paul Gortmaker <paul.gortmaker@windriver.com>,
        Arnd Bergmann <arnd@arndb.de>, Mike Rapoport <rppt@kernel.org>,
        Borislav Petkov <bp@alien8.de>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jun 28, 2022 at 11:56 AM Peter Zijlstra <peterz@infradead.org> wrote:
>
> Since IS_ENABLED() (and friends) are clearly meant to be used on
> CONFIG_foo symbols and IS_ENABLED(CONFIG_ is so long and almost an
> tautology, allow the more compact usage of: IS_ENABLED(foo).
>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>

I'd prefer to keep the more verbose usage, mainly because it makes it easier
to grep for a symbol. If today you do 'git grep CONFIG_PM_SLEEP', you find
all instances in Makefile, in #ifdef and in IS_ENABLED(), though not the
references in Kconfig language, which leave out the prefix.

If we remove the prefix for IS_ENABLED(), the same grep fails to get
all the results, while searching for the substring without the CONFIG_
prefix can end up finding false-positives by finding longer strings (e.g.
CONFIG_DEBUG_STACKOVERFLOW vs
CONFIG_HAVE_DEBUG_STACKOVERFLOW).

       Arnd